Project

General

Profile

Actions

Emulator Issues #5182

closed

variousSmallFixes branch pull request / code review

Added by lpfaint99 about 12 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Name of clone:
variousSmallFixes Branch

Purpose of code changes on this branch:
some random fixes that have been sitting in my local repo for months,
issue fixes, small refactoring, log message fixes & remove some useless logs a few new ini's
1 new feature / fix Ejecting disc by canceling the change disc dialog, i'm pretty sure we had this before but it was removed

When reviewing my code changes, please focus on:
most changes are minor, but I would rather have it looked at before it is merged to master. all changes have been tested thoroughly for regressions

After the review, please pull into branch:
master

Actions #1

Updated by parlane about 12 years ago

Do it. Looks good.

Actions #3

Updated by parlane over 11 years ago

  • Status changed from New to Fixed
Actions

Also available in: Atom PDF