Emulator Issues #5293
closedPull Request: Fix Mac build
0%
Description
Name of clone: adlr-mplus
branch: http://code.google.com/r/adlr-mplus/source/list?name=macbuildfix
(top 2 changes)
Purpose of code changes on this branch:
Fix compilation on mac when using cmake. Build instructions:
- install cmake if you don't have it
- mkdir output && cd output && cmake .. && make -j2
When reviewing my code changes, please focus on:
No breaking Linux or Windows
After the review, please pull into branch:
master
Also, I know I have commit privs, but I am very much in the habit of doing reviews before commit. If this is just not dolphin policy, I can stop, but I'd rather err on the side of safety, since I'm new here.
Updated by parlane over 12 years ago
Also I'd like to add, the reason you have commit access is because we somewhat trust you. So while reviews are not necessary they are still welcomed :)
Updated by lpfaint99 over 12 years ago
it looks like the logwindow crash was also fixed by r8bdf93a15c1162c15ef071a262038c36cfdab51e on the wxw3-update branch