Project

General

Profile

Emulator Issues #5365

"Auto adjust Window Size" does not work correctly with "Render to Main Window"

Added by pauldacheez over 8 years ago. Updated 3 months ago.

Status:
Accepted
Priority:
Normal
Assignee:
-
Category:
UI
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
Yes
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

The code that determines the size of the window doesn't seem to account for the button-bar and status bar that are on the main window, making the rendering box (is there a better name for that?) shorter by about 51 and 18 pixels, respectively, when rendering to main window. (Those heights are the same for Windows/Linux, right?) This puts black bars on the sides of whatever's rendering and shrinks it down a bit, which is obviously unsightly.

Setting the Internal Resolution to Auto (Window Size) seems to accommodate for the button/status bars when I resize the window. (I think. It's hard to tell just from looking at the non-anti-aliased edges of Link's hair and clothes in Wind Waker.)

Also, I can't help but notice that the text for the "Open" button is slightly misaligned - it's one pixel lower than every other button's text. But that's just nitpicking at this point.

(Dolphin 3.0-591, Mac OS X 10.7.3.)

History

#1 Updated by Staudi.Kaos over 8 years ago

I think the issue with the "open" button is just an optical illusion, at least it was in my case^

#2 Updated by pauldacheez over 8 years ago

No, it's real. See for yourself:
http://cl.ly/Fq7b

On further testing, it turns out that the Open button is positioned properly - all the other buttons are a pixel higher than normal. And only with the KDE-themed buttons. Which is irritating, because the KDE buttons are the only ones that don't look horrendous to me.

#3 Updated by Staudi.Kaos over 8 years ago

Ah, yes, I wasn't using the KDE-theme, you're right, there is a difference.

#4 Updated by Billiard26 almost 8 years ago

  • Status changed from New to Questionable
  • Issue type set to Bug
  • Relates to usability set to Yes
  • Category set to ui
  • Operating system N/A added

Icon is fixed.

Should we just remove "Auto adjust Window Size"?

#5 Updated by pauldacheez almost 8 years ago

AaWS is useful when it works - keep it. I don't use RtMW anymore, so that can be removed if you're too lazy to actually fix the issue.

#6 Updated by rachelbryk almost 8 years ago

lol render to main window is not going anywhere.

#7 Updated by pauldacheez almost 8 years ago

Keep both and fix/ignore the bug, then.

The problem looks decently straightforward to me, you just have to figure out how to make the thing find how many pixels to add to the y variable (and x when including the log window). Knowing wxWidgets, though, I understand if nobody bothers fixing it. >_>

#8 Updated by JMC4789 about 3 years ago

  • Status changed from Questionable to Accepted

...Ummm this sounds valid to me? Let's not let this happen in Qt?

#9 Updated by ZephyrSurfer 3 months ago

"Auto adjust Window Size" does not work correctly with "Render to Main Window" in QT, it resizes the rendered game but not the rest of the interface.

This original reported issue here was fixed in WX though back in 4.0-2507 or https://dolp.in/pr761

Also available in: Atom PDF