Emulator

Another thing probably worth mentioning is that I can only build a working binary using static wxwidgets - the dynamic one crashes on loading dols.

Issue 5360 has been merged into this issue.

The diff is http://code.google.com/r/davem-dolphin-emu/source/diff?spec=svnc585f2a13bc4554bd9b6bdac3edd34d92629262f&r=c585f2a13bc4554bd9b6bdac3edd34d92629262f&format=side&path=/CMakeLists.txt

clang path change:
ok, whatever.

environment path change:
well that's there for a reason...see the comment

min version changes:
fine i guess, i'll have to check to see if it still works on my vm

wxw-gl addition:
shouldn't be required.

Yes, I saw the comment on the environment path change, it still shouldn't be there. If you're building OSX binaries for distribution then you shouldn't have fink/macports/homebrew anywhere near your machine.

I had to build clang from source in order to build dolphin so clang/clang++ are in /usr/local/bin

I have several versions of wxWidgets on my machine for various purposes and the one for Dolphin is in /opt/wxW-2.9-dolphin. I need /opt/wxW-2.8 for building CodeLite etc

having the path changes in CMakeLists.txt prevents using clang and any test version of wxWidgets I want to use. In fact explicitly reducing paths in a build system without warning violates the Principle of Least Surprise - it took me a good 10 minutes to figure out why the heck cmake wasn't picking up my freshly built from svn wxWidgets. Surely other developers have similar problems?

The build here failed to link without wxw-gl addition ...

Issue 5396 has been merged into this issue.

Issue 5263 has been merged into this issue.

OK, that is good enough reasoning.
did you look at http://dolphin-emu.googlecode.com/git/Externals/wxWidgets3/build_wx.sh ? using that configuration should solve the wxw-gl inconsistency(?)

ok, i finally tested on my vm - seems good. will commit after the wxw-gl thing is figured out...

Yes, I used the options from build_wx.sh to build wx locally although I added -with-macosx-sdk=/Developer/SDKs/MacOSX10.6.sdk --with-macosx-version-min=10.6 --enable-universal-binary=i386,x86_64 to make sure it supports 10.6 & 32/64bit.

I get a link error as follows without the addition of wxw-gl

Undefined symbols for architecture x86_64:
"__ZNK14wxGLCanvasBase10SetCurrentERK11wxGLContext", referenced from:
__Z18OpenGL_MakeCurrentv in libvideoogl.a(GLUtil.cpp.o)
"_ZN11wxGLContextC1EP10wxGLCanvasPKS", referenced from:
__Z13OpenGL_CreateRPv in libvideoogl.a(GLUtil.cpp.o)
"__ZN10wxGLCanvasC1EP8wxWindowiPKiRK7wxPointRK6wxSizelRK8wxStringRK9wxPalette", referenced from:
__Z13OpenGL_CreateRPv in libvideoogl.a(GLUtil.cpp.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [Binaries/Dolphin.app/Contents/MacOS/Dolphin] Error 1
make[1]: *** [Source/Core/DolphinWX/CMakeFiles/Dolphin.dir/all] Error 2
make: *** [all] Error 2

Issue 5548 has been merged into this issue.

Issue 5562 has been merged into this issue.

This revision still not working on 10.6.8

@ godisgovernment: for some reason we're enabling the wxgl code in GLUtil.cpp on osx. No idea why we don't just use our platform specific code as well there. So linking against the wx gl lib indeed is fine, but the change should be restricted to the OS X platform