Project

General

Profile

Actions

Emulator Issues #5394

closed

Zelda the Wind Waker graphical issues in Dragon Roost with recent master-builds

Added by Staudi.Kaos over 12 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

  1. Game Name and ID (as it appears in right click > properties: "GZ2P01",
    "RSBE01", etc):

Name: "THE LEGEND OF ZELDA The Wind Waker for USA"
ID: GZLE01

2) What is the expected output? What do you see instead?

Expected: Normal heat effect on walls in Dragon Roost dungeon
Actual output: Pulsating orange areas on the walls

3) Did the game ever work correctly (i.e. not have this problem) on an
earlier version of dolphin? Please specify the exact revision when the
problem began.

It worked perfectly on 3.0 stable. I don't know about the revisions after that, only thing I'm sure of is that with a 64bit build of revision "g8878ae5" it showed this strange behaviour. I will test some more when I get the time.

4) What steps will reproduce the problem?

  1. Use a recent master build
  2. Enter Dragon Roost Dungeon
  3. Enter any room with lava in it

5) What version of dolphin are you using (32bit/64bit along with the
version as it appears in the title bar, etc)? Do not say 'latest version'
this changes multiple times a day.
On what operating system, drivers, and hardware?

As stated above a 64 bit build from revision g8878ae5 or 3.0-600. To be specific it's a ICC Build by Lectrode.

OS: Windows 7 Home Premium 64bit
GPU: Nvidia Geforce GT 630M (it's a laptop) with the latest driver from the manufacturer
CPU: Intel i3-2350m @2.30GHz
RAM: 4GB

6) Please provide any additional information below.

Dolphin settings are default, except for 2xIR, Fullscreen+hide mouse pointer. Another guy in the forums has the same problems, also Nvidia card, but no laptop.

Dragon Roost seems to be the only place with graphical issues, at least I didn't encounter anything else yet.

7) Attachments. IMPORTANT! We have a limited storage quota on
GoogleCode, so please use a 3rd party host for screenshots or any other
files (http://min.us/ for example).

I only made one screenshot, because I was playing through it rather swiftly, I will ad more when I get the time:

http://i.imgur.com/IbXsV.png


Related issues 1 (0 open1 closed)

Blocks Emulator - Emulator Issues #5504: Dolphin 3.5 bug trackerFixed

Actions
Actions #2

Updated by Staudi.Kaos over 12 years ago

@skidau: Yeah, I thought about that too, will try it later, now I just have to get outside, the sun is shining^^

Actions #3

Updated by Staudi.Kaos over 12 years ago

Guess I have to delay testing a little bit more since my gamepad stopped working all of a sudden.

Actions #4

Updated by skidau over 12 years ago

  • Status changed from New to Duplicate

I'm quite certain this is issue 5368.

Actions #5

Updated by Staudi.Kaos over 12 years ago

I dunno if I should post this here or at the other issue but:

Graphic_fixes builds have the same problem, so does a build of r7a17445. Will now try to find a build that works correctly.

Actions #6

Updated by Staudi.Kaos over 12 years ago

Oh, I just realised OpenGL Renderer works fine.

Actions #7

Updated by skidau over 12 years ago

Identifying which specific revision caused this issue will help us resolve it.

Actions #8

Updated by skidau over 12 years ago

  • Status changed from Duplicate to New
Actions #9

Updated by hatarumoroboshi over 12 years ago

Could you provide a save state?

Actions #10

Updated by Staudi.Kaos over 12 years ago

@hatarumo: Sure, here you go: http://dl.dropbox.com/u/35446621/GZLE01.s01

Btw I've just narrowed it down to somewhere between r25d1921 (or 3.0-95) and rb127b12 (or 3.0-137)

Actions #11

Updated by NeoBrainX over 12 years ago

Since that revision range consist mainly of the new-shadercache-uids merge, I guess that's also the cause of this bug.

Try changing the "EnableShaderDebugging" variable in your gfx backend's config ini to "True". Emulation should be noticeably slower after that, but ideally will show an error message SOMEWHERE in the game (hopefully at least when the glitch shows up). Make sure to enable panic handlers.

Actions #12

Updated by NeoBrainX over 12 years ago

Btw, this needs to be done in a radef86c1ef29da8b51dc3c0a3dc3c296d62e13aa build (or a newer one).

Actions #13

Updated by Staudi.Kaos over 12 years ago

I tried and so far no error message appeared, not even in the Dragon Roost Dungeon but I only played like ten minutes since it really hurts my head playing at such a low framerate. Will try to play a little longer later today.

Actions #14

Updated by NeoBrainX over 12 years ago

Well. just go to the place where the reported glitch occurs? :/

Actions #15

Updated by Staudi.Kaos over 12 years ago

Yeah, I did, "Dragon Roost Dungeon"^^

Actions #16

Updated by NeoBrainX over 12 years ago

Could you record 2 frames which show the issue via fifo recorder?

Actions #17

Updated by Staudi.Kaos over 12 years ago

There you go:
http://dl.dropbox.com/u/35446621/ZeldaWW.dff

I recorded it with revision rec0ddb4

Actions #18

Updated by tommyhl2.SS over 12 years ago

Post a memory card file save please.

Actions #19

Updated by Staudi.Kaos over 12 years ago

Here:

http://dl.dropbox.com/u/35446621/MemoryCardA.USA.raw

Just go further inside till you come to the big room with lava.

Actions #20

Updated by hatarumoroboshi over 12 years ago

Yes, last working revision for me is r3.0-97 Revision 175ade74d74d and then r3.0-135 Revision adef86c1ef29 is broken (I think there are no other revisions between them).
Unfortunately even setting "EnableShaderDebugging" variable to true I can't get any error message.

Actions #21

Updated by tommyhl2.SS over 12 years ago

Not getting this issue at all. http://i.imgur.com/x8WCg.jpg

The heat effect is broken, but broken as it always was. Nothing new to see here for me.

Asus Laptop: K53TA
OS: Windows 7 Home Premium, 64-Bit - SP1
CPU: AMD Llano A6-3400M, Quad-Core, 2.4GHz
GPU: AMD Radeon HD6650, 1GB GDDR3
RAM: 4GB DDR3

Actions #22

Updated by NeoBrainX over 12 years ago

Yeah, that's what the fifo log suggests as well. The issue report makes it sound like this is actually about a different issue, though?

Actions #23

Updated by tommyhl2.SS over 12 years ago

This is what Staudi posted above:

Expected: Normal heat effect on walls in Dragon Roost dungeon
Actual output: Pulsating orange areas on the walls

http://i.imgur.com/IbXsV.png

The orange is what makes this a different case, afaik.

Actions #24

Updated by NeoBrainX over 12 years ago

Yeah, but that wasn't visible in the fifo log.

Actions #25

Updated by Staudi.Kaos over 12 years ago

It's about the walls, as tommy pointed out, not about the omnipresent heat effect. Normally there should be a slight orange glow to the walls, but instead there are very bright pulsating orange areas.

@tommyhl2: Did you use the OpenGl backend by any chance? Because it only occurs with dx9 and dx11.

Actions #26

Updated by tommyhl2.SS over 12 years ago

Maybe a driver issue for you, and yeah, I was using DX9.

Actions #27

Updated by Staudi.Kaos over 12 years ago

Strange, some other guy in the forums had the same issue, also a Nvidia GPU, and no notebook. I can see that you have a Radeon, so maybe it's a nvidia thing, for whatever reason.

Actions #28

Updated by Staudi.Kaos over 12 years ago

It also happens if I start it using my Intel integrated GPU.

Actions #29

Updated by Staudi.Kaos over 12 years ago

Here are two screenshots, so it's more obvious what I mean:

http://imgur.com/Qr53y

http://imgur.com/1Krmo

Actions #30

Updated by tommyhl2.SS over 12 years ago

Dolphin probably won't use your Geforce GPU until you force it to through the Nvidia CP. Maybe your PC is using the Intel chip all the time.

Actions #31

Updated by hatarumoroboshi over 12 years ago

I don't think it is a Nvidia issue, because I have an Ati Hd4850 with Catalyst 12.4 on WinXP 32-bit and have the same Dx9 plugin problem (orange walls and bridge).
OpenGL doesn't show the glitch.

Actions #32

Updated by Staudi.Kaos over 12 years ago

@tommyhl2. Trust me, there's a very noticable decrease in speed when it's not using the Nvidia GPU^^

Actions #33

Updated by tommyhl2.SS over 12 years ago

Staudi: Okay, just trying to eliminate some possible obvious reasons this could be happening. To me, seeing someone not have this issue at all, it points to something on your end being the problem.

Actions #34

Updated by Staudi.Kaos over 12 years ago

Yeah, of course I didn't rule that out, I'm downloading new drivers for my GPU while I'm writing this (finally the vendor provided new ones) to see if that was the problem. It's just strange that e.g. 3.0 stable works perfectly, while the newer revisions have the problem and that some other guy in the forums encountered the same issue.

Actions #35

Updated by Staudi.Kaos over 12 years ago

@tommyhl2: Could you post your settings, so I can try them out? Or did you try it on standard settings?

Actions #37

Updated by Staudi.Kaos over 12 years ago

Thank you, I just tried it, but I still have the orange walls. So it's not a matter of dolphin's settings. I have the newest DirectX and newest (available) drivers for my GPU. I would've suspected nvidia driver issues, but then hatarumo had the same problem with his AMD card. This is really strange, I have no idea where to look now.

Actions #38

Updated by Staudi.Kaos over 12 years ago

Ok, just tried it on my old PC (Radeon X1600, Windows XP 32bit) and it doesn't have the problem.

Actions #39

Updated by NeoBrainX over 12 years ago

Since apparently this is a regression of revision adef86c1ef29, it'd greatly help if anyone could find out which revision between 175ade74d74d and adef86c1ef29 broke this.

Until someone's willing to do this, I guess there's nothing I can do.

Actions #40

Updated by hatarumoroboshi over 12 years ago

I would do it, but unfortunately I couldn't find any downloadable revisions between Revision 175ade74d74d (3.097) and Revision adef86c1ef29 (r3.135)

Actions #41

Updated by NeoBrainX over 12 years ago

Get a copy of VS express and compile stuff yourself :D

Actions #42

Updated by Staudi.Kaos over 12 years ago

As soon as I figure out this whole git fad I will try to narrow it down to one specific commit.

Actions #43

Updated by Staudi.Kaos over 12 years ago

Okay, so I found out revision 08e06b22 is the culprit, I hope this can help to solve the problem.

Actions #44

Updated by NeoBrainX over 12 years ago

  • Status changed from New to Accepted

Sounds reasonable that it was this revision which broke things. Just to really make sure, but did you clear the shadercache folder between switching revisions? If not, just take a quick minute to verify that for revision 08e06b22 and the one before that.

Huge thanks so far anyway, that should greatly help at resolving the issue!

Actions #45

Updated by Staudi.Kaos over 12 years ago

I'm pretty sure, but just to be safe I'll check again.

Actions #46

Updated by Staudi.Kaos over 12 years ago

Yup, checked again, it's revision 08e06b22

Actions #47

Updated by NeoBrainX over 12 years ago

Awesome, thanks. Could you test if this https://dl.dropbox.com/u/10060691/0001-Fixing-stuff.patch patch fixes the issue?

Actions #48

Updated by Staudi.Kaos over 12 years ago

Sadly that doesn't fix it, everything looks the same as before.

Actions #49

Updated by Staudi.Kaos over 12 years ago

@neobrain: This patch fixes things for me, I just reverted part of responsible revision and picked the parts that seemed right (to me, and I can't code at all, so don't be suprised if it doesn't make any sense and breaks everything else^^), could you take a look at it, maybe it helps:

http://dl.dropbox.com/u/35446621/0001-Revert-Partially-revert-revision-d511b506120c.patch

Actions #50

Updated by NeoBrainX over 12 years ago

Yo, I already found out what's wrong - just need some time to figure out how to fix it properly. I'd like to not have to reintroduce that ugly code again.

Actions #51

Updated by Staudi.Kaos over 12 years ago

Ah, okay thanks for the update.

Actions #53

Updated by NeoBrainX about 12 years ago

I just took a closer look at the affected code and while it would probably be possible to cleanup things properly, I'd rather have this issue fixed without risking any regressions atm, i.e. by reverting revision 08e06b22. Could you test that by applying the patch at http://pastie.org/4455890, this issue is still fixed on master?

Actions #54

Updated by Staudi.Kaos about 12 years ago

@NeoBrainX: Sorry for the late answer but I was in Asia the last two weeks and didn't really have access to the internet. I will try it first thing tomorrow.

Actions #55

Updated by Staudi.Kaos about 12 years ago

Sorry it took so long, but I had some computer troubles and then spent one week in Italy without my laptop so I couldn't test it. All that aside the patch still fixes the issue on newest master.

Actions #56

Updated by NeoBrainX about 12 years ago

  • Status changed from Accepted to Fixed

Fixed by revision bb8b5936c040.

Thanks!

Actions #57

Updated by Staudi.Kaos about 12 years ago

Awesome, thank you.

Actions #58

Updated by Staudi.Kaos about 12 years ago

Oh yeah, as I suspected this also fixes the strange looking Octorok.

Actions

Also available in: Atom PDF