Emulator Issues #5450
closed
Fix "Failed to compile pixel shader" error when Per-Pixel Lighting is enabled.
0%
Description
Name of clone:
slmpika-dolphin
Purpose of code changes on this branch:
Fix the Per-Pixel Lighting error.
When reviewing my code changes, please focus on:
N/A
After the review, please pull into branch:
master
Updated by skidau almost 12 years ago
slmpika, does changing the line to:
for (int i = 0; i <= numTexgen; ++i)
fix the issue?
The same change might be needed for line 625 too?
for (unsigned int i = 0; i <= numTexgen; ++i)
Updated by slmpika almost 12 years ago
I'm not familiar with how the shader works, but looking at the code, uv7 is the highest index of uv# that is used. Changing the line to
for (int i = 0; i <= numTexgen; ++i)
works, but I don't think it is necessary to define uv8 and higher.
As for line 625, this line was unchanged (except for the variable name) in r146b02615c07dd52dddaa18b7e23d09bc23b549e . In my opinion, I would leave it as is since it seems to work fine.
Updated by