Project

General

Profile

Actions

Emulator Issues #5555

closed

building against shared wxGTK requires additional ldflags

Added by belegdol about 12 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Hi,

I tried to build current git against system wxWidgets and it turned out some linker flags were missing. The attached patch fixes the problem.


Related issues 1 (0 open1 closed)

Has duplicate Emulator - Emulator Issues #5543: Linux needs to link to GTK2Duplicate

Actions
Actions #1

Updated by delroth about 12 years ago

Isn't there a cmake variable like ${GTK2_LIBRARIES} instead of hardcoding the library names?

Actions #2

Updated by belegdol about 12 years ago

I haven't looked to be honest. cmake is like black magic to me. This patch should just indicate where the problem lies, not be applied as-is.

Actions #3

Updated by belegdol about 12 years ago

I just checked, ${GTK2_LIBRARIES} works too.

Actions #4

Updated by delroth about 12 years ago

  • Status changed from New to Accepted

Thanks. I'll add these flags when I'll next reboot under Linux and after checking if wx from Externals still link properly.

Actions #5

Updated by belegdol about 12 years ago

It seems to work here.

Actions #6

Updated by delroth about 12 years ago

Issue 5543 has been merged into this issue.

Actions #7

Updated by Christian.Morales.Vega about 12 years ago

This is not really related to wx.
Dolphin's code, in X11Utils.cpp, directly uses GTK functions (through the GTK_WIDGET macro). So Dolphin must link against GTK, the same than any other library.

It's related to wx only in the fact that the related code in X11Utils.cpp is inside a "#if defined(HAVE_WX) && HAVE_WX".

It works when using the internal wx because the wx CMakeLists.txt file is adding the "set(LIBS ${GTK2_LIBRARIES})" line. But that just means you got lucky and something else did your work. The code that uses it is the one responsible of adding the needed linker flags.

Actions #8

Updated by delroth about 12 years ago

  • Status changed from Accepted to Fixed

This issue was closed by revision d7d2e5b9bfce.

Actions

Also available in: Atom PDF