Project

General

Profile

Actions

Emulator Issues #5596

closed

Load Custom Textures stuttering/lags

Added by burnhellpsp about 12 years ago.

Status:
Fixed
Priority:
Low
Assignee:
Category:
GFX
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
Yes
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

It's annoying that dolphin always stuttering/lags when he is loading custom textures, those stuttering/lags freeze the screen for some seconds ( What ends up causing stuttering all the time )and depending on the amount of texture and the resolution of texture, of it's loading, it can take about 7 seconds frozen or more.

It would be amazing see this issue fixed, before the, 4.0, be released. :)

Actions #1

Updated by NeoBrainX about 12 years ago

  • Status changed from New to Accepted
  • Priority set to Low
  • Category set to gfx
  • Relates to performance set to Yes
  • Operating system N/A added

Yeah, we're doing lots of stupid stuff when loading custom textures. Some hints of what should be changed in case anyone is willing to do the work:

  • SOIL_load_image creates a temporary buffer for each image file that is being loaded (and destroys it shortly after again). I doubt there's a way to prevent that without forking SOIL, but just forking it internally and adding the necessary functionality should be possible. Cookies if you actually get that functionality upstream ;)
  • Apart from the overhead of redundant allocations, HiresTextures::GetHiresTex needs to copy the loaded image data to our own buffer (necessary because the buffer needs to be memory aligned)

... that should be about it. Of course, one could also fix the issue by using a different library for handling image decoding. D3DX comes to mind, although it neither does the job really well.

Actions #2

Updated by burnhellpsp about 12 years ago

Thank you.

Actions #4

Updated by itachijuniorpc almost 12 years ago

Thank you for the initiative @death2dr when you do a fix, please post here the name of the branch :)

Actions #5

Updated by Billiard26 almost 12 years ago

I'd ditch SOIL.

Actions #6

Updated by JMC4789 over 9 years ago

  • Status changed from Accepted to Fixed

Fixed by prefetch custom textures.

Actions

Also available in: Atom PDF