Project

General

Profile

Emulator Issues #5662

FTBFS on latest Windows SDK, PortAudio.lib links to ksguid.lib

Added by johnwchadwick over 7 years ago. Updated over 1 year ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
Yes
Regression start:
Fixed in:

Description

In the Externals build of PortAudio.lib, there is a reference to ksguid.lib, a file which is no longer a part of the Windows SDK.

This patch from Mozilla makes removing the ksguid.lib dependency look like a simple process: https://bugzilla.mozilla.org/attachment.cgi?id=608138&action=diff

Unfortunately, the source code to the Externals version of PortAudio is not directly in the repository, so I have nothing to patch.

History

#1 Updated by rafaelhdd about 7 years ago

I've fixed it locally by grabbing the latest PortAudio and recompiling it with PA_WDMKS_NO_KSGUID_LIB. Also I had to remove ksguid.lib from the project additional input (it isn't required anyway, since it has a #pragma lib that does the job anyway).

#2 Updated by Billiard26 about 7 years ago

  • Issue type set to Bug
  • Relates to maintainability set to Yes

#3 Updated by Juliashamanskaya over 5 years ago

Hello! How should i add the PA_WDMKS_NO_KSGUID_LIB?

#4 Updated by pauldacheez over 5 years ago

  • Status changed from New to Questionable

Is this issue still relevant? AFAIK, we’ve been using PortAudio for GCMic on Windows without compile issues for the last two years.

#5 Updated by fwright543 about 5 years ago

I am using MS VC++ 2013 Express and the way I fixed this problem was to open Property Pages of my project and remove ksguid.lib from additional dependencies under the linker input. I then opened pa_win_wdmks_utils.c and commented out the following lines:
#if (defined(WIN32) && (defined(_MSC_VER) && (_MSC_VER >= 1200))) /* MSC version 6 and above */
#pragma comment( lib, "ksguid.lib" )
#endif

pragma comment tells the linker to search for the comment argument and will throw an error if it can't find it.
-fred

#6 Updated by PEmu almost 3 years ago

I think this may have been fixed in PR 4694: https://github.com/dolphin-emu/dolphin/pull/4694

#7 Updated by ZephyrSurfer over 1 year ago

This is resolved. Yeah that removes the reference to ksguid.lib.

This portaudio issue is definitely resolved since we no longer even use portaudio. It has been replaced by cubeb.

https://github.com/dolphin-emu/dolphin/pull/5313

#8 Updated by JosJuice over 1 year ago

  • Status changed from Questionable to Fixed

Also available in: Atom PDF