Emulator Issues #5725
Use native full screen mode on OS X
Name of clone:
Purpose of code changes on this branch:
Switch Mac to use native full screen mode rather than taking over the current space and (really?) changing the system screen resolution. This introduces a dependency on OS X 10.7 Lion. Tested configuration options (automatically enter full screen mode; render to main window; others) and also hotkeys, and all work as expected. This also removes the now-superfluous "Fullscreen Resolution" video option (on OS X only).
When reviewing my code changes, please focus on:
- Is depending on OS X 10.7 Lion or later acceptable? The statistics I've seen leave it and later with just over 50% market share, but it is only increasing. More technical users (e.g. those likely to be using Dolphin) likely have a higher adoption rate.
- Is removing the "Fullscreen Resolution" option acceptable? This is now handled by the main resolution setting, as entering fullscreen is just equivalent to resizing the window.
- Are there any other configurations or edge cases that I don't handle?
After the review, please pull into branch:
#2 Updated by mdeletrain almost 8 years ago
I find excluding 10.6 users a bit rough ! As you said they still represent a lot of Mac users (in fact, this is the bigger part of mac users, according to this site : http://www.netmarketshare.com/operating-system-market-share.aspx?qprid=10&qpcustomb=*2).
Lot of people keep using 10.6 because of 10.7+ introducing some nasty behaviors they don't want.
Migration from 10.5 to 10.6 with an upgrade price around 50$ was done in only a few months. Migration to 10.6 to 10.7+ with an upgrade price at 20$ is still not done 16 months later... guess why ?
#5 Updated by stefan.moonen almost 8 years ago
I've played a bit with the build you supplied yesterday. Mainly SMG and NSMB, and they both run great with this patch, no perceivable speed difference.
Also, the native fullscreen is a nice touch as it provides the option to easily switch between spaces. Though I think the main question that remains is if it's desirable that you can only play in the native desktop resolution now. I don't think it has to be a problem because the actual rendering resolution makes all the difference, and that is a separate configuration option. Maybe make the native fullscreen functionality an option in the configuration? (On by default for Lion and ML.)