Project

General

Profile

Emulator Issues #5746

Pitch on some sounds is incorrect [Zelda UCode]

Added by florian98.rg over 8 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
Category:
DSPHLE
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

1) Game Name and ID (as it appears in right click > properties: "GZ2P01",
"RSBE01", etc):

All games that use Rectangle Waves, e.g. Super Mario Sunshine and Wind Waker etc.

2) What is the expected output? What do you see instead?
The Rectangle Wave should play at the right level.
Instead it's too high pitched and sounds wrong anyways.

3) Did the game ever work correctly (i.e. not have this problem) on an
earlier version of dolphin? Please specify the exact revision when the
problem began.

This has happened all the time IIRC

4) What steps will reproduce the problem?

In Wind Waker:
1. Open Wind Waker
2. Hear Magic Meter filling (You must first get it though)
3. It's too high pitched

As in Super Mario Sunshine:
Press Start while jumping, try to switch camera modes while jumping etc.
Also too high pitched.

6) Please provide any additional information below.
In "UCode_Zelda_Synth", at Line 30, removing the * 16 (or lowering it) makes it much lower pitched. But it still isn't right.

Also, the Mario Sunshine "Denied" Sound sounds perfect with the *16 removed.

I think Rectangle Wave for the title is wrong, but i don't know what it actually is called, the code calls it Rectangle Wave :P


Related issues

Blocks Emulator - Emulator Issues #7127: Zelda ucode HLE Master IssueFixed

History

#1 Updated by Billiard26 over 8 years ago

  • Status changed from New to Questionable
  • Category set to dsp
  • Issue type set to Bug

#2 Updated by Billiard26 over 8 years ago

Is this still relevant?

#3 Updated by pauldacheez over 8 years ago

Under HLE, it certainly is.

#4 Updated by delroth about 8 years ago

  • Category changed from dsp to dsphle

#5 Updated by daxtsu about 8 years ago

Probably known, but still relevant even with the new AX HLE. Just re-confirming it.

#6 Updated by JMC4789 about 7 years ago

  • Status changed from Questionable to Accepted

Going to just give this a generic title and accept it.

#10 Updated by delroth over 6 years ago

new-zelda-hle fixes that.

#11 Updated by Autoran1 almost 6 years ago

  • Status changed from Accepted to Fixed

Now just fixed

Also available in: Atom PDF