Project

General

Profile

Actions

Emulator Issues #5799

closed

Multi-disc games are displayed as the same item twice in the game list

Added by delroth over 12 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
UI
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Current
Regression:
No
Relates to usability:
Yes
Relates to performance:
No
Easy:
Yes
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Noticed on two games: Tales of Symphonia (GC) and Baten Kaitos (GC).

Instead of clearly showing which item is disc 1 and which is disc 2, the game list displays two identical items. Sort order seems random: disc 1 might be below or above disc 2. The only way to see which one is the disc you want to use is to right-click on the game and go to the Game Info property tab.

No idea how that could be fixed nicely (I suck at UI).

Actions #1

Updated by delroth over 12 years ago

Screenshot showing the issue: http://i.imgur.com/8aj7F.png

If we could at least make the sort order consistent, one of the two problems would be fixed.

Idea to display which is disc 1 and which is disc 2: iterate on the game list, find duplicates which have different disc numbers (if any), and overlay a small 1/2 digit in the lower-left corner of the GC/Wii icon. Adding "(disc 1)" or "(disc 2)" at the end of the displayed title might be an easier (but less visual) way to do it too.

Actions #2

Updated by delroth over 12 years ago

lower-right* (lower-left would look weird)

Actions #3

Updated by kostamarino over 12 years ago

The Notes column has that info for Tales of Symphonia, if you stretch dolphin window horizontally and disable the log it will show up since that column gets hidden if there is little space, for other titles like some resident evil games the disk number is on the title.

Actions #4

Updated by tommyhl2.SS over 12 years ago

For what it's worth, Resident Evil 1, 0 and 4 all have specific game banners with "disc1" or disc2" displayed for their game banners.

Actions #5

Updated by parlane over 12 years ago

  • Priority set to Low
  • Relates to usability set to Yes
  • Milestone set to Future
  • Operating system N/A added
Actions #6

Updated by parlane over 12 years ago

  • Milestone changed from Future to 4.1
Actions #7

Updated by parlane over 12 years ago

Can we detect which disc is 2 ? Is it in ticket info or something ?

Actions #8

Updated by lpfaint99 over 12 years ago

yes, at offset 6 disc 1 is 0x00, disk 2 is 0x01
http://hitmen.c02.at/files/yagcd/yagcd/chap13.html#sec13.1

Actions #9

Updated by gamedevistator over 12 years ago

I agree. For games like resident evil 4 which had 2 discs. You need it to show both of them in the list

Actions #10

Updated by rachelbryk over 12 years ago

Revision 2cc1a97a66c2 sorts them based on disc number, but there's still no obvious way to tell which is which, if the notes column is hidden.

Actions #11

Updated by rachelbryk over 12 years ago

So what do we want to do with this? http://pastie.org/6028205 adds (Disc 2) to the title of the second discs. Should i just commit that, or do we want something else?

Actions #12

Updated by JMC4789 almost 11 years ago

  • Milestone changed from 4.1 to Next

4.1 never happened... so...

Actions #13

Updated by MayImilae over 10 years ago

  • Milestone changed from Next to Current
  • Easy set to Yes

Can that pastie be turned into a PR? That would be great for 5.0, and it looks super easy.

Actions #15

Updated by JMC4789 over 10 years ago

  • Status changed from New to Fix pending
Actions #16

Updated by Fog almost 10 years ago

Merged as of 4.0-6419.

Actions #17

Updated by JosJuice almost 10 years ago

  • Status changed from Fix pending to Fixed
Actions

Also available in: Atom PDF