Project

General

Profile

Actions

Emulator Issues #6051

closed

Lighting not rendered appropriately / Lights should have a glow around them

Added by arcangel3ac over 11 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
GFX
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Have you searched the issue tracker for a similar issue?
Yes

Game Name?
Resident Evil Archives: Resident Evil Zero

Game ID?
RE408

What went wrong?
Lighting not rendered

What did you expect to happen?
Lights should have a glow around them

What steps will reproduce the problem?
everytime start game

What version of Dolphin were you using?
Dolphin 3.5-480

64 or 32 bit Dolphin?
64

What version of Dolphin used to work?

What Operating System were you using and what are your hardware
specifications?
Windows 7 SP1.
Intel Core i5(2500k) 3.30 GHZ / 8,00 GB RAM
NVIDIA GeForce GTX 550 Ti

64 or 32 bit Operating system?
64

Any other relevant information or links to logs:
http://forums.dolphin-emu.org/Thread-wii-resident-evil-archives-resident-evil-zero

Actions #1

Updated by tommyhl2.SS over 11 years ago

  • Status changed from New to Accepted
  • Category set to gfx

I've reproduced this with all backends.

http://i.imgur.com/7AC24At.jpg

Dolphin 3.5-1049 - x64

Asus Laptop: K53TA
OS: Windows 7 Home Premium, 64-Bit - SP1
CPU: AMD Llano A6-3400M, Quad-Core, 2.4GHz (Overclocked)
GPU: AMD Radeon HD6650M, 1GB GDDR3 (Catalyst 13.1)
RAM: Samsung 4GB DDR3-1333

Actions #2

Updated by skidau over 11 years ago

This might be the reason:

// TODO: in RE0 this value is often off by one, which causes lighting to disappear

http://code.google.com/p/dolphin-emu/source/browse/Source/Plugins/Plugin_VideoOGL/Src/Render.cpp#747

Actions #3

Updated by markdperry68 over 11 years ago

Don't know if this helps but I just noticed something about this bug.

When you enter the train car in tommyhl2's example from a new game, set the frame limit to 10, as low as it will go. Then slowly move into the camera angle in tommy's screengrab. If you look carefully, you will notice the glow is there for a split second then fades away to the image in the screengrab. The glow is easier to see if you set frame limit to 10.

Actions #4

Updated by markdperry68 over 11 years ago

Forgot to mention, this is on dolphin 3.5-1158, win 7 x64, dx11 backend.

Actions #5

Updated by Billiard26 over 11 years ago

  • Issue type set to Bug
Actions #6

Updated by burnhellpsp over 11 years ago

Is there any branch with that value modded?

Actions #7

Updated by pauldacheez almost 11 years ago

Try this branch, it magically fixes everything:
https://dolphin-emu.org/download/list/tev_fixes_new/1/

Actions #8

Updated by itachijuniorpc almost 11 years ago

i also tried the last build of that branch (tev_fixes_new-4.0-624-x64) and it's not working on Resident Evil neither on Resident Evil 0.

Actions #9

Updated by pauldacheez almost 11 years ago

...Well, I guess this is one of the few issues tev_fixes_new isn't gonna fix. v_v

Actions #10

Updated by degasus almost 11 years ago

Wii only supports per vertex lighting. tev are only used for all per pixel operations, so tev won't fix any lighting issues.

Actions #11

Updated by itachijuniorpc almost 11 years ago

... And I was testing the Wii version of RE1 & RE0.

Actions #12

Updated by itachijuniorpc over 10 years ago

Any news on this?

Looking for see this issue fixed. :)

Just to test, I tried dolphin 4.0-1997 and this issue is still there.

Actions #14

Updated by itachijuniorpc over 10 years ago

Thanks for the update!

Awesome, it works when Skip EFB access from CPU is OFF, but only on Resident Evil 0.

Light Glows still doesn't works in Resident Evil Remake

Actions #15

Updated by itachijuniorpc over 10 years ago

Unfortunate it doesn't fix RE0 too :( many lights still turns off. see this post -> https://forums.dolphin-emu.org/Thread-wii-resident-evil-archives-resident-evil-zero?pid=329929#pid329929

Actions #16

Updated by itachijuniorpc over 10 years ago

I just found that this issue is completely fixed by the Unofficial DX9

https://forums.dolphin-emu.org/Thread-unofficial-testing-needed-dx9-final

Just uncheck the Skip EFB access from CPU, and it works in All Ligh Glows in RE0 now :D

Why the lastest master builds doesn't has this "fix" ?

Actions #17

Updated by JMC4789 over 10 years ago

if you could pinpoint when the first was found, maybe it could be implemented. THat fork has a lot of changes. Having the exact build it starts working on would help a ton in implementing it in master.

Actions #18

Updated by itachijuniorpc over 10 years ago

The 1st build with the fix for RE0 is Dolphin-DX9-Final.4.0-156-dirty.x64 (february 26, 2014) this is the second build more old that he uploaded.

The Dolphin-DX9-Final-Stable-x86 (October 31, 2013) doesn't has the fix for RE0, this is the first build more old build that he has uploaded.

I also tested the dolphin 4.0 and dolphin-master-4.0-146-x64, both doesn't has the fix for RE0.

So, he doesn't compiled anything between October 31, 2013 until february 26, 2014 ?

Actions #19

Updated by Line.Exon over 10 years ago

About that lighting issue...
Try Dolphin-DX9-Final.4.0-156-dirty.x64 with "force texture filtering" = OFF
Somehow turning this off brings back lense effects lighting...

Actions #20

Updated by itachijuniorpc over 10 years ago

Yes...

Those light glows are very sensitive, in order to make it work you need to uncheck the Skip EFB access from CPU, IR must be multiple of 640x528, like 1x, 1.5x, 2x, 2.5x, 3x, 4x... Auto (Window Size) will broke the light glow, also force texture filtering must be unchecked or it will broke the light glow too.

Actions #21

Updated by JMC4789 over 9 years ago

  • Status changed from Accepted to Fix pending

Good news guys. Because I wanted Pokemon Snap fixed, Armada accidentally fixed this.

Fixed in PR 2369 -> https://github.com/dolphin-emu/dolphin/pull/2369

Actions #22

Updated by shadoxfix over 9 years ago

  • Status changed from Fix pending to Fixed
Actions

Also available in: Atom PDF