Project

General

Profile

Actions

Emulator Issues #611

closed

Fog implementation in r2309 completely broke Resident Evil

Added by rodiabloalmeida about 15 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

I just openned this issue report because I can't post a single comment on
the revision logs.

What steps will reproduce the problem?

  1. Just run the game on r2309 and above
  2. Enable r945 projection hack

What is the expected output? What do you see instead?
Expected: Normal graphics and background
Instead: The caracters are visible, but no background

What version of the product are you using? On what operating system?
r2309 and above. All shows the same bug. I'm on Windows XP x86

Please provide any additional information below.

No need for additional info. The fog just broke the thing.


Related issues 1 (0 open1 closed)

Has duplicate Emulator - Emulator Issues #612: Grayed Characters and Shadows in Resident Evil ZeroDuplicate

Actions
Actions #1

Updated by flatflat about 15 years ago

which game? there is more than 1 re game for wii/gc.

Actions #2

Updated by rodiabloalmeida about 15 years ago

Oh, now I can comment. Nice. Well, its the Resident Evil Remake I'm talking about.

Actions #3

Updated by rodiabloalmeida about 15 years ago

I think a checkbox for enabling/disabling the fog would do the thing. Unfortunelly,
I'm not a programmer. But I personally think its not a very difficult thing to do.
Correct me if I'm wrong.

Actions #4

Updated by nosound.97 about 15 years ago

You expect from Dolphin Team make a special option for it? It's single game that has
an error like this. If there were more games we would talk...

Actions #5

Updated by rodiabloalmeida about 15 years ago

I don't expect for it. Just hope for a solution. I pretty much understand the
emulation scene and I know for sure I can not demand a solution, but only ask kindly
for one and hope someone to implement. And IMHO, Resident Evil is as important and
relevant as Zelda and Metroid, wich have their hacks already. I'm pretty sure a lot
of people wants to play it. And a checkbox its not that special. You just have to
move the code to a closed class or something (I don't know the correct names) and
make a option to activate. But I'm not skilled enough to do it. That's becouse I
openned this issue report. ;)

Actions #6

Updated by rodiabloalmeida about 15 years ago

Well, it seems Resident Evil Zero is bad affected by the fog code too. See this:

http://code.google.com/p/dolphin-emu/issues/detail?id=612.

http://www.dolphin-emu.com/forum/viewthread.php?thread_id=1222

Maybe other games are affected too, but I can't confirm that.

Actions #7

Updated by marcus about 15 years ago

yes, putting it in a checkbox would be quite simple. even though I'm not an expert
at C++, I could probably do it just by copy and paste. I'm sure one of the devs can
do it much more easily and cleanly.

Actions #8

Updated by XTra.KrazzY about 15 years ago

Issue 612 has been merged into this issue.

Actions #9

Updated by donkopunchstania about 15 years ago

There is no need for a check box, fog just needs to be fixed. You can use a previous
ogl version or the soap branch in the mean time. Ill take a look in a few days, but
Ill be pissed if xk is correct and I messed up the back exp fog functions :)

That issue with seeing the character through the wall, are you sure the fog change
did that? Can you test rev 2308 to be sure it worked then?

Actions #10

Updated by XTra.KrazzY about 15 years ago

  • Status changed from New to Accepted

"Ill be pissed if xk is correct and I messed up the back exp fog functions :)"
:P

In any case it looks like a projection bug to me rather than fog bug. Seeing through
walls is a common result of incorrect Z-buffer handling and incorrect culling.

Actions #11

Updated by rodiabloalmeida about 15 years ago

About the RE Zero, it's just my guess while I was looking at the code but most at the
behaviour that RE games renders. I don't have the game, but looking at the issue
reported as issue 612 and the pictures, I can almost affirm that the grayed
characters resides on the fog code. But about the "seeing the character through the
wall" I cant say 'cos It seems RE Zero renders the graphics on a similar way that RE
Remake does, but its different at some point. Maybe if someone that have the game
could test it on r2308 and r2309 so a more reliable answer can be said.

For the RE remake, I have no doubts about it. I tested all revisions from r2309 and
below down to r2299, including the mentioned r2308.

Actions #12

Updated by rodiabloalmeida about 15 years ago

Sorry for the double post but... I forgot to say thanks for the amazing efforts that
you all do on your freetime coding dolphin. I really apreciate that, :)

Actions #13

Updated by donkopunchstania about 15 years ago

The problem with the scene disappearing is fixed in r2330. I need some more info on
the "seeing the character through the wall" problem, but I agree with XK that is most
likely not a fog issue.

Actions #14

Updated by XTra.KrazzY about 15 years ago

143 - SetPSConstant4f(C_ZBIAS+1, lastDepthRange[0] / 16777215.0f, lastDepthRange[1] /
16777215.0f, 0, (float)( (((int)lastZBias<<8)>>8))/16777216.0f);
146 + SetPSConstant4f(C_ZBIAS+1, lastDepthRange[0] / 16777216.0f, lastDepthRange[1] /
16777216.0f, 0, (float)( (((int)lastZBias<<8)>>8))/16777216.0f);

I have the feeling it has something to do with the change here.

Actions #15

Updated by federelli about 15 years ago

forgot to chance that last 6 into 5?

Actions #16

Updated by XTra.KrazzY about 15 years ago

maybe the old version (the one with the -) makes everything work. It's the one from
before r2309

Actions #17

Updated by donkopunchstania about 15 years ago

5, 6, I don't know what the last digit should be. I thought I saw the depth range at
16777216 so I changed it but change it back if that matters. It makes more sense for
it to be a 5. maybe the z bias should be divided by 16777215 also.

Actions #18

Updated by rodiabloalmeida about 15 years ago

donkopunchstania, I managed to test Resident Evil Zero (I don't have the game but my
friend have, so I got his game just for the test). Apparently the "seeing the
character through the wall" issue only appears when "Projection before r945 hack" is
enabled. The game works fine without the need to enable the projection hacks (unlike
the Remake), at least in r2371 (the revision I used in the tests). So you can close
this issue. It's solved. And thanks very much for the efforts. :)

Actions #19

Updated by XTra.KrazzY about 15 years ago

  • Status changed from Accepted to Fixed

Good.

Actions

Also available in: Atom PDF