Project

General

Profile

Actions

Emulator Issues #6135

closed

Super Mario Sunshine Grass Broken by Vertex Loader Cleanup

Added by JMC4789 over 11 years ago.

Status:
Fixed
Priority:
High
Assignee:
-
Category:
GFX
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Super Mario Sunshine - GMSE01

At the merge of the Vertex Loader Cleanup, the grass in a special stage (and possibly other places) of Mario Sunshine got quite messed up. Here's a comparison between the last known working build and the first broken build. Note, Software Renderer is unaffected, but all three accelerated backends are.

http://i.imgur.com/VJJeYds.png

r1214bf1359d3715931ccfdcb13f7e8295d0ef656 is the last working build and r8d5299c20b69f524b20a8d9451aaf754b36690cc is the first broken build.

This area is in a hidden bonus stage that requires the power nozzel for Fludd. You have to swim past the cannon on the left side of the map and jump onto some trees. From there, you should see the cannon hidden on the cliff next to the strangely grown trees. Go through the pipe, and you'll get to the level.

Alternatively, use this convenient 2 frame fifolog! - http://www.mediafire.com/download.php?zf29e1urm2lu9sa


Related issues 3 (0 open3 closed)

Related to Emulator - Emulator Issues #10312: VertexManagerBase.cpp:95 E[Video]: Too little remaining index values. Use 32-bit or reset them on flush. (non-fatal)Fixed

Actions
Related to Emulator - Emulator Issues #13136: Vertex Explosion in Pocoyo RacingFixed

Actions
Related to Emulator - Emulator Issues #13453: Trauma Team: Skeleton bug (Demons & Death mission)Fixed

Actions
Actions #1

Updated by MayImilae over 11 years ago

For those not programmers (and to skip loading the screenshot every time), it worked in 3.5-564 and was broken in 3.5-594.

Actions #2

Updated by shellashock over 11 years ago

is the grass like a corn maze?if that is the case, then the grass seems to be becoming transparent, showing the maze boundaries. If not, then that vertex loader cleanup is screwing up pretty badly here. Does this only happen in areas with tall grass? Because you might want to check the pipe on top of the shine gate where there is a village that was covered completely in fiery paint in the beginning levels. I believe this level had lots of really high grass in it around the village, so it might be worth checking outto see if it has these same vertex loader issues.

Actions #3

Updated by shellashock over 11 years ago

sorry is the grass like a corn maze in the level you described?

Actions #4

Updated by NeoBrainX over 11 years ago

  • Status changed from New to Accepted
  • Category set to gfx
  • Priority set to High
  • Regression set to Yes
  • Operating system N/A added

Seems like r21bd5be753efb016ab5e3a75bf5e6f8e71a3576a caused this issue.

Actions #5

Updated by NeoBrainX over 11 years ago

Also, note that since r677c6229ad4f0313a2346eb5ed4ae777ce02882d I'm getting spammed with errors like this: "dolphin-emu/Source/Core/VideoCommon/Src/VertexLoader.cpp:571 E[Video]: VertexManager: Buffer not large enough for all vertices! Increase MAXVBUFFERSIZE or we need primitive breaking afterall."

Actions #6

Updated by NeoBrainX over 11 years ago

I just verified that r8d5299c20b69f524b20a8d9451aaf754b36690cc~1 (i.e. master before the branch merge) with r21bd5be753efb016ab5e3a75bf5e6f8e71a3576a cherry-picked breaks things.

Good job proving once again that each piece of Dolphin code written before 2.0 release is broken crap.

Actions #7

Updated by NeoBrainX over 11 years ago

Note the "~1" suffix in the commit above, GoogleCode doesn't seem to be able to handle it... it's r1214bf1359d3715931ccfdcb13f7e8295d0ef656, anyway.

Actions #8

Updated by degasus over 11 years ago

  • Status changed from Accepted to Fixed

fixed in revision 470c9ff08a79514f70666b0077ef5d2bedab8b3c

Actions #9

Updated by pokechu22 almost 2 years ago

  • Related to Emulator Issues #10312: VertexManagerBase.cpp:95 E[Video]: Too little remaining index values. Use 32-bit or reset them on flush. (non-fatal) added
Actions #10

Updated by pokechu22 almost 2 years ago

Actions #11

Updated by pokechu22 11 months ago

Actions

Also available in: Atom PDF