Emulator Issues #628
closed
[Soap] r2362 does not build on windows
0%
Description
Uh, guess you did a great job rewriting FileUtil for cross platform stuff
etc, but theres a few things that prevent it from compiling on Win32:
1) Log.h redefines ERROR_LOG (at least) even if DEBUG and DEBUGFAST are not
defined, this yields a lot of linker errors.
2) Dolphin.vcproj does not include WxUtils.h/cpp.
3) Win32 does not have an equivalent of strndup.
4) SanitizePath uses copy.size(), while copy is a plain char* ;)
5) Some files include stdafx.h, but they arent added to the project/do not
exist.
Updated by BhaaL about 15 years ago
Steps in order to make it build:
1) DolphinWX.vcproj needs Src/WxUtils.h and Src/WxUtils.cpp included.
2) Core.vcproj needs Src/LogManager.h, Src/LogManager.cpp and Src/Corerecording.cpp
removed.
3) Added #if defined(DEBUG) || defined(DEBUGFAST) around the LOGLEVEL checks in
Common/Src/Log.h to prevent the redefines in non-Debug builds.
4) Common/Src/FileUtil.cpp: fix line 137 with strlen() rather than copy.size(), add a
Win32-implementation for strndup (koders.com has one for instance).
5) Common/Src/CPUDetect.cpp complains about a bool* to PBOOL conversion on line 96
6) HLE, Src/PCHW/DSoundStream.h cant find stdafx in the current folder.
7) Common/Src/CommonFuncs.h has a forward declaration for GetLastErrorMsg, but it is
not declared anywhere.
Updated by nakeee about 15 years ago
- Status changed from New to Accepted
Thanks for the really high quality feedback:)
Updated by Anonymous
Updated by BhaaL about 15 years ago
No problem, always glad to help.
And no, r2376 isnt completely clean yet. CPUDetect still complains about the bool* to
PBOOL conversion on the IsWOW64Process call.
Updated by nakeee about 15 years ago
- Status changed from Accepted to Invalid
soap is going to be merged to trunk
no point in lingering:)