Actions
Emulator Issues #6370
closed
Locale thread-safety
Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:
0%
Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
Description
Name of clone:
julesblok-dolphin-emu
Purpose of code changes on this branch:
Fix a rare race condition because setlocale changes the locale globally. Attached is an example of a failed shader generation where on line 48 another thread came in and switched the locale.
When reviewing my code changes, please focus on:
I used the POSIX newlocale, uselocale, freelocale. But to make this cross-compatible I had to provide a windows implementation in CommonFuncs.h.
After the review, please pull into branch:
master
Updated by skidau almost 11 years ago
The code looks fine. You've now got commit access to merge this in yourself.
Updated by Armada almost 11 years ago
I made few changes, because I didn't properly follow the POSIX specifications on newlocale().
Updated by Armada almost 11 years ago
- Status changed from New to Fixed
Pull Request has been merged.
Actions