Emulator

I can confirm this. Reverting this merge from current master fixes this issue.

I never had any issues with i tested it...

Reproduce¶

Place the Dolphin folder in Dropbox (and paste the link to the Dropbox folder) because

that can make it easier to reproduce the problem because it allow

• running the same code and settings
• reading User/Logs/dolphin.log

Log¶

Run Dolphin.exe from this folder

because

• it has the log function WiimoteEmu::Spy enabled which is beneficial to identify the problem

State¶

Run the states from the folder linked in the topic "Log"

with command

./dolphin -e SMNE01.s01
./dolphin -e SMNE01.s02
…

./dolphin -e SUKE01.s01
./dolphin -e SUKE01.s02
…

or with the GUI in "File > Open"

and

• communicate if the Wiimote input works directly after and a longer while after loading the state
• share the Dolphin folder from this test because that allow reading User/Logs/dolphin.log from this test

Real compared to hybrid¶

Communicate if the real Wiimote operation in hybrid mode

that's enabled with the User/Config/WiimoteNew.ini settings

[Wiimote1]
; real
Source = 2
; hybrid
Source = 3

is different because

• if the hybrid mode is functional the real mode can easily be made functional

More information¶

There's more information about this patch in the topic "Real Wiimote" at https://github.com/mirror/dolphin-emu/pull/1#issuecomment-18724064 that can be useful to analyse the problem

Wiimotes are complete broken. Since recent changes, I have to use "hybrid" to even have functionality in game (bypass wiimote screens) BUT even then I have no IR. The wiimote screen takes forever to appear and has a lot of trouble initially syncing up with wiimote. Also, I can only connect one wiimote. I've tried four wiimotes, new and old, and all have the same problem. This is a major regression - please revert as soon as possible.

Everything is perfect in 1487 and was broken by 1545.

Read data reply¶

The problem that the emulated program detect input (f.e. the B button in the NSMB level start screen) but still report that the Wiimote is disconnected can be a result of missing or unsynchronised

• read data acknowledgement 0x21
• output report acknowledgement 0x22

because

• the emulated program expect these reports in addition to data reports from a functional connection

The read data acknowledgement was unintentionally disabled for the real Wiimote in the commit with the title "Saving real Wiimote state"

There's a commit with the title "Adding read data reply to the real Wiimote" that add a read data acknowledgement 0x21 to the real Wiimote

There's a link to a branch that contain this commit in the topic "More information"

There's a link to a folder that contain a build of this branch (in the file Dolphin.exe) in the topic "Log"

Removing wait for real Wiimote connection when the Wiimote configuration dialog is opened¶

The wiimote screen takes forever to appear …

This is solved in the commit "Removing wait for real Wiimote connection when the Wiimote configuration dialog is opened" by

not waiting for Wiimote::Initialize when

• opening the Wiimote configuration dialog
• booting from the emulated program entry point rather than a state

because

• it doesn't have meaning in these scenarios but has meaning when booting from a state

Reason for wait¶

The commit "Saving real Wiimote state" add a wait function to Wiimote::Initialize because

• the state shouldn't be loaded before the Wiimote connection is established because the Wiimote connection is used to apply the real Wiimote state

Connecting more than one Wiimote¶

Also, I can only connect one wiimote. I've tried four wiimotes, new and old, and all have the same problem

Do you mean that the log write the message

43:20:994 Src\HW\WiimoteReal\WiimoteReal.cpp:569 N[Wiimote] WiimoteReal::Initialize
43:20:994 Src\HW\WiimoteReal\WiimoteReal.cpp:450 N[Wiimote] Wiimote scanning has started.
43:23:880 Src\HW\WiimoteReal\WiimoteReal.cpp:642 N[Wiimote] Connected to Wiimote 1.

when you expect it to also write

43:23:880 Src\HW\WiimoteReal\WiimoteReal.cpp:642 N[Wiimote] Connected to Wiimote 2.
…

because there's more than one Wiimote in the Bluetooth range?

Should be fixed in revision e36757bec1bc. Let us know if not.

Hey.
I just tested this out , I can get past the screen and it gets my wiimote once again (thank you very much)

but!!!!
there's now a new issue.
in the nsmb + other 2 games that require you hold the wiimote HORIZONTALLY , it doesnt work. it keeps on working like VERTICALLY held wiimote.
AKA - Left is Down, Up is Left .. etc etc like holding it

needless to say, in rev.1522 it's not like that.

I can't reproduce that...doesn't nsmbw always control as if you're holding the wiimote horizontally, even if you're not?

i guess it doesn't.. the 2 button is now the A one..

Are you using hybrid wiimote with nunchuck?

Okay, I guess it's somehow game specific ?
I went into Super paper mario , it does not occur.
it does however in NSMB + WarioLand Shake it!

You're probably using hybrid wiimote with nunchuck. That changes the controls in nsmbw, but paper mario should ignore it.

that's awkward. since i dont have a nunchuk , and in the dialog it says "real wiimote"

but anyway - my initial issue was resolved.
thank you very much for the fix. :-)

i see its not only my problem -
look at the comments here :
https://code.google.com/p/dolphin-emu/source/detail?r=970cb4329f4f26b189048ab805dae0c15c279ef4

Removing reading of the emulated Wiimote state in the real Wiimote mode¶

in the nsmb + other 2 games that require you hold the wiimote HORIZONTALLY , it doesnt work. it keeps on working like VERTICALLY held wiimote.

This is solved in the commit with the same name as the title of this topic by

• not handling WM_REQUEST_STATUS and WM_READ_DATA in the real Wiimote mode

i.o.w. by making the emulated Wiimote object write only rather than read and write

Problem description¶

The hybrid Wiimote read the emulated Wiimote object with the intention of

• synchronising the Wiimote extension with the emulated Wiimote

This doesn't have meaning for the real Wiimote mode because the emulated Wiimote isn't used

The problem was created in the commit "Saving real Wiimote state" because it doesn't solve the problem as described in this topic

Thanks for the prompt fixes. All my issues have been resolved.