Emulator

Sorry, my screenshot does not work.
Again:
http://i.imgur.com/M0UUN3M.jpg

R6750 doesn't have the banding issue either, r6752 has it. Based on the changelog, r6751 or revision d435fd8957a2 seems to be the rev since when the banding issue started when using d3d9.

I can't see the issue. Please explain better where the issue is visible. Edit the picture in paint if you can't explain it in words.

.. okay I got it now, but for convenience you should mark it better anyway. Making devs look for your bug for 3 minutes isn't a good way to get people to fix the issue.

Source/Plugins/Plugin_VideoDX9/Src/PixelShaderCache.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Source/Plugins/Plugin_VideoDX9/Src/PixelShaderCache.cpp b/Source/Plugins/Plugin_VideoDX9/Src/PixelShaderCache.cpp
index a4a788c..6c28b48 100644
--- a/Source/Plugins/Plugin_VideoDX9/Src/PixelShaderCache.cpp
+++ b/Source/Plugins/Plugin_VideoDX9/Src/PixelShaderCache.cpp
@@ -195,8 +195,8 @@ static LPDIRECT3DPIXELSHADER9 CreateCopyShader(int copyMatrixType, int depthConv
{
// Watch out for the fire fumes effect in Metroid it's really sensitive to this,
// the lighting in RE0 is also way beyond sensitive since the "good value" is hardcoded and Dolphin is almost always off.

•   WRITE(p, "float4 EncodedDepth = frac(texcol.r * (16777215.f/16777216.f) * float4(1.0f,256.0f,256.0f*256.0f,1.0f));\n"
  

•            "texcol = floor(EncodedDepth * float4(256.f,256.f,256.f,15.0f)) / float4(255.0f,255.0f,255.0f,15.0f);\n");
  

•   WRITE(p, "float4 EncodedDepth = frac((texcol.r * (16777215.0f/16777216.0f)) * float4(1.0f,255.0f,255.0f*255.0f,255.0f*255.0f*255.0f));\n"
  

•                     "texcol = float4((EncodedDepth.rgb * (16777216.0f/16777215.0f)),1.0f);\n");
  

  }
  else
  {

Reverting the lines above to what they where before revision d435fd8957a2 seems to fix the banding. Definitely revision d435fd8957a2 is the culprit.

@ kosta: What revision is this patch diff'ed against? revision d435fd8957 didn't introduce a value of 15.0f and master:HEAD doesn't have the comment at the top.

Those lines have changed again since revision d435fd8957 but the result is the same, so i just used the lines previous to revision d435fd8957 changes to see if it works ok and it does.
Master does have that comment on the top:
http://code.google.com/p/dolphin-emu/source/browse/Source/Plugins/Plugin_VideoDX9/Src/PixelShaderCache.cpp

Fixed in the Tev_Fixes_New branch.

Afraid to say it is not working in tev_fixes_new (any more).
Strangely at one point it did, but I spent an hour trying to reproduce it, and could not make it.
However the "Bleach Versus Crusade" Projection Hack fixes it!
Maybe it could be included into the gameini?

Projection hacks are being removed not added; they don't fix anything, they're stupid, hacky work-arounds. If you want to use it on your own, that's fine, but the developers will continue to try to figure out why something's going wrong.

Yes, it is clearly not a solution of any kind.
I tested at least 20 tev_new builds from around January 5th, however I was not able to find the working combination of settings+revision.
Should I put this hack into the Wiki, or is it too "dirty" to be used by others.

With the introduction of tev-new the issue is gone when setting fast depth calculation to off.
Maybe this could be included into the game ini?

I will include it on the next pr for ini files and close this issue then.

IIRC disabling fast depth did NOT fix the issue for me, so verify this report before adding stuff to the game ini, please.

I did it before answering trying both video backends and it was fixed by disabling fast depth calc. Perhaps it is video vendor/driver dependent? I am using a 560 ti and 332.21 drivers.

I treid this with a completely new default config and only fast depth on/off as well as my config with more IR,AF etc.
I use a Gtx 660 with 319.60 driver on Ubuntu. Obviously I could only test OpenGl.

I created two FIFO logs of a scene with fast depth calculation on and off.
The one with fast depth calculation on has graphics problems.
The one with fast depth calculation off looks correct.
(Screenshots included)
https://drive.google.com/file/d/0B5rMgv2g-BxuNTJQQVByTmFjXzQ/edit?usp=sharing