Project

General

Profile

Actions

Emulator Issues #6529

closed

FifoPlayer requires dual-core to be disabled to avoid overflow/crash

Added by pauldacheez over 10 years ago. Updated almost 8 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Current
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Three solutions for this:

  1. Fix it properly and make the CPU thread not overflow the FIFO GatherPipe in dual-core (or whatever it's doing). Difficult and pointless.
  2. Disable dual-core if a FIFO log's being played. Easy and probably the best choice.
  3. Swap out Dolphin's built-in FifoPlayer for Neobrain's homebrew one which may or may not still have this issue. Will likely happen at some point, which may be enough justification for everyone to ignore this.

(Normally this wouldn't be worth filing an issue about, but I've needed some issue-writing practice, so why not!)


Related issues 1 (0 open1 closed)

Has duplicate Emulator - Emulator Issues #8058: FIFO overflow when loading FIFO logDuplicate

Actions
Actions #1

Updated by JMC4789 over 10 years ago

  • Status changed from New to Accepted

I like this issue a lot.

I'm going with accepted rather than won't fix because solution 2 sounds like it's be menial to do. Maybe this needs an easy tag.

If someone wants to override me and say wontfix, so be it, but I have a feeling one of the solutions from 2 or 3 will be used anyway regardless.

Actions #2

Updated by delroth over 10 years ago

  • Milestone set to Next
  • Operating system N/A added

Nope, this definitely needs to be fixed. I'd avoid 2 since it's just a band-aid fix and this is not critical.

Actions #3

Updated by delroth over 10 years ago

  • Milestone changed from Next to Current

4.0 was released, moving Milestone-Next to Milestone-Current.

Actions #4

Updated by OPajot over 10 years ago

I guess this is the proper issue (or at least related to the problem).
I had an error popup "FIFO is overflowed by GatherPipe ! CPU thread is too fast !" in two games.
-No More Heroes (RNHE41), during the initial cutscene when raiding the mansion.
-Hitman 2 (GHMP4F), on the second level with the falling snow (ex-CR1 bug area).

We can go on by clicking the Yes button (No closes Dolphin), but there are tens of them each time.
Disabling the Panic handlers makes the screen freeze instead.

Actions #5

Updated by delroth almost 10 years ago

  • Milestone changed from Current to Next

Moving to next milestone since these issues are not critical to a new release.

If you feel strongly about this issue and want it to block the next Dolphin release, please assign yourself as owner and re-add Milestone-Current.

Actions #6

Updated by phire about 9 years ago

Issue 8058 has been merged into this issue.

Actions #7

Updated by JosJuice almost 8 years ago

  • Milestone changed from Next to Current

5.0 was released, moving Milestone-Next to Milestone-Current.

Actions #8

Updated by degasus almost 8 years ago

  • Status changed from Accepted to Fixed

Nope, this was fixed some months ago.
#3573
4.0-8828-gea3a457

Actions

Also available in: Atom PDF