Project

General

Profile

Actions

Emulator Issues #6552

closed

Vertex Streaming Hack Tooltip is inaccurate

Added by JMC4789 over 11 years ago.

Status:
Fixed
Priority:
High
Assignee:
Category:
UI
% Done:

0%

Operating system:
N/A
Issue type:
Feature request
Milestone:
Current
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
Yes
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Currently, the tooltip reads,

"Speed up vertex streaming by using unsafe OpenGL code. Enabling this option might cause heavy glitches or even crash the emulator.

If unsure, leave this unchecked."

That's about as inaccurate as it can get. Vertex Streaming Hack is something I've been using since the GLSL branch, and not once has it caused a crash on any of my three nVidia cards. This is a safe, massive performance boost for nvidia users. Not recommending it to nVidia users is pretty silly. I recommend something like this,

"Speed up vertex streaming using a loophole in nVidia's drivers. Enabling this option can cause huge performance gains on nVidia graphics cards. On any other type of card the option will cause severe graphical issues or crash.

Recommended ON if supported."

I don't know exactly how the Vertex Streaming Hack works, so, would definitely want someone who understands it to review what I'm saying. All I know is that it makes OpenGL useable and faster than D3D9 for nVidia users on a lot of games. Considering D3D9 is deprecated, shouldn't we want people to use the other back-ends?

Actions #1

Updated by MayImilae over 11 years ago

  • Status changed from New to New
  • Category set to ui

I definitely agree with this. For nvidia cards this is a free speedup and has no downsides, from what I've seen at least. It's great.

Actions #2

Updated by nigel.harris.uk over 11 years ago

Bit harsh calling the existing description inaccurate. Its accurate in a sense its a hack outside OpenGL spec.

If I recall correctly work is underway to only have this option available to known working drivers? If thats the case then it will be worth amending it to something like JMC4789's description.

Agree with the two guys above though - the hack is great if its supported!

Actions #5

Updated by delroth over 11 years ago

  • Status changed from New to Accepted
  • Issue type set to Feature request
  • Priority set to High
  • Easy set to Yes
  • Milestone set to Current
  • Operating system N/A added
Actions #6

Updated by JMC4789 over 11 years ago

Degasus rewrote it, and now I'm rewriting it again after finding spelling errors.

Speed up vertex streaming using a loophole in graphics drivers. Enabling this option may give huge performance gains on supported graphics cards. But, on hardware that does not support the hack, the emulator may have severe graphical issues or crash outright.

Recommended ON if supported.

Tell me what you think, we can keep adjusting it.

Actions #7

Updated by MayImilae over 11 years ago

Uses a loophole in NVIDIA's drivers for a performance improvement. There are no known problems with this option on NVIDIA systems, but it may cause issues on other chipsets.

Here's my proposal. "Vertex Streaming" is irrelevant to users and doesn't really matter. By cutting it out it makes the description shorter and simpler. We can have a longer description including vertex streaming in the dolphin manual (in progress).

Actions #8

Updated by JMC4789 over 11 years ago

But Degasus said it worked on Intel Chipsets as well, so we can't single out NVIDIA any longer.

Actions #9

Updated by MayImilae over 11 years ago

Alright, easy enough to work around.

"Uses a loophole in the OpenGL specification for a performance improvement. There are no known problems with this option on most systems, but it may cause issues on ATi/AMD chipsets."

Actions #10

Updated by delroth over 11 years ago

That's not a loophole though. It's defined as invalid.

Actions #11

Updated by MayImilae over 11 years ago

We should totally be doing this in the IRC...

"Uses forbidden operations for a performance improvement in OpenGL. There are no known problems with this on supported systems, but ATi/AMD GPUs do not support it and may encounter issues."

I forgot something in my last changes. it really need to say OPENGL in the tooltip. We've had enough problems with morons enabling this in DirectX, so we need to say it everywhere to make sure they get the message.

Actions #12

Updated by JMC4789 over 11 years ago

What about this,

"Uses unsafe operations in order to improve the performance of vertex streaming in OpenGL. There are no known problems if supported, but will cause severe stability and graphical issues otherwise.

Recommended ON if supported"

Actions #13

Updated by MayImilae over 11 years ago

Well, a few more tweaks.

"Uses unsafe operations to speed up vertex streaming in OpenGL. There are no known problems on supported GPUs, but it will cause stability and graphical issues otherwise.

Recommended ON. Disable if you encounter problems."

"Speed up" is shorter with fewer words and less syllables. It's a tooltip, and that's a free trim, so why not. Furthermore, I had a problem with the whole "Recommended on if supported by a GPU that may or may not be yours since we won't tell you" thing... I'm not comfortable spelling it out with things in such limbo though. So "Disable if you encounter problems" adds a little something to the "if" without telling the user to consider information they weren't given.

Actions #14

Updated by NeoBrainX over 11 years ago

Please don't break the "If unsure, leave this unchecked" scheme.

Actions #15

Updated by NeoBrainX over 11 years ago

Justification for the "If unsure, leave this (un)checked" scheme:
The description already helps people who know what they're doing, while adding "Recommended ON. Disable if you encounter problems" has no additional value to those people because they'll already have figured out the proper setting by reading the "main part" of the description. On the other hand, newbies won't be able to figure out whether to enable the setting or not. When they read "Recommended ON unless..." they'll get even more confused. That's the whole point of the "standardized" scheme: Give indecisive people a reliable suggestion that they can safely use.

Actions #16

Updated by NeoBrainX over 11 years ago

The description should say "If unsure, leave this UNchecked.", because just because it works now on a limited set of tested setups doesn't mean a) it's safe to be enabled on all setups b) a future driver update won't break the "feature". Recommending this stuff possibly means that it's harder to realize the culprit if that stuff randomly seems to break at some point IMO.

Delroth and I agreed that it'd be best to recommend unchecking the vertex streaming hack and instead explaining the option in more detail in the performance guide, where it'd be recommended to be enabled.

Actions #17

Updated by degasus over 11 years ago

  • Status changed from Accepted to Fixed

I've commited the last suggestion from MaJoR but with "severe" and neobrains suggestion in revision 1b1cc82e5b0b.

Actions

Also available in: Atom PDF