Project

General

Profile

Emulator Issues #6572

EFB access cache needs to be moved to VideoCommon

Added by delroth over 6 years ago. Updated about 1 year ago.

Status:
Fixed
Priority:
High
Assignee:
-
Category:
GFX
% Done:

0%

Operating system:
N/A
Issue type:
Task
Milestone:
Current
Regression:
No
Relates to usability:
No
Relates to performance:
Yes
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
5.0-9638

Description

Currently it's only in GL because I didn't knew what I was doing when I implemented it.


Related issues

Has duplicate Emulator - Emulator Issues #6275: Nintendo Puzzle Collection (J) has severe lockups in D3D9/D3D11Duplicate

Has duplicate Emulator - Emulator Issues #6553: Accessing any option of "With Friends" submenu in Super Smash Bros Brawl causes FPS drop and a lot of AlphaRead warningsDuplicate

Has duplicate Emulator - Emulator Issues #6571: RSBE01 (Brawl) Extreme Slowdown upon entering friend rosterDuplicate

Has duplicate Emulator - Emulator Issues #8252: Okami, D3D, lag when painting/fixing, [EFB Access]Duplicate

History

#1 Updated by delroth over 6 years ago

issue 6571 has been merged into this issue.

#2 Updated by delroth over 6 years ago

issue 6553 has been merged into this issue.

#3 Updated by delroth over 6 years ago

issue 6553 has been merged into this issue.

#4 Updated by rodolfoosvaldobogado over 6 years ago

Your idea of the peek cache is excellent, when it is moved to common code what do you think about doing the cache check in the cpu thread, in VideoBackendHardware::Video_AccessEFB, that way we can save some wait time?

#5 Updated by delroth over 6 years ago

I already have a patch that does this, actually :) Couldn't measure any performance impact, but in theory it should help. That's definitely a good thing to have when we will have a common peek cache.

#6 Updated by rodolfoosvaldobogado over 6 years ago

excelent :)

#7 Updated by delroth over 6 years ago

  • Milestone changed from Next to Current

4.0 was released, moving Milestone-Next to Milestone-Current.

#8 Updated by delroth about 6 years ago

  • Milestone changed from Current to Next

Moving to next milestone since these issues are not critical to a new release.

If you feel strongly about this issue and want it to block the next Dolphin release, please assign yourself as owner and re-add Milestone-Current.

#9 Updated by JMC4789 over 5 years ago

issue 6275 has been merged into this issue.

#10 Updated by JMC4789 over 5 years ago

issue 8252 has been merged into this issue.

#11 Updated by degasus almost 5 years ago

Renaming to relect that this cache should also be updated on EFB pokes.

Moving it to the CPU thread will be important as eg Monster Hunter Tri uses peeks & pokes for image manipulation. So all of this will stay on the CPU.

#12 Updated by JMC4789 over 4 years ago

This isn't fixing this issue, but, it can be implemented in all the hardware backends in https://github.com/dolphin-emu/dolphin/pull/3652

It's actually even better in the new one implemented, providing superior performance.

#13 Updated by JosJuice almost 4 years ago

  • Milestone changed from Next to Current

5.0 was released, moving Milestone-Next to Milestone-Current.

#14 Updated by JosJuice about 1 year ago

  • Fixed in set to 5.0-9638
  • Status changed from Accepted to Fixed

Also available in: Atom PDF