Emulator Issues #6840
closed
Fix locale issues in shaders generators properly
0%
Description
Something is broken about our shader generators. degasus felt like working around issues by randomly changing unrelated code and instead of fixing the issue properly in revision 045efdfc3e558f1152b116574d92015f27e396fa.
Meanwhile, Rodolfo has come up with his own fix in revision 15b6d75b775eec17a5b8e05362f2e0ad6d7750e0 but seems to have no interest in upstreaming that change. I don't know if that change is a proper fix or just a hack as well.
Given that people seem to be okay with the idiocy that is currently happening in TextureConversionShader (instead of using "%f" in printf, degasus used "%d.0"...) I don't expect anyone to care about this issue, but it's something that should be fixed because.. ffs do I even need to explain this?
Updated by rodolfoosvaldobogado over 10 years ago
Neobrain: is not a lack of interest is a lack of time, just now i'm in the final stages of a project an a little bussy. It will be interesting that someone else review my changes and if the changes are rigth i will merge them to master.
Updated by degasus over 10 years ago
Maybe we should also take a look at this function:
https://code.google.com/p/dolphin-emu/source/browse/Source/Core/Common/Src/StringUtil.cpp#32
It's the last one which uses locale at all. So it's likely broken, too.
Updated by rodolfoosvaldobogado over 10 years ago
that specific function is not broken because the locale generated with the old code is still usefull for *_l functions
Updated by 
Updated by
Updated by rodolfoosvaldobogado over 9 years ago
this issue is fixed in ishiiruka, but i don't know if its needed in master as i didn't see any place in master where locale is needed
Updated by NeoBrainX over 9 years ago
- Milestone deleted (
Current) - Priority changed from Urgent to Normal
Not much of a point in blocking releases over this, since it's mostly a "can we stop having stupid workarounds in our code?"-issue ...
Updated by pokechu22 over 1 year ago
- Status changed from Accepted to Fixed
This should be fixed now that we use fmt when generating shaders, since fmt is locale-independent by default.