https://bugs.dolphin-emu.org/https://bugs.dolphin-emu.org/favicon.ico?12013-11-27T19:11:20ZDolphin bug trackerEmulator - Emulator Issues #6840: Fix locale issues in shaders generators properlyhttps://bugs.dolphin-emu.org/issues/6840?journal_id=7084672013-11-27T19:11:20Zrodolfoosvaldobogadorodolfoosvaldobogado@gmail.com
<ul></ul><p>Neobrain: is not a lack of interest is a lack of time, just now i'm in the final stages of a project an a little bussy. It will be interesting that someone else review my changes and if the changes are rigth i will merge them to master.</p>
Emulator - Emulator Issues #6840: Fix locale issues in shaders generators properlyhttps://bugs.dolphin-emu.org/issues/6840?journal_id=7084682013-11-28T01:37:49Zdegasuswickmarkus86@gmail.com
<ul></ul><p>Maybe we should also take a look at this function:<br>
<a href="https://code.google.com/p/dolphin-emu/source/browse/Source/Core/Common/Src/StringUtil.cpp#32" class="external">https://code.google.com/p/dolphin-emu/source/browse/Source/Core/Common/Src/StringUtil.cpp#32</a></p>
<p>It's the last one which uses locale at all. So it's likely broken, too.</p>
Emulator - Emulator Issues #6840: Fix locale issues in shaders generators properlyhttps://bugs.dolphin-emu.org/issues/6840?journal_id=7084692013-11-28T02:27:27Zrodolfoosvaldobogadorodolfoosvaldobogado@gmail.com
<ul></ul><p>that specific function is not broken because the locale generated with the old code is still usefull for *_l functions</p>
Emulator - Emulator Issues #6840: Fix locale issues in shaders generators properlyhttps://bugs.dolphin-emu.org/issues/6840?journal_id=7084702014-04-08T10:03:02Zdelrothdelroth@gmail.com
<ul><li><strong>Priority</strong> set to <i>Urgent</i></li></ul> Emulator - Emulator Issues #6840: Fix locale issues in shaders generators properlyhttps://bugs.dolphin-emu.org/issues/6840?journal_id=7084712014-09-20T22:51:08ZJMC4789JMC4789@gmail.com
<ul></ul><p>Any updates on this issue whatsoever?</p>
Emulator - Emulator Issues #6840: Fix locale issues in shaders generators properlyhttps://bugs.dolphin-emu.org/issues/6840?journal_id=7084722014-09-20T23:08:27Zrodolfoosvaldobogadorodolfoosvaldobogado@gmail.com
<ul></ul><p>this issue is fixed in ishiiruka, but i don't know if its needed in master as i didn't see any place in master where locale is needed</p>
Emulator - Emulator Issues #6840: Fix locale issues in shaders generators properlyhttps://bugs.dolphin-emu.org/issues/6840?journal_id=7084732014-09-20T23:12:33ZNeoBrainXNeoBrainX@gmail.com
<ul><li><strong>Milestone</strong> deleted (<del><i>Current</i></del>)</li><li><strong>Priority</strong> changed from <i>Urgent</i> to <i>Normal</i></li></ul><p>Not much of a point in blocking releases over this, since it's mostly a "can we stop having stupid workarounds in our code?"-issue ...</p>
Emulator - Emulator Issues #6840: Fix locale issues in shaders generators properlyhttps://bugs.dolphin-emu.org/issues/6840?journal_id=7453332022-10-27T00:49:32Zpokechu22
<ul><li><strong>Status</strong> changed from <i>Accepted</i> to <i>Fixed</i></li></ul><p>This should be fixed now that we use <code>fmt</code> when generating shaders, since <a href="https://fmt.dev/latest/api.html#locale" class="external">fmt is locale-independent by default</a>.</p>