Project

General

Profile

Emulator Issues #6915

Star Wars: The Force Unleashed 2 - Problem when saving the game

Added by oangelo about 6 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

[READ THIS: https://forums.dolphin-emu.org/showthread.php?pid=276132 <<<
Your answers are there!]
[Leave the questions as they are and answer them in the next line]
[Remove lines written inside brackets [], but nothing else]

Game Name?
Star Wars: The Force Unleashed 2

Game ID?

SFUE64

What's the problem? Describe what went wrong in few words.
The game is not been saved. Every time I started the game, there was no saved data, but should, since the game saved many times during the game play.

What did you expect to happen instead?
I expected to load the saved games.

What steps will reproduce the problem?
[Don't assume we have ever played the game and know any level names. Be as
specific as possible.]
1.Play the game until it saves the state
2.Start the game again

Dolphin 3.5 and 3.5-367 are old versions of Dolphin that have
known issues and bugs, so don't report issues about them and test the
latest Dolphin version first.
Which versions of Dolphin did you test on?

4.0-565

Does using an older version of Dolphin solve your issue? If yes, which
versions of Dolphin used to work?

Don't know.

What are your PC specifications? (including, but not limited to: Operating
System, CPU and GPU)
Linux x64, Nvidia GeForce GTX 660 Ti, i7 3.2GHz

Are you using the 32 or the 64 bit version of Dolphin?
64

Is there any other relevant information? (e.g. logs, screenshots,
configuration files)
[Upload big files to a hosting service and post links here!]

In other games I have no problem saving the states.

[Do not attach files to this issue. Upload them to another site and
link here. Use imgur.com for images and pastie.org for logs.]

History

#1 Updated by parlane about 6 years ago

  • Status changed from New to New

#2 Updated by JMC4789 almost 6 years ago

  • Status changed from New to Accepted

I saw two more reports of this on the forum and the banner isn't saving.

#3 Updated by hatarumoroboshi almost 6 years ago

Must be a very old issue, since this game recognises the save perfectly on 3.0.432 but doesn't do it anymore on 3.0-465 (unfortunately revisions in between crash on my system with a "compiling at 0" error so I cannot test any further...)

#4 Updated by rigation about 5 years ago

Well I'm just making a blind guess, but from what I can read, in my opinion the only (or most probable) revision that should have caused the issue between 3.0.432 and 3.0.465 is 3.0.436 - Revision 53d2d9718fe3 https://code.google.com/p/dolphin-emu/source/detail?r=53d2d9718fe3 (if I understand it right, that revision should have somewhat to do with saving files)...am I wrong?

#5 Updated by JMC4789 about 5 years ago

yup

#6 Updated by parlane about 5 years ago

Test 435 and then 436 please

#7 Updated by rigation about 5 years ago

It's impossible to test 3.0-436 since before the SW main game menu comes out it gives a "error compiling at 0" error message and crashes.
3.0.433 doesn't have this problem and also doesn't have the save problem

#8 Updated by rigation about 5 years ago

The only way to test this game, would be to have a recent master build without those changes

#9 Updated by oangelo about 5 years ago

I tested with dolphin 4.0-4720 and I can play the game very well, I still can't save, though.

#10 Updated by mimimi about 5 years ago

I think this is related to either the number of allowed file handles, or not freeing file handles.

If i set IPC_MAX_FDS to 0x118 instead of 0x18, the game saves a banner.

The log for the game spams stuff like:
50:43:366 IPC_HLE\WII_IPC_HLE.cpp:370 W[WII_IPC_HLE]: Trying to open /tmp/.trz as -1
50:43:366 IPC_HLE\WII_IPC_HLE.cpp:370 W[WII_IPC_HLE]: Trying to open /tmp/.tex as -1
50:43:381 IPC_HLE\WII_IPC_HLE.cpp:370 W[WII_IPC_HLE]: Trying to open /tmp as -1

The linked commit looks suspicious:
https://code.google.com/p/dolphin-emu/source/detail?r=53d2d9718fe3

It removes m_pFileHandle.Close(); on closing a file.

The file handling on master seems to be done in a different way now. But to me it looks like closing file handles was removed in that commit, and further changes didn't change that "functionality".

If this is really what is happening, i wonder why there aren't any more games that are exploding.

#11 Updated by parlane about 5 years ago

  • Status changed from Accepted to Fixed

Fixed by pr 1876

Also available in: Atom PDF