Emulator

Does crash occur if you are using EFB 2 Texture?

It's an issue, trust me. I know what I'm doing here.

But you're right about OGL, I must have had it set to EFB>Texture when I checked there. And I guess somehow when I went to check EFB>Texture in DX I did something wrong because that DOES turn off the effect and prevents the crash.

Here's what I just did:
Download x64 package from official site
Unpack
Launch Mario Kart (pure defaults)
Navigate to Mirror Grand Prix > Leaf Cup > DS Desert Hills
Start and play race just fine (no sun flair)
Stop emulation
Switch to EFB>Ram
Relaunch game and repeat
Crash at the exact same spot every single time

I'm surprised no one else is seeing this. Let me know what more information I can provide.

I agree, D3D doesn't seem entirely stable. Skid said it was, and I thought back and remembered something happening to me at one point when playing on my laptop long ago...

Either way, I don't think OGL will crash, I've played a lot of Mario Kart on Wifi + did recording for the Dolphin 4.0 video with EFB2Ram on.

It seems random though, I haven't had an issue yet today. What do I need to do? Is one race enough?

(If you have an issue with the name change just let me know when you update us. Thanks!)

err, I should say that skid_au is the one who said the behavior would be unpredictable. That was very, very poor wording on my part. I thought D3D worked fine from my testing/playing late last year.

OGL does not crash with/without EFB>Ram. DX crashes only with EFB>Ram active (sun flair/other effects on).

Happens seconds after you start a race on Mirrored DS Desert Hills. At this exact point: http://imageshack.us/photo/my-images/208/d3zm.png/

Here appears to be the culprit, this panic handler comes up if you do it in vs mode instead of grand prix.

DX11::PSTextureEncoder::EncodeFailed in PSTextureEncoder.cpp at line 1170: map staging buffer

more info: EFB: Poke Z not implemented (tried to poke z value at (44,16))

I tried this about a dozen more times. There are indeed multiple error messages.

new one

DX11::PSTextureEncoder::EncodeFailed in PSTextureEncoder.cpp at line 110: map staging buffer (0x887a0005)

Sorry about the delay, I really thought the new message was the EFB Poke one.

I've been told my random crashes with Dolphin (latest build) are related to this issue. I get random freeze/crashes in most of the game I've tried to run. This includes Mario Kart Double Dash. Though I haven't seen a particular effect cause it. (the lens flare effects in Double Dash seem to work fine for me)

On crash, I've seen the map stating buffer error before. I think I got that in Golden Eye 007. I get a different error for GameCube games/in DX9 mode.

this isn't a new problem, so this isn't related to any of your other crashes, afaik.

Issue 7352 has been merged into this issue.

After upgrading to a new video card that supports DX11 (my old card only supported DX10) the issue has since gone away.

Issue 7407 has been merged into this issue.

Invalid Write to 0x50303118, PC= 0x80511544 (infinite code)

http://i.imgur.com/iYp9iH5.png

Issue 8288 has been merged into this issue.

I think this is the issue you meant to put yourself on :)

yes sorry :)

I'm setting this to current because it's a pretty big problem when Mario Kart Wii requires EFB Copies to RAM for some effects to work, and on D3D it just crashes.

I wonder if this has something to do with EFB Peeks/Pokes being offset in D3D?

the error is happening because sometimes dx11 is writing to memory a incorrect amount of bytes and that is corrupting the gc/wii memory. I still have to discover where is the error in the algorithm.

There's a source rectangle with the following dimensions:
left: 304, right: 308, top: 1020, bottom: 1024

In d3d, the rectangle is clamped to the efb size:
correctSrc.ClampUL(0, 0, EFB_WIDTH, EFB_HEIGHT);

which results in height being 492 instead of 4, resulting in that crash.

Thanks rodolfo for tracking it down to writing an incorrect amount of bytes, from there it was easy to find out what's wrong.

:) nice catch I was going to look at that this weekend you save me the work :)

Now the question is: Can we just remove that?

// Clamp srcRect to 640x528. BPS: The Strike tries to encode an 800x600
// texture, which is invalid.

So i wonder if this "BPS: The Strike" works right now in OpenGL using efb2ram.

Good question we have to found someone with the game to get some testing

See https://github.com/dolphin-emu/dolphin/pull/2169 . I'm not sure clamping is correct, but that fixes the part where clamping increases the height of a rectangle.

you are rigth, it fixes the issue but i don't know if clamping is the correct way to go here i think a hardware test will really help here