Project

General

Profile

Actions

Emulator Issues #695

closed

Logging bugs found in code.

Added by jeffjohnson0 over 15 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Found the following two issues with the Logging Code in SVN 2536

INFO_LOG(WII_IPC_WIIMOTE, "******************************"); Never shows up
in the log. I believe it is due to the issues below.

(1)
In the function "LogManager::Log", the variable "type" is declared as:
int type = _type % 100;
"type" should be used in place of "_type" is most places in this Log()
function. For example,
if (m_Log[_type] == NULL || !m_Log[_type]->m_bEnable
seems like it should be:
if (m_Log[type] == NULL || !m_Log[type]->m_bEnable

(2)
The file Log.h contains the following defines:
#define WARN_LOG(t,...) {GENERIC_LOG(LogTypes::t, LogTypes::LINFO,
VA_ARGS)}
#define INFO_LOG(t,...) {GENERIC_LOG(LogTypes::t, LogTypes::LWARNING,
VA_ARGS)}
It appears that the LINFO and LWARNING are backward.

Actions #1

Updated by marcus over 15 years ago

Well spottted.

Actions #2

Updated by nakeee over 15 years ago

fixed 2 no idea about one, you should ask JP

Actions #3

Updated by marcus over 15 years ago

Since that isn't really easy to do for someone who isn't a dev...

Actions #4

Updated by nakeee over 15 years ago

  • Status changed from New to Fixed
Actions

Also available in: Atom PDF