Project

General

Profile

Actions
Copy link

Emulator Issues #6993

closed

Review crediar's Triforce branch

Added by Sonicadvance1 about 10 years ago.

Status:
Won't fix
Priority:
Normal
Assignee:
Sonicadvance1
% Done:

0%

Operating system:
N/A
Issue type:
Task
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
Yes
Regression start:
Fixed in:

Description

Need to review the code in crediar's Triforce branch and provide constructive criticism on what needs to be improved prior to it being in a merge-able state.

Provide a list of criticisms in following posts

Actions
Copy link
 #1

Updated by Sonicadvance1 over 9 years ago

  • Status changed from New to Won't fix

sarcastic issue is sarcastic.

Actions
Copy link
 #2

Updated by WesaMcDaniel over 9 years ago

So what is the status of this exactly? This is the one piece missing from the main product. What needs to happen so we can play Triforce games on mainline builds?

I know there's some things that are not ideal here, but can we list EXACTLY what is blocking this from a merge, so some individual tasks can be created to hopefully help with getting this integrated after all these years.

Actions
Copy link
 #3

Updated by delroth over 9 years ago

What's missing is a proper implementation of Triforce support made by someone interested in getting it merged in, instead of an ugly parachuted code drop of thousands of unreviewable LOC.

Actions
Copy link

Also available in: Atom PDF