Project

General

Profile

Actions

Emulator Issues #7000

closed

Cache Display Lists is completely incompatible with NVIDIA Buffer Storage

Added by JMC4789 almost 11 years ago.

Status:
Fixed
Priority:
High
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

This affects all games. Any modern NVIDIA card will produce garbled, destroyed graphics when using cache display lists alongside Buffer Storage.

Previously with the Vertex Streaming Hack, this was not an issue.

I'm not entirely sure what should be done with the option. It does provide a small boost to some games, but considering it completely breaks pretty much every game on modern NVIDIA cards, there needs to be some way to help users not trigger this. I accidentally did and spent a while figuring out. Options are:

  1. Figure out a way to disable Cache Display Lists when Buffer Storage is used
  2. Remove the Cache Display List option because it has minimal effects at best + it's a hack and neobrain hates those.
  3. Do nothing and torment the forum mods as they answer a bevy of questions from frustrated users
  4. Add a warning to the tooltip

I'm sure there are other options, I just wanted to provide mine.

Actions #1

Updated by degasus almost 11 years ago

let me guess, our dl cache reads back from the streaming buffer? This isn't allowed on many apis ...

So if we want to keep our dl cache, we have to set up a fake buffer and memcpy there (like we always did)

Actions #3

Updated by Sonicadvance1 almost 11 years ago

.+1 for cutting out DL

Actions #7

Updated by pauldacheez almost 11 years ago

I don't know how the fuck the display list cache has even stayed in Dolphin for so long, it breaks shit all over the place. LET'S REMOVE IT

Actions #8

Updated by crudelios almost 11 years ago

I agree with the removal, for me this hack always seemed to bring more problems than benefits. It should also help clean the codebase a little bit.

Actions #9

Updated by NeoBrainX almost 11 years ago

  • Status changed from New to Fixed

display lists no longer exists => fixed.

Actions #10

Updated by MayImilae almost 11 years ago

Wiki is clean of dlist caching. Good riddance.

Actions #11

Updated by MayImilae almost 11 years ago

Fixed by 4.0-751 "VideoCommon: remove Cache Displaylist" - https://github.com/dolphin-emu/dolphin/commit/010a0d481ad0f5dd19182eafc411feec387404db

Merged into Master as 4.0-758 "Merge pull request #13 from degasus/dlCacheRemove" - https://github.com/dolphin-emu/dolphin/commit/0735fb7a52876939bebda82be89145b1aa344606

Actions

Also available in: Atom PDF