Project

General

Profile

Actions

Emulator Issues #712

closed

Loglevel 2 in the release build causes major slowdown in MGS:TS

Added by sl1nk3.s about 15 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Other
Milestone:
Regression:
No
Relates to usability:
Yes
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

What steps will reproduce the problem?

  1. build a regular dolphin release build -without any changes- after r2550
  2. run Metal Gear Solid : TS on this rev (when loglevel was added)

What is the expected output? What do you see instead?
Before r2550, the game was running at 'good' speed, now it's freaking slow,
4 times slower.

What version of the product are you using? On what operating system?
WinXP x86 - Core 2 Duo, 3.4Ghz

Please provide any additional information below.
Settings loglevel to 0 in log.h fixed the slowdowns.
So the game is probably throwing a shitload of logging informations when
the loglevel is set to 2 which somehow slows down the emu.

As these logs cannot be seen (or i don't know how-to) using standard
settings, they should per haps be disabled by default unless the users want
to build with logging on ?
Hope this help :)


Related issues 1 (0 open1 closed)

Has duplicate Emulator - Emulator Issues #713: Massive performance hit in new revsDuplicate

Actions
Actions #2

Updated by marcus about 15 years ago

Issue 713 has been merged into this issue.

Actions #3

Updated by marcus about 15 years ago

Yeah, how do we see these logs?

Actions #4

Updated by marcus about 15 years ago

  • Relates to usability set to Yes
  • Issue type set to Other

Wait, they're under User/Logs.

Run the game for a while, then look at the files in that folder. There should be a
huge one and a few smaller ones. Open the huge one, and copy a sizable sample of the
text from the beginning and from the end of the file to the large box at
http://paste2.org/new-paste. Click the Submit button, and copy the URL of the page
it takes you to here. Also, post the size of the huge file here.

Actions #5

Updated by sl1nk3.s about 15 years ago

err.. i just saw that the logManager is now built even on the release build since
r2550, you still need to use the debugger for the log window to show though.

marcus > the log files aren't updated when using a standard release build, but it
still slows down, so i can't tell what's slowing down the game, and whatever it is,
it shouldn't as i'm not using the logmanager.

So i'll modify my last message a bit according to this :p :
"For the standard release build, it may be better to either disable the logManager or
fix it so that it doesn't make games slower when you don't use it."

Sorry to give you more work nakee :(

Actions #6

Updated by sl1nk3.s about 15 years ago

I found out the cause of this problem:
it's "WARN_LOG(COMMANDPROCESSOR, "(r): 0x%08x", _Address);" line 243 of
CommandProcessor.cpp in Read()
Using the debugger i saw it was spamming the logmanager (the log file went to 66MB in
a few seconds) and commenting it fixed the speed.

The problem is quite the same though, either turn this into an INFO_LOG, or disable
log by default (as far as i can tell, a normal user shouldn't need to use the
logManager), or "fix it" so that it doesn't make games slower when you don't use the
logManager (it doesn't even write the content to the log files... a simple condition
may do the trick).

Actions #7

Updated by Anonymous about 15 years ago

  • Status changed from New to Fixed

committed

Actions

Also available in: Atom PDF