Emulator Issues #7145
closed
Luigi's Mansion Static in Music Sheets Battle (LLE)
0%
Description
May be related to other static issues, such as issue 6955
Well this is different. Luigi's Mansion (GLME01) has two bursts of static during the Music Sheets battle. They always occur in the exact same places in the loop, and while the two different Bzzts sound different, the same Bzzt repeated sounds exactly the same as the previous time it was played.
Audiodump - http://www.mediafire.com/listen/hdq6v5yh9ax17yg/Luigi's_Mansion_Music_Sheets_BZZT.mp3
Curiously, this only occurs with DSP LLE (both official roms and Dolphin provided roms). DSP HLE, before or after the recent Zelda-Ucode-HLE changes, doesn't exhibit this issue. I tested all audio backends available on windows machines, and the pattern was completely consistent. LLE has the Bzzt, HLE doesn't.
To reproduce, load the GCI file below. Head through the double doors on the first floor, go right, then down the hall, then left, and enter the first door. If you get lost just press the Y button - it's the door with the key floating over it on the map. Turn on all the instruments, answer her question, and then you'll do battle with her "Music Sheets". That's the music with the bzzt.
GCI - http://www.mediafire.com/download/dq289wm7pon8z54/GLME_LUIGI_MANSION_SAVEDATA_v3.7z
Tested Revisions:
4.0 win64 - LLE Bzzt, HLE no Bzzt
4.0-1302 win64 - LLE Bzzt, HLE no Bzzt
4.0-1340 win64 - LLE Bzzt, HLE no Bzzt
Tested on System:
Windows 7 x64
Core i5 3570K @ 4.7ghz
Nvidia GeForce GTX 760
Asus Xonar Essence STX PCIe
Files
Updated by JMC4789 about 12 years ago
- Status changed from New to Accepted
I'm willing to accept based on bad youtube playthroughs, but I'm planning on verifying it myself later today.
Updated by JMC4789 about 12 years ago
Console does not have this bug, I just had to go and check for myself rather than trusting my ears on some stupid youtube playthrough.
Confirmed 100% as Dolphin bug.
Updated by JMC4789 about 12 years ago
- Category set to dsphle
HLE has problems in other battles that exactly mirror this one. The prelude to the Baby boss battle has the same symptoms.
Updated by delroth about 12 years ago
How is it supposed to sound like?
Updated by JMC4789 about 12 years ago
This is the Piano scene in the original post of the issue, except I dumped the audio from console. Enjoy.
https://dl.dropboxusercontent.com/u/484730/LuigisMansionPiano.wav
Updated by JMC4789 about 12 years ago
- Category deleted (
dsphle)
Never trust HLE, even to be wrong.
Updated by thealexbarney about 12 years ago
I did some work ripping the Luigi's Mansion soundtrack a few years ago, and I ran across this exact problem with both LLE and HLE.
Updated by delroth almost 12 years ago
- Milestone changed from Current to Next
Moving to next milestone since these issues are not critical to a new release.
If you feel strongly about this issue and want it to block the next Dolphin release, please assign yourself as owner and re-add Milestone-Current.
Updated by Quinn.Bigbird over 10 years ago
Has this been fixed in Zelda HLE?
Updated by kolano over 10 years ago
This apparently doesn't occur with HLE, and recent revisions likely have fixed other issues with HLE. So HLE is likely now recommended with this game. This should still be cleanned up with LLE audio though.
Updated by JosJuice almost 10 years ago
- Milestone changed from Next to Current
5.0 was released, moving Milestone-Next to Milestone-Current.
Updated by JMC4789 about 5 years ago
- Milestone changed from Current to Next
Now that HLE audio works pretty well, I don't think this should be a blocker for any release. Let's move it to next again.
Updated by flacs almost 2 years ago
- Category deleted (
DSPLLE)
I finished the battle and didn't hear the static noise with LLE. Might have been fixed at some point.
Updated by pokechu22 8 months ago
I am curious when this was fixed and whether both the recompiler and interpreter were affected, though I don't have a copy of Luigi's Mansion myself. https://github.com/dolphin-emu/dolphin/pull/10045 seems like a good candidate to test.
Updated by Adamillo 8 months ago
- File dspdump.flac dspdump.flac added
pokechu22 wrote in #note-18:
I am curious when this was fixed and whether both the recompiler and interpreter were affected, though I don't have a copy of Luigi's Mansion myself. https://github.com/dolphin-emu/dolphin/pull/10045 seems like a good candidate to test.
I tested Dolphin 5.0-14966 before your PR got merged and sure enough the issue was there, but only on DSP LLE JIT recompiler! On DSP LLE interpreter I was unprepared for what I was about to listen! When Dolphin 5.0-14988 with your PR merged it fixed the general static noise issue with DSP LLE interpreter and the piano sheet battle music. DSP LLE JIT recompiler didn't output no audio in that build, which was fixed in Dolphin 5.0-14993! The bug with the piano sheets battle music still remains in that build though, so this PR fixed a different issue with DSP LLE interpreter, but didn't fix the actual bug here in this issue
Updated by pokechu22 8 months ago
Looks like the only other changes that touched DSP LLE recompiler functionality (not just documentation, renaming, or initialization) are https://github.com/dolphin-emu/dolphin/pull/10709 https://github.com/dolphin-emu/dolphin/pull/10716 and https://github.com/dolphin-emu/dolphin/pull/10723. I don't think any of these are super likely to be the cause, but I don't know what else it could be.