Project

General

Profile

Actions

Emulator Issues #7193

closed

VP6 Video Decoder Issue

Added by JMC4789 almost 10 years ago. Updated over 2 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
5.0-15515

Description

Game Name?

MVP Baseball 2005 - GV4E69
NHL 2003 - GH3E96
Any mediocre EA Sports title that uses that one video format.
Several other EA games.
Do note this does not affect all EA games

What's the problem? Describe what went wrong in few words.

They appear to have vertical lines all over them
https://dl.dropboxusercontent.com/u/484730/GV4E69-6.png

What did you expect to happen instead?

On my Radeon graphics card, the videos look fine, but other games (especially NES ones) have horizontal/vertical lines like this.

What steps will reproduce the problem?
[Don't assume we have ever played the game and know any level names. Be as
specific as possible.]
1.Regrettably possess an EA Title
2.Possess a NVIDIA graphics card, be currently using it in your PC
3.Start Game

Dolphin 3.5 and 3.5-367 are old versions of Dolphin that have
known issues and bugs, so don't report issues about them and test the
latest Dolphin version first.
Which versions of Dolphin did you test on?

4.0-1430

Does using an older version of Dolphin solve your issue? If yes, which
versions of Dolphin used to work?

No versions of Dolphin work on NVIDIA graphics cards for the videos.

What are your PC specifications? (including, but not limited to: Operating
System, CPU and GPU)

Core i5 3570K, GTX 760, Windows 7 x64

Are you using the 32 or the 64 bit version of Dolphin?

64bit

Screenshot again: https://dl.dropboxusercontent.com/u/484730/GV4E69-6.png


Files

ea_sports-2018-04-20_10.47.53-edited.mp4 (799 KB) ea_sports-2018-04-20_10.47.53-edited.mp4 EA Sports intro glitches peter_parker, 04/20/2018 01:57 PM

Related issues 5 (2 open3 closed)

Related to Emulator - Emulator Issues #8780: Corrupt dancers in Just Dance (regression)Accepted

Actions
Related to Emulator - Emulator Issues #12666: Bink Video decodes incorrectly on some devicesNew

Actions
Has duplicate Emulator - Emulator Issues #8792: SSX3 weird graphical barsDuplicate

Actions
Has duplicate Emulator - Emulator Issues #9314: Need for Speed: Most Wanted - Cutscene screen tearingDuplicate

Actions
Has duplicate Emulator - Emulator Issues #6714: EA SPORTS Active, problem with colors and videosDuplicate

Actions
Actions #2

Updated by Jason.G.Gorman almost 10 years ago

Same here and it is with all Bink compressed videos. The lines are affected by using different anti-aliasing types and different internal resolutions.

Actions #3

Updated by pkmnred887 almost 10 years ago

Can confirm that the video at the beginning of FIFA 07 also has issues.

Actions #4

Updated by JMC4789 over 9 years ago

  • Status changed from New to Accepted

Accepting.

Actions #5

Updated by kostamarino over 9 years ago

Could issue 7393 be related to this one? The fix for those ea videos by delroth came after the merge of tev fixes new to double check it, but the situation seems similar, videos with lines and nvidia gpus.

Actions #6

Updated by Vhonan11 over 9 years ago

I have the same issue. Mvp baseball has vertical lines and when you get past the start menu the graphics are all screwed up

Actions #7

Updated by mbc07 over 9 years ago

If it helps, Just Dance 1/2/3/4, Michael Jackson The Experience and ABBA: You Can Dance also use Bink videos and suffer from the same issue...

(not reproducible in JD2014/2015, apparently these games uses a new engine)

Actions #8

Updated by delroth over 9 years ago

Bink videos? That's different, are you sure you haven't enabled "Force texture filtering"?

EA videos are VP6, not Bink.

Actions #9

Updated by mbc07 over 9 years ago

Force Texture Filtering cause issues too, but disabling it and messing with anisotropic filtering and IR causes the same artifacts from the screenshot JMC47 posted in OP. At least in Just Dance 1 disc I can see a lot of .bik video files, so I'm assuming it's bink. In JD 2/3/4 they're packed in .bf0/.bf1 files so I can't confirm the video format.

However, I definitely can reproduce this issue with bink videos too...

Actions #10

Updated by kostamarino over 9 years ago

Any type of texture filtering can mess up dolphin videos, this issue happens regardless of having texture filters enabled or not.

Actions #11

Updated by ZephyrSurfer over 9 years ago

I'm working on this now. I think I've got the solution but I'll need a couple days :P

Actions #12

Updated by JMC4789 over 9 years ago

It's broken on AMD GPUs under their newer drivers now.

Actions #13

Updated by megarockexe over 9 years ago

I will "me too" on this one too.
The videos like in the intro of Rock band 3 use Bink and have these artifacts. It only happens when I try to use a natively-sized window on auto window size resolution. It makes everything else sharper, but videos look like that. I've extracted the bink and of course it doesn't have the lines going through it. Even on newer builds, this happens.

Actions #14

Updated by ZephyrSurfer over 9 years ago

@megarock
What's your Hardware?

Actions #15

Updated by megarockexe about 9 years ago

Intel Core i5 2500k 3.3. Ghz
8GB RAM
Windows 8.1 64-bit
Nvidia GTX 650

Running on Open GL.

Actions #17

Updated by JMC4789 almost 9 years ago

Issue 8457 has been merged into this issue.

Actions #18

Updated by JMC4789 over 8 years ago

Issue 8792 has been merged into this issue.

Actions #19

Updated by JMC4789 about 8 years ago

Actions #20

Updated by JMC4789 about 8 years ago

  • Subject changed from EA Videos are still somewhat broken (NVIDIA) to EA Videos are still somewhat broken (Intel/NVIDIA)
Actions #21

Updated by endrift about 8 years ago

This is a result of an indirect texture lookup accuracy bug, it seems. https://github.com/dolphin-emu/dolphin/pull/3570 fixes it for Intel on OS X, but not Nvidia. Tweaking indirect texture lookup stuff can make it better or worse, depending, it seems.

Actions #22

Updated by JosJuice about 8 years ago

Actions #23

Updated by shellashock about 8 years ago

Looks like "Asterix and Obelix at the Olympic Games" (PAL - RQXP70) suffers from this issue as well. Only happens to videos in-game (all videos are .vid on disk; extracting them and playing in VLC will not show the lines) and is affected by Wii Aspect Ratio (4:3 or 16:9), Pal60 mode on or off, IR, and AA. Affects Intel HD Graphics and Microsoft Basic Render Driver for all videos (cinematic, menu videos, etc) and does not affect Radeon R7 240 at all. Software Renderer is not affected. Link to folder JMC47 requested with FIFO logs + screenshots: https://www.mediafire.com/folder/28d78ttqz7h0w/JMC47_Request_Folder

Hope this helps.

Tested using Intel Core B940 (2.0 GHz) with Intel HD Graphics (driver: 9.17.10.4229) and Microsoft Basic Render Driver.
Tested on Dolphin 4.0-8860
OS: Windows 10 (x64) Home

Tested using AMD Athlon II x2 B24 (3.0 GHz) with ASUS Radeon R7 240 2GD3-L (driver: 15.300.1025.1001).
Tested on Dolphin 4.0-8860
OS: Windows 10 (x64) Professional

Actions #24

Updated by JMC4789 almost 8 years ago

From endrift:

I noticed that, on systems where this is broken, adjusting anisotropic filtering will cause smudging effects that are segmented along the lines in the ea-vp6.dff FIFO. Antialiasing and render size did not appear to affect it though. I don't know how anisotropic filtering works in Dolphin, but it's kind of suspect that this only causes smudging on systems where it's broken

Actions #25

Updated by endrift almost 8 years ago

It looks like the problem is a rounding error. I have a patch I'm extremely unsatisfied with, as I think it's a pretty high risk patch and just says "epsilons are the answer!" which is uh, false.

diff --git a/Source/Core/VideoCommon/PixelShaderGen.cpp b/Source/Core/VideoCommon/PixelShaderGen.cpp
index dafed0d..0353873 100644
--- a/Source/Core/VideoCommon/PixelShaderGen.cpp
+++ b/Source/Core/VideoCommon/PixelShaderGen.cpp
@@ -836,7 +836,7 @@ static void WriteStage(T& out, pixel_shader_uid_data* uid_data, int n, API_TYPE
        uid_data->SetTevindrefTexmap(i, texmap);

        out.Write("\ttextemp = ");
-       SampleTexture<T>(out, "float2(tevcoord.xy)", texswap, texmap, ApiType);
+       SampleTexture<T>(out, "(float2(tevcoord.xy) + 0.05)", texswap, texmap, ApiType);
    }
    else
    {

The real fix for this is to integerize texture lookups, but wow that is out of my realm of expertise.

Actions #26

Updated by lmello about 7 years ago

Dolphin 5.0, linux, Red Steel 2, using an AMD Radeon R7 250E (Mesa 13, OpenGL 4.3) playback video is still a bit buggy (especially the training lady showing how to use your sword during the tutorials)

Actions #27

Updated by JMC4789 about 7 years ago

Actions #28

Updated by JMC4789 over 6 years ago

Actions #29

Updated by Lettendo about 6 years ago

Screenshot link is invalid.

Actions #30

Updated by peter_parker almost 6 years ago

@endrift, while your patch works for most of the videos, in Fifa 07 the "EA Sports it's in the game" intro video will show other glitches than the previous bars.

Without the fix, this intro will have the same bars glitches like other videos. I've attached a small video with the intro (patch applied).

Actions #31

Updated by peter_parker almost 6 years ago

More testing: in above comment, I checked using branch (5.0) (because I'm on Ubuntu 16.04, which has gcc 5 as default. Installing gcc6 and using master branch, even the EA intro is fine with @endrift patch.

Actions #32

Updated by danileon95 over 5 years ago

I just want to add that Need for Speed Most Wanted videos are still broken on Windows, with a GTX 1070 and latest drivers

Actions #33

Updated by benitez about 5 years ago

danileon95 wrote:

I just want to add that Need for Speed Most Wanted videos are still broken on Windows, with a GTX 1070 and latest drivers

Same here, with the same graphics card. It also happens in other EA games such Fifa Street 2.

Actions #34

Updated by benitez about 5 years ago

Same here, with the same graphics card. It also happens in other EA games such as Fifa Street 2.

Actions #35

Updated by JosJuice about 5 years ago

Actions #36

Updated by JMC4789 over 2 years ago

  • Related to Emulator Issues #12559: Rabbids Go Home - Prerendered video choppy and has horizontal lines added
Actions #37

Updated by JMC4789 over 2 years ago

  • Subject changed from EA Videos are still somewhat broken (Intel/NVIDIA) to VP6 Video Decoder Issue

Even though EA primarily used it, there are tons of games using VP6 videos that aren't EA and it was just an error to assign it to them.

Actions #38

Updated by pokechu22 over 2 years ago

Actions #39

Updated by pokechu22 over 2 years ago

Actions #40

Updated by pokechu22 over 2 years ago

Actions #41

Updated by pokechu22 over 2 years ago

  • Related to deleted (Emulator Issues #12559: Rabbids Go Home - Prerendered video choppy and has horizontal lines)
Actions #42

Updated by pokechu22 over 2 years ago

Actions #43

Updated by pokechu22 over 2 years ago

Actions #44

Updated by pokechu22 over 2 years ago

Actions #45

Updated by JMC4789 over 2 years ago

  • Status changed from Accepted to Fixed
  • Fixed in set to 5.0-15515

Fixed by revision 5.0-15515 -> https://dolphin-emu.org/download/dev/6f4bbac528682389e34a1a4985820ee5137619c7/

Needs Manual Texture Sampling enabled in Graphics Settings -> Advanced for now until INIs are updated.

Actions

Also available in: Atom PDF