did you try putting your screen gamma higher or your main gamma from windows/linux/mac.

Lol, yes, of course. It was the first thing which i'd tried.
Obvious, isn't?

Strange question... Dolphin is an emulator, right?
May be I did miss something...

Yes dolphin is a emulator!

zantezuken: Imagine even MORE lines of code executing between each frame. It can
severely slow down the emulation.

Change your gamma settings inside the GFX card driver, dammit.

Great solution. Now we just wait for the times when we NEED to use a hacked GFX
drivers with Dolphin.
Nice way for emulation progress, indeed.

Why would you need hacked GFX drivers XD
Dolphin runs fine and the Gamma thing isn't even a real problem.

You miss the point. I was being sarcastic about emulation way (if we can call that
way an "emulation") of Dolphin.
It is like:
"Why do we need to proper emulate videosystem? Better to change gamma settings in
drivers!"
and more:
"Why do we need to hard work to emulate this and that? Go and buy wii/gc and don't
bother us with your stupid questions!"

r3927 convo:¶

Comment by Sonicadvance1, Yesterday (39 hours ago)
I guess it not working at all is better than it working better, even if it could
cause some problems

Comment by nakeee, Yesterday (37 hours ago)
hacky code is always an issue

Comment by ChaosCode, Yesterday (37 hours ago)
But it works. Its better then what they had. We can use this till someone else does
better.

Nuff said. Looks like we have here a set of "allowed" and "disallowed" hacks.
<3 double standarts and duplicity

Issue 5354 has been merged into this issue.

Issue 5379 has been merged into this issue.

I think the issue here is that lack of gamma/brightness emulation hasn't actually caused any major issues in games (and brightness sliders aren't major), so, as cool as accurate emulation is, the devs don't want to implement a feature just to have it slow games down and potentially break other things.

So, I guess we just need to find a game that's actually broken without proper gamma. :P

When does the GC do gamma correction? I don't think it's done in rendering progress, so it isn't importend for any game.
But maybe it's done on efb->xfb, so a game could use it (but I don't think so), but this easy to implement in real xfb.
Next location is XFB to screen blit, so no game is available so see the results. This is also not hard to emulate but not needed at all.

I took a quick look at this a few weeks ago and I think it is performed by BPStructs.cpp in this section:

// ----------------------------------
// Display Copy Filtering Control - GX_SetCopyFilter(u8 aa,u8 sample_pattern[12][2],u8 vf,u8 vfilter[7])
// Fields: Destination, Frame2Field, Gamma, Source
// ----------------------------------
case BPMEM_DISPLAYCOPYFILER:   // if (aa) { use sample_pattern } else { use 666666 }
case BPMEM_DISPLAYCOPYFILER+1: // if (aa) { use sample_pattern } else { use 666666 }
case BPMEM_DISPLAYCOPYFILER+2: // if (aa) { use sample_pattern } else { use 666666 }
case BPMEM_DISPLAYCOPYFILER+3: // if (aa) { use sample_pattern } else { use 666666 }
case BPMEM_COPYFILTER0:        // if (vf) { use vfilter } else { use 595000 }
case BPMEM_COPYFILTER1:        // if (vf) { use vfilter } else { use 000015 }

Specifically the COPYFILTER0 and COPYFILTER1. The next step would have been to write a quick test program on real hardware but I haven't found the time for that.

Copy filtering is used for antialiasing, only, and irrelevant for gamma correction. As far as I know, the register values are completely ignored unless AA is enabled.

The BPMEM_TRIGGER_EFB_COPY setting has a field for gamma correction; the GC GPU only supports three possible gamma correction coefficients (1.0, 1.7 and 2.2).

I think I need to correct myself a bit: The DISPLAYCOPYFILTER registers are the ones which are used for AA only; COPYFILTER is likely used for EFB->XFB copies (since vertical stretching is done there). I don't recall having any gamma field in those registers, however.

From what I could see, the Resident Evil games have enabled AA as they allowed a user configurable gamma setting of 0 to 255 (iirc?). I am aware of the three value EFB COPY one though - it isn't used by the game in this issue.

If that is indeed true, it would be greatly helpful two have a few fifo logs, each recorded in the same scene but with a different gamma setting. Three logs would be sufficient I guess - using the highest setting, the lowest setting and the default setting (or the "medium" setting if default was one of the former two).

CC JMC? :)

I've seen gamma work in other games, but it indeed doesn't function here. fifologs will work for this, then you shall get fifologs.

https://dl.dropboxusercontent.com/u/484730/ResidentEvil4Brightness.7z

Here ya go.

Confirmed, BPMEM_COPYFILTER0/1 is changing when you adjust the gamma.

I've implemented this for video software in PR 3845.

It's been tested and the brightness slider works. A hardware implementation will follow.