https://bugs.dolphin-emu.org/https://bugs.dolphin-emu.org/favicon.ico?12009-03-20T13:36:44ZDolphin bug trackerEmulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=6666142009-03-20T13:36:44ZTTnickTTTTnickTT@gmail.com
<ul></ul><p>did you try putting your screen gamma higher or your main gamma from windows/linux/mac.</p>
Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=6666152009-03-21T21:01:14Zzantezukenzantezuken@gmail.com
<ul></ul><p>Lol, yes, of course. It was the first thing which i'd tried.<br>
Obvious, isn't?</p>
Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=6666162009-04-07T14:46:23Zomegadoxomegadox@gmail.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Accepted</i></li></ul><p>Prolly doesn't work because this might be something we have to implement. I know<br>
copy EFB on the real HW can apply gamma to the image which we don't do in Dolphin.</p>
Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=6666172009-05-02T13:59:48ZXTra.KrazzYXTra.KrazzY@gmail.com
<ul><li><strong>Status</strong> changed from <i>Accepted</i> to <i>Questionable</i></li></ul><p>A little bit of information here:</p>
<p>Copying from the EFB to the XFB can include filtering on the way. Those filters (from<br>
what we know) are only gamma correction.</p>
<p>I don't really know whether this is a feature that we actually need to emulate.</p>
Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=6666182009-05-03T04:39:19Zzantezukenzantezuken@gmail.com
<ul></ul><p>Strange question... Dolphin is an <u>emulator</u>, right?<br>
May be I did miss something...</p>
Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=6666192009-05-03T04:46:34Zdeath2droiddeath2droid@gmail.com
<ul></ul><p>Yes dolphin is a emulator!</p>
Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=6666202009-05-09T13:16:58ZXTra.KrazzYXTra.KrazzY@gmail.com
<ul></ul><p>zantezuken: Imagine even MORE lines of code executing between each frame. It can<br>
severely slow down the emulation.</p>
Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=6666212009-05-09T13:17:25ZXTra.KrazzYXTra.KrazzY@gmail.com
<ul></ul><p>Change your gamma settings inside the GFX card driver, dammit.</p>
Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=6666222009-05-26T07:35:04ZXTra.KrazzYXTra.KrazzY@gmail.com
<ul><li><strong>Status</strong> changed from <i>Questionable</i> to <i>Won't fix</i></li></ul> Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=6666232009-06-04T14:25:16Zzantezukenzantezuken@gmail.com
<ul></ul><p>Great solution. Now we just wait for the times when we NEED to use a hacked GFX <br>
drivers with Dolphin.<br>
Nice way for emulation progress, indeed.</p>
Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=6666242009-06-04T14:31:26Zdeath2droiddeath2droid@gmail.com
<ul></ul><p>Why would you need hacked GFX drivers XD<br>
Dolphin runs fine and the Gamma thing isn't even a real problem.</p>
Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=6666252009-06-22T21:39:25Zzantezukenzantezuken@gmail.com
<ul></ul><p>You miss the point. I was being sarcastic about emulation way (if we can call that <br>
way an "emulation") of Dolphin.<br>
It is like:<br>
"Why do we need to proper emulate videosystem? Better to change gamma settings in <br>
drivers!"<br>
and more:<br>
"Why do we need to hard work to emulate this and that? Go and buy wii/gc and don't <br>
bother us with your stupid questions!"</p>
Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=6666262009-08-04T01:06:22Zzantezukenzantezuken@gmail.com
<ul></ul><a name="r3927-convo"></a>
<h1 >r3927 convo:<a href="#r3927-convo" class="wiki-anchor">¶</a></h1>
<p>Comment by Sonicadvance1, Yesterday (39 hours ago) <br>
I guess it not working at all is better than it working better, even if it could </p>
<a name="cause-some-problems"></a>
<h2 >cause some problems<a href="#cause-some-problems" class="wiki-anchor">¶</a></h2>
<p>Comment by nakeee, Yesterday (37 hours ago) </p>
<a name="hacky-code-is-always-an-issue"></a>
<h2 >hacky code is always an issue<a href="#hacky-code-is-always-an-issue" class="wiki-anchor">¶</a></h2>
<p>Comment by ChaosCode, Yesterday (37 hours ago) <br>
But it works. Its better then what they had. We can use this till someone else does </p>
<a name="better"></a>
<h1 >better.<a href="#better" class="wiki-anchor">¶</a></h1>
<p>Nuff said. Looks like we have here a set of "allowed" and "disallowed" hacks.<br>
<3 double standarts and duplicity</p>
Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=6666272012-04-09T22:57:55Zskidau
<ul><li><strong>Status</strong> changed from <i>Won't fix</i> to <i>Accepted</i></li></ul> Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=6666282012-04-09T22:58:32Zskidau
<ul></ul><p>Issue 5354 has been merged into this issue.</p>
Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=6666292012-12-14T18:48:45ZSonicadvance1Sonicadvance1@gmail.com
<ul></ul><p>Issue 5379 has been merged into this issue.</p>
Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=6666302013-04-10T01:55:33ZBilliard26jordan.woyak@gmail.com
<ul><li><strong>Issue type</strong> set to <i>Bug</i></li></ul> Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=6666312013-04-10T12:19:44Zpauldacheezpauldacheez@gmail.com
<ul></ul><p>I think the issue here is that lack of gamma/brightness emulation hasn't actually caused any major issues in games (and brightness sliders aren't major), so, as cool as accurate emulation is, the devs don't want to implement a feature just to have it slow games down and potentially break other things.</p>
<p>So, I guess we just need to find a game that's actually broken without proper gamma. :P</p>
Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=6666322013-04-10T12:26:30Zdegasuswickmarkus86@gmail.com
<ul></ul><p>When does the GC do gamma correction? I don't think it's done in rendering progress, so it isn't importend for any game.<br>
But maybe it's done on efb->xfb, so a game <u>could</u> use it (but I don't think so), but this easy to implement in real xfb.<br>
Next location is XFB to screen blit, so no game is available so see the results. This is also not hard to emulate but not needed at all.</p>
Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=6666332013-04-10T12:55:27Zskidau
<ul></ul><p>I took a quick look at this a few weeks ago and I think it is performed by BPStructs.cpp in this section:</p>
<pre><code>// ----------------------------------
// Display Copy Filtering Control - GX_SetCopyFilter(u8 aa,u8 sample_pattern[12][2],u8 vf,u8 vfilter[7])
// Fields: Destination, Frame2Field, Gamma, Source
// ----------------------------------
case BPMEM_DISPLAYCOPYFILER: // if (aa) { use sample_pattern } else { use 666666 }
case BPMEM_DISPLAYCOPYFILER+1: // if (aa) { use sample_pattern } else { use 666666 }
case BPMEM_DISPLAYCOPYFILER+2: // if (aa) { use sample_pattern } else { use 666666 }
case BPMEM_DISPLAYCOPYFILER+3: // if (aa) { use sample_pattern } else { use 666666 }
case BPMEM_COPYFILTER0: // if (vf) { use vfilter } else { use 595000 }
case BPMEM_COPYFILTER1: // if (vf) { use vfilter } else { use 000015 }
</code></pre>
<p>Specifically the COPYFILTER0 and COPYFILTER1. The next step would have been to write a quick test program on real hardware but I haven't found the time for that.</p>
Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=6666342013-04-10T12:59:20ZNeoBrainXNeoBrainX@gmail.com
<ul></ul><p>Copy filtering is used for antialiasing, only, and irrelevant for gamma correction. As far as I know, the register values are completely ignored unless AA is enabled.</p>
<p>The BPMEM_TRIGGER_EFB_COPY setting has a field for gamma correction; the GC GPU only supports three possible gamma correction coefficients (1.0, 1.7 and 2.2).</p>
Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=6666352013-04-10T13:03:02ZNeoBrainXNeoBrainX@gmail.com
<ul></ul><p>I think I need to correct myself a bit: The DISPLAYCOPYFILTER registers are the ones which are used for AA only; COPYFILTER is likely used for EFB->XFB copies (since vertical stretching is done there). I don't recall having any gamma field in those registers, however.</p>
Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=6666362013-04-10T13:06:59Zskidau
<ul></ul><p>From what I could see, the Resident Evil games have enabled AA as they allowed a user configurable gamma setting of 0 to 255 (iirc?). I am aware of the three value EFB COPY one though - it isn't used by the game in this issue.</p>
Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=6666372014-04-25T18:41:49ZNeoBrainXNeoBrainX@gmail.com
<ul></ul><p>If that is indeed true, it would be greatly helpful two have a few fifo logs, each recorded in the same scene but with a different gamma setting. Three logs would be sufficient I guess - using the highest setting, the lowest setting and the default setting (or the "medium" setting if default was one of the former two).</p>
<p>CC JMC? :)</p>
Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=6666382014-04-25T21:07:49ZJMC4789JMC4789@gmail.com
<ul></ul><p>I've seen gamma work in other games, but it indeed doesn't function here. fifologs will work for this, then you shall get fifologs.</p>
Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=6666392014-04-25T21:28:37ZJMC4789JMC4789@gmail.com
<ul></ul><p><a href="https://dl.dropboxusercontent.com/u/484730/ResidentEvil4Brightness.7z" class="external">https://dl.dropboxusercontent.com/u/484730/ResidentEvil4Brightness.7z</a></p>
<p>Here ya go.</p>
Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=7212492015-09-04T06:17:08Zphirephiren@gmail.com
<ul><li><strong>Assignee</strong> set to <i>phire</i></li></ul><p>It occurs to me that a game could abusing the AA/Deflicker filtering to implement a brightness filter during the EFB to XFB copy. It is intended that games would use filter coefficients that add up to 100%, but if a game was to use coefficients that added up to less than 100% you would get a less-bright image.</p>
<p>I need to test this theory.</p>
Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=7212622015-09-05T15:17:48Zphirephiren@gmail.com
<ul></ul><p>Confirmed, BPMEM_COPYFILTER0/1 is changing when you adjust the gamma.</p>
Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=7250872016-05-18T04:18:02Zphirephiren@gmail.com
<ul></ul><p>I've implemented this for video software in <a href="https://github.com/dolphin-emu/dolphin/pull/3845" class="external">PR 3845</a>.</p>
<p>It's been tested and the brightness slider works. A hardware implementation will follow.</p>
Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=7328122018-05-01T09:45:57Zleoetlino
<ul><li><strong>Status</strong> changed from <i>Accepted</i> to <i>Fixed</i></li><li><strong>Fixed in</strong> set to <i>5.0-7151</i></li></ul> Emulator - Emulator Issues #726: Gamma setting has no effecthttps://bugs.dolphin-emu.org/issues/726?journal_id=7444522022-07-16T01:58:13Zpokechu22
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-1 priority-2 priority-default" href="/issues/12974">Emulator Issues #12974</a>: Brightness controls do not work in some games</i> added</li></ul>