Project

General

Profile

Actions

Emulator Issues #7262

closed

Android: Lack of git command causes revision string to be blank

Added by SeannyM almost 10 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
Android
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Game Name?
N/A

Game ID?
N/A

What's the problem? Describe what went wrong in few words.
When compiling for Android, the git command cannot be found. (missing GIT_EXECUTABLE) This becomes a problem when during compile scmrev.h is created which holds values obtained by using git. All the values are written as blank because the values can't be retrieved. Because of this, scm_rev_str outputs "Dolphin []" since SCM_BRANCH_STR is blank.

What did you expect to happen instead?
The git executable should be able to be found so the values are obtained.

What steps will reproduce the problem?

  1. Download latest Dolphin source through git
  2. Compile for Android

Dolphin 3.5 and 3.5-367 are old versions of Dolphin that have
known issues and bugs, so don't report issues about them and test the
latest Dolphin version first.
Which versions of Dolphin did you test on?
N/A

Does using an older version of Dolphin solve your issue? If yes, which
versions of Dolphin used to work?
N/A

What are your PC specifications? (including, but not limited to: Operating
System, CPU and GPU)
Tried compiling on Mac OS X and Ubuntu

Are you using the 32 or the 64 bit version of Dolphin?
N/A

Is there any other relevant information? (e.g. logs, screenshots,
configuration files)
No.

Actions #1

Updated by MayImilae almost 10 years ago

  • Operating system Android added
Actions #2

Updated by Sonicadvance1 almost 10 years ago

You've got to make sure to pass in the location of git to cmake via the -DGIT_EXECUTABLE=/usr/bin/git option.

Actions #3

Updated by SeannyM almost 10 years ago

I know how to fix it when manually compiling, but the thing is in the buildbot builds it does not do this. Maybe the buildbot could be reconfigured to do this before cmake command.

Actions #4

Updated by Sonicadvance1 almost 10 years ago

Oh, this must have been changed by accident on the builtbot. I'll prod Matt_P about it.

Actions #5

Updated by Sonicadvance1 almost 10 years ago

  • Status changed from New to Fixed

Buildbot is now fixed with this.

Actions

Also available in: Atom PDF