Emulator

Can you find the exact build where the behavior changes?

I'll be doing tests tomorrow to find the build in which the behavior changes, though it might take some time.

I found it after doing some testing: In build 4.0-1494 the bug is still taking its old form (http://i.imgur.com/ZPIyRdy.png) where the first few cups are working properly while the later cups have the wrong icons and are filled with copies of Mario Circuit, while build 4.0-1503 introduces the new form of the bug (http://i.imgur.com/1xzOWTa.png) where all of them have the wrong icon and only four cups are selectable, the scrolling function doesn't work. The newer-ppcanalyst changes that Sonicadvance1 made should thus be relevant to this bug in some form.

To summarize:

List of the expected tracks/cups

• http://wiki.tockdom.com/wiki/Wiimms_Mario_Kart_Retro_2014-02#Tracks

Real Wii

• Everything works correctly

Dolphin with JITIL recompiler

• Everything works correctly

Dolphin with JIT recompiler

• In build 4.0-1494 and older the first few cups appear correctly, while the later cups have the wrong icons and are filled with duplicates of the track Mario Circuit
• In build 4.0-1503 and newer all the cups have the wrong icons and only four cups are selectable, you can't scroll to the other cups

I completely forgot about a related bug, and I retract my earlier statement about everything working correctly with the JITIL recompiler.

The tracks/cups do indeed show up properly with the JITIL recompiler, but only before you've completed a race. After you've done so and use the "Next race" option all the new cups disappear, leaving you with only the standard Mario Kart Wii cups. To get the extra cups back you have to leave and reenter VS mode entirely every time you complete a race, which is quite the hassle. Again this is something that doesn't happen if you play the patch on a real Wii.

My updated summary is thus as follows:

List of the expected tracks/cups

• http://wiki.tockdom.com/wiki/Wiimms_Mario_Kart_Retro_2014-02#Tracks

Real Wii

• Everything works correctly

Dolphin with JITIL recompiler

• Everything initially works correctly, but after completing a race and using the "Next Race" option the cup selection shrinks to just the cups found in the original Mario Kart Wii. To get the extra cups back you have to leave and reenter VS mode entirely

Dolphin with JIT recompiler

• In build 4.0-1494 and older the first few cups appear correctly, while the later cups have the wrong icons and are filled with duplicates of the track Mario Circuit
• In build 4.0-1503 and newer all the cups have the wrong icons and only four cups are selectable, you can't scroll to the other cups

I'm sorry about the confusion, my summary should be correct this time though.

Can it be checked in the latest builds? 4.0-1706 fixes some JIT problems, should at least make JIT and JITIL act the same.

It won't fix any PPC_Analyst problems, though.

I tested 4.0-1711 today both with JIT and JITIL, I noted no change in behavior for either.

Does interpreter behave the same way?

I was afraid you were going to ask that, I'm hovering between 0 and 2 FPS with interpreter... :P

The initial cup and track selection is at least working properly (http://i.imgur.com/fTRugjj.png). I'll leave a race on tonight, hopefully the CPU will be finished by tomorrow so I can check whether the cups also appear correctly after using the "Next Race" option.

thetheiala: I'm sorry I didn't explain things. But, you can load a cup on JITIL, go all the way to the end of the race, and right before it goes to the menu, you can savestate, close the game, switch to interpreter, and then load the game, load the savestate, and that'll work.

You're a smart guy, you know that?

Unfortunately the cup selection resets to just the standard Wii cups after using "Next Race", in other words interpreter has the same behavior as JITIL.

So, JIT is more broken than both Interpreter and JITIL? That actually narrows down the culprit quite a bit. Please let me know!

I'm going to actually download and set this up on my other computer so I can help out directly.

Thanks for your help in narrowing it down this far, hopefully I'll be able to bring you some answers within a week or so.

That's correct.

With JITIL and interpreter the initial cup selection works properly, but after completing a track in VS mode and using the "Next Race" option all the bonus cups disappear.

With JIT the initial cup selection is also bugged, with the cups being completely scrambled in 4.0-1503 or newer (http://i.imgur.com/1xzOWTa.png) or some of the cups being filled with copies of Mario Circuit in 4.0-1494 and older (http://i.imgur.com/ZPIyRdy.png).

Give me a heads up if you need help patching the ISO. :)

So, even before the PPC_Analyst merge, JIT was broken differently/more than Interpreter and JITIL? Interpreter and JITIL have the exact same output?

Sorry if I keep repeating this, but I wanna make sure I don't have any misconceptions by the time the patcher downloads. I'm going to dig in, hopefully narrow down what function is messed up, and hopefully it will get fixed. The goal isn't just to make JIT less broken; we also would like to make it act like Wii.

Just for verification purposes, is there any way you could load the patched ISO (the same one you use for Dolphin) onto your Wii (if you have one) and verify it works there? I know that's a bit to ask, but it'll save me time to know that it works on hardware. Thanks.

JIT was indeed behaving differently than JITIL and interpreter before the PPC_Analyst merge, and continues to do so after. Interpreter and JITIL are giving the same results.

My real Wii is unfortunately several hundred kilometers away currently, the best thing I can do on short notice is to provide a Youtube video. I couldn't find any relevant videos of Mario Kart Retro, but here's one of CTGP Revolution: https://www.youtube.com/watch?v=4vcPfrka4k0#t=297 You can see the added cups still being there after using the "Next Race" option on a real Wii.

Some quick background information on why CTGP is relevant to this case: Mario Kart custom mods could previously only replace tracks in the 8 default cups, not add new cups. CTGP Revolution was the first custom mod that made adding more cups possible by modifying the main.dol file of Mario Kart Wii. Mario Kart Retro is based on the same code, they differ only in the selection of tracks. They thus function the same on both a real Wii and on Dolphin (CTGP Rev produces all the same bugs as Mario Kart Fun on Dolphin).

Well, this is enough information for me to start debugging. I've confirmed the issue.

Here's a link to the very same issues being described on the Mario Kart forums (the main place for discussing Mario Kart fan mods) a year ago: http://www.mariokartwii.com/threads/115972-CTGP-on-Dolphin Notice the third post especially.
I know it goes even further back than that as well, but that's buried in a more than 1000 pages long thread about CTGP Revolution. I ain't searching through that, at least not at 5AM. :P

So, I was right and wrong.

I was right that JIT should act like JITIL/Interpreter as of 4.0-1706; it's just the PPC_Analyzer change has messed with that. Disabling the PPC_Analyzer makes it so 1706 and newer work just like JITIL And Interpreter. Unfortunately, that means we have no leads on why it's forgetting the new tracks are there after one race.

To really get a good jump on this, we'd need to know what the game is doing on the inside; if Wiimm would let us see the source code, or maybe even just explain how it adds the extra cups or something, that'd probably be the easiest way to get this fixed. Past that, it's going to be blind guesses at what's going wrong. And due to the fact that none of his projects are open source, I don't know if he'll be willing to give any inside information on it.

If that ends the second bug (Only basic 8 cups existing after a vs race) may not be fixed for quite a while. Best bets to getting this fixed quickly would be going to them and seeing if they'd be willing to tell us how it works.

The old version of CTGP is open source.
http://wiki.tockdom.com/wiki/CTGP_Revolution
https://github.com/Chadderz121/wii-ct-code

Does that one have the glitch in it? If so, we'll investigate.

Quickly skimming it says it'll be useful, but I just want to know before I get too excited.

I'm pretty sure I read somewhere that CTGPR wouldn't share all their code regarding the bonus cups, so Wiimm had to reverse engineer parts of it for his own project. He is probably the most knowledgeable person there is when it comes to stuff like this and has always been giving a lot back to the community, so he would be my best bet if you can't find the needed information in the source code posted above.

He might be a bit busy these days with the Wiimmfi Server project though, replacing the official Nintendo WFC servers for Mario Kart when they shut down (http://www.mariokartwii.com/threads/134892-MKWii-Server-Project). Still wouldn't hurt to ask.

Issue 7303 has been merged into this issue.

Yes,the same problem exists in the CTGP old version.After "Next Race",you can only see the official track.

I get the same problem on ctgp and the wiimms fun pack

Any solution to this problem? The same thing happens to me when I use dolphin 4.02 but when i use dolphin 3.5 after I play a race most of the custom cups dissapear but not all of them. Another thing is that in dolphin 3.5 the game runs better, at least that is my experience on my pc.

Hey guys has there been any progress with this issue? The custom tracks are fun but having to quit VS and enter all information again just to play another race really takes some of that fun away.

Hey guys has there been any progress with this issue? ???

some dev said somewhere that CTGP patch relies on a very difficult to emulate feature of the Wii. The Wii has a code cache or something which must be flushed when code is modified. CTGP patch modifies code, then runs the code and expects the old code to be run. It is difficult to emulate in Dolphin, the exact behavior of which code gets kept and discarded in the cache. Or it's too slow, or something.

Again, I'm not a dev.

This branch adds a primitive icache emulation feature for the JIT. Enable it in game opions and this hack should work: https://github.com/FioraAeterna/dolphin/tree/icache2

Downside: ~2.5x slower on my machine

Also, for posterity, this commit in the branch https://github.com/FioraAeterna/dolphin/commit/fc688fc83c74ea4734f50dc54954896cd9ba27e2 emulates the full icache logic, rather than the above branch which emulates a zero-icache. It's another 2-3x slower, so unlike the previous branch, it's not really feasible for real use, at least not at the moment.

Oh right, I should note that branch will only work on CPUs with SSE4.2 because I really didn't make the code generic yet...

Hey, is there a newbie version of dolphin to download ?

I tried using Visual studio 2013
"Use the solution file Source/dolphin-emu.sln to build Dolphin on Windows. Visual Studio 2013 is a hard requirement since previous versions don't support many C++ features that we use. Other compilers might be able to build Dolphin on Windows but have not been tested and are not recommended to be used."

But i get an error:
like in the atachment

help?

I've never ran into that error and can't really help you, unfortunately.

I mean, can't you send me this version of dolphin, but already compilled ?

hey! can you please upload the compiled version of that dolphin that emulates the icache logic? thanks in advance!

Is the icache logic emulator only for the interpreter? Also is there any version of this compiled.

can someone send me the compiled version please, i can't build it, thanks xavi.palou.r@gmail.com

Hello,

Are you still working on this problem ?
I have the same issue.

Best was to play actualy is to choose random track to avoid this section.

Well, it seems that random mode avoids extra cups so we can't play mario kart fun add-on with dolphin :(

Get them to modify the patch to manually invalidate the icache; this is not going to be fixed without a huge speed down (3x - 4x slower than it is now)

I don't understand, what i have to get to modify the patch ?

Old patch is open-source, new patch is DRMed and locked down so it won't work on Dolphin.

What is the Last patch working with dolphin please ?

Why don't you go ask them?

I think this is a case of users using Dolphin making things hard on whoever is developing the hack (as it's used for online play.) I don't want to cause them any more trouble if they don't want it running on Dolphin, and at the same time, I have no real desire to run it. In the end, they'll just keep modifying it not to work on Dolphin if that's the case, and eventually they'll win.

The other case is that something they did simply doesn't work on Dolphin, and that it'll randomly get fixed someday.

So this wont be fixed and there is no way to fix it manually right?

Dynamic BAT was merged in #4146 (https://github.com/dolphin-emu/dolphin/pull/4146). Is this fixed now?

Any news on this guys? The only the basic 8 cups existing after a vs race bug is still present even on the latest wiim tracks patch and latest dolphin dev as of January 15 2019.

We can't fix this without making Dolphin much slower, so we aren't really able to do anything about the problem. The only way to fix it without significant trade-offs is by changing how the patch works, but I guess the author of the patch doesn't want to do that.

Nevermind, the latest patch from here (download the most recent on the last row):
http://wiki.tockdom.com/wiki/Wiimms_Mario_Kart_Fun

actually fixes the bug playing on dolphin, so they changed the patch after all.

Yeah, the Wiimm's people are fine with Dolphin, it was just an oversight.

Spoke too soon, I had to repatch my vanilla iso again because the custom tracks names were wrong because I replaced all the files in the scene/UI extracted iso folder because of my custom characters but with the new correct patching the bug of only the default tracks being available after the first race is back, it seems I just stumbled upon a potential solution to the bug, maybe the bug didn't have anything to do with icache emulation? Any ideas?

It is icache emulation for sure if it works on interpreter. It works on interpreter for me on every build.

If it's still broken for you (latest Wiimms wasn't for me,) it's an unintentional reliance on icache on their end somewhere. There's nothing we can do to fix this outside of completely murdering performance.

Managed to reproduce it and fix it again by replacing the scene folder again, I am using wiims custom tracks latest patch 2018-12-22, just patched a new iso and when the patch asks you if you want to translate and reorder the tracks after translation this time I selected no on both, then I just copied the scene folder from the previous patched iso that had those options on yes and for some reason the bug is gone now, pretty weird but hey it works now.

Forget all that I finally figured it out, the 60fps for multiplayer gecko code was the one causing the bug of the custom tracks not been selectable after the first race for some reason, a shame because 60 fps for more than 2 local players would be awesome with custom tracks.

This is the code I am talking about
Mario Kart Wii
$60FPS in Multiplayer [Nick Reynolds]
004250D4 00000001
0029FD69 00000000

Strange that it causes the same exact bug described in this issue.

blackman91 wrote:

This is the code I am talking about
Mario Kart Wii
$60FPS in Multiplayer [Nick Reynolds]
004250D4 00000001
0029FD69 00000000

Strange that it causes the same exact bug described in this issue.

Edit: I works if you use it as an AR code instead of gecko, finally everything is perfect now.

Hey blackman91, so did you actually manage to play a 2nd race in vs mode with all custom tracks shown? If yes, could you please explain how to do it or what kind of code must be altered?

thanks a lot
Kostas