Project

General

Profile

Emulator Issues #7298

Zelda TP doesn't crash if you try to throw a sign after dropping it with JIT

Added by rachelbryk over 5 years ago. Updated about 3 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
5.0-540

Description

Game Name?
Zelda Twilight princess

Game ID?
GZ2E01

What's the problem? Describe what went wrong in few words.

If you break a sign into small pieces so you hold it in one hand, then use a bottle, you will drop the sign, but pressing A while running will still allow you to throw it. If you do so, the game should crash. In dolphin, with JIT, the game does not crash.

What did you expect to happen instead?

I expected the game to crash.

What steps will reproduce the problem?
1. Break a sign
2. Pick up the piece, and break it again
3. Pick up one of the smaller pieces
4. use a bottle, and drop the sign piece
5. start to run, then press a

Which versions of Dolphin did you test on?

4.0-1603, and 3.0-590

Is there any other relevant information? (e.g. logs, screenshots,
configuration files)

It works as expected in interpreter, and crashes. The issue is present in both JIT and JITIL.

History

#1 Updated by delroth over 5 years ago

Any log messages?

#2 Updated by rachelbryk over 5 years ago

nope

#3 Updated by delroth over 5 years ago

Could you provide the exception message you get in the logs when
reproducing the crash in interpreter mode?

#4 Updated by rachelbryk over 5 years ago

Oh duh. Interpreter. Sorry. 48:14:966 HW\Memmap.cpp:345 E[MI]: Unknown Pointer 0x40000000 PC 0x40000000 LR 0x40000000

#5 Updated by phire over 5 years ago

Looks like that log message can only be reached if TLBHack is disabled.

#7 Updated by JMC4789 about 3 years ago

  • Status changed from Accepted to Fix pending

This crash works properly in Dynamic BATs with MMU enabled with no performance penalty to the game in general.

https://github.com/dolphin-emu/dolphin/pull/4146

#8 Updated by JosJuice about 3 years ago

  • Status changed from Fix pending to Fixed
  • Fixed in set to 5.0-540

Also available in: Atom PDF