Project

General

Profile

Actions

Emulator Issues #7333

closed

Add Twilight Princess Speedhack Codes to Twilight Princess INI files.

Added by JMC4789 almost 10 years ago.

Status:
Fixed
Priority:
High
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

This basically replaced the removed Twilight Princess Hack without having nasty code in the emulator. Stole this from skid's posts on the forums.

This is important because it validates removing the TP speedhack from the actual emulator code.

GameCube NTSC-U
GZ2E01.ini
-----------------cut here--------------------------
[OnFrame]
$Hyrule Field Speed Hack
0x8003D50C:dword:0x60000000
0x8003D528:dword:0x60000000
0x8003D540:dword:0x60000000
0x8003D55C:dword:0x60000000
0x8003D5B8:dword:0x60000000
0x8003D5D4:dword:0x60000000
0x8003D5EC:dword:0x60000000
0x8003D608:dword:0x60000000
[OnFrame_Enabled]
$Hyrule Field Speed Hack
-----------------cut here--------------------------

Wii NTSC-U
RZDE01.ini
-----------------cut here--------------------------
[OnFrame]
$Hyrule Field Speed Hack
0x80040DE8:dword:0x60000000
0x80040E04:dword:0x60000000
0x80040E1C:dword:0x60000000
0x80040E38:dword:0x60000000
0x80040E90:dword:0x60000000
0x80040EAC:dword:0x60000000
0x80040EC4:dword:0x60000000
0x80040EE0:dword:0x60000000
[OnFrame_Enabled]
$Hyrule Field Speed Hack
-----------------cut here--------------------------

GameCube PAL
GZ2P01.ini
-----------------cut here--------------------------
[OnFrame]
$Hyrule Field Speed Hack
0x8003d63c:dword:0x60000000
0x8003d658:dword:0x60000000
0x8003d670:dword:0x60000000
0x8003d68c:dword:0x60000000
0x8003d6e8:dword:0x60000000
0x8003d704:dword:0x60000000
0x8003d71c:dword:0x60000000
0x8003d738:dword:0x60000000
[OnFrame_Enabled]
$Hyrule Field Speed Hack
-----------------cut here--------------------------

Wii PAL
RZDP01.ini
-----------------cut here--------------------------
[OnFrame]
$Hyrule Field Speed Hack
0x80040eb4:dword:0x60000000
0x80040ed0:dword:0x60000000
0x80040ee8:dword:0x60000000
0x80040f04:dword:0x60000000
0x80040f5c:dword:0x60000000
0x80040f78:dword:0x60000000
0x80040f90:dword:0x60000000
0x80040fac:dword:0x60000000
[OnFrame_Enabled]
$Hyrule Field Speed Hack
-----------------cut here--------------------------

Actions #1

Updated by kostamarino almost 10 years ago

JMC could you do me a favor and try to test one whether they bring a speedup and work as intended (i don't have a hyrule field save)? I also wonder whether these work by default (for example if you don't have cheats enabled in the general config).

Actions #2

Updated by JMC4789 almost 10 years ago

I tested the GC and Wii NTSC, and Skid tested the PAL ones.

They do work as intended; D3D still needs more help but OGL with Bufferstorage will work fine.

There's been some argument to the name. I think degasus wanted to call it Minimap Speedhack or something alone those lines.

Also, due to a bug in Global User Directory, the enabled thing doesn't matter at all. Users will still have to enable it manually. Cheats do NOT have to be enabled for the patch to activate, though.

Actions #3

Updated by kostamarino almost 10 years ago

I think that the line [OnFrame_Enabled] only works if put in your local and not general gameinis and it was due to a limitation delroth put. I remember it because the Monster Hunter 3 bloom removal onframe patch didn't work after the merge and it was on purpose.

Actions #4

Updated by JMC4789 almost 10 years ago

Ah, it may not be a bug then. Was just repeating what was said on IRC.

Actions #5

Updated by kostamarino almost 10 years ago

Therefore as things stand, if put in the gameini the above codes won't work by default unless the user enables them manually in their local gameini. So should they still be put in the database?

Actions #6

Updated by Autoran1 almost 10 years ago

Just some tests on old builds
D3D:
ZTP Hack 38 fps
This speedhack 55 fps
besides with this hack on D3D map works fine with filtering options, no LineShader issue

Actions #7

Updated by JMC4789 almost 10 years ago

Kostamarino: I think so? Going into game properties and enabling a patch is a lot easier than making users enter it in on their own.

Actions #8

Updated by kostamarino almost 10 years ago

Ok i have an active pr about ini files and make a commit there. But i think they should also be put in the Wiki for people to have wider access to the info.

Actions #9

Updated by JMC4789 almost 10 years ago

Already talked to MaJoR about it, definitely will go into the Wiki :)

Actions #10

Updated by kostamarino almost 10 years ago

Ok the commit is up, now you will have to wait for the pr to be merged :-).

Actions #11

Updated by JMC4789 almost 10 years ago

  • Status changed from New to Fixed

Thanks, fixed by 4.0-1767. The Twilight Princess Hack talk can finally be put to rest.

https://dolphin-emu.org/download/dev/31eedb2f79318002a4772087f96eb034f94787a1/

Actions #12

Updated by ben.corbett90 over 9 years ago

Holy Fuck it works!!!! Very nice!

Actions #13

Updated by hardsoftpc about 9 years ago

I dont see any better performance, and i already added the code to the ini file, help me

Actions

Also available in: Atom PDF