Project

General

Profile

Actions

Emulator Issues #7431

closed

Problems with the gci folder feature.

Added by kostamarino almost 10 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Below is the original conversation related to the issues.

Linktothepast commented 11 hours ago

I am getting in various tmnt games using the gci folder the message that the card is full, see link below:
http://prntscr.com/3xgqxq
JMC47
JMC47 commented 10 hours ago

I'm not able to reproduce in the GameCube Teenage Mutant Ninja Turtles game (GTFEA4)
Linktothepast
Linktothepast commented 10 hours ago

@JMC47 try:
TMNT:Mutant Melee GE5EA4
TMNT™2 BATTLE NEXUS™ GNIEA4
TMNT®3 MUTANT NIGHTMARE™ G3QEA4
JMC47
JMC47 commented 10 hours ago

I don't have those games unfortunately. I'm guessing you're right about this; that's why this isn't enabled by default. It's probably with the original build though, not this one.
Linktothepast
Linktothepast commented 10 hours ago

Also another issue, in Lord of the rings the two towers if i make a second save or even just overwrite a previous one and restart i get an error message that 69-GLOP-LOTRTTGameData0.gci has the same internal name as 69-GLOP-LOTRTTGameData.gci and could not be loaded.
LPFaint99
LPFaint99 commented 10 hours ago
I assume these work with a regular memory card? There is an ini setting that changes it to a smaller card, I'll need to get to a computer and look that up

LPFaint99
LPFaint99 commented 10 hours ago
Are you touching the gci goes directly in this description? Or just referring to in game overwriting?

Linktothepast
Linktothepast commented 9 hours ago

By overwritting an existing save ingame it creates a new gci file that gives the error message above that it couldn't be loaded because they have the same internal name.
LPFaint99
LPFaint99 commented 4 hours ago

we should track this on the issue tracker, for tmnt try adding the following to the gameini
[Core]
MemoryCard251 = True
example
LPFaint99@c7faf2b

for two towers can you use the regular memorycard (move yours to somewhere safe)
save and overwrite/ whatever you are doing with gci folder, and send me the memcard,
if possible a copy of the memorycard after each save
I don't have the mentioned games, I suspect I can identify the issue with LOTR, but not really sure what is going on with tmnt
JMC47
JMC47 commented 2 hours ago

I hate to spam this more, but fifologs have a similar issue. Fifologs should not require memory cards to be loaded at all, but it does the whole sysmenu + pal glitch you fixed.

Actions #1

Updated by kostamarino almost 10 years ago

Tmnt pops up an error message that there are not enough free blocks in the virtual memory card when i tried the above gameini option and it didn't work.

Initial save for two towers (memory card)https://www.mediafire.com/?adgj8pu862xjmwu
After overwriting http://www.mediafire.com/download/6attzfwcxnpo2rz/After_overwriting_save.7z

Actions #2

Updated by lpfaint99 almost 10 years ago

the two towers issue should be easy to fix, I just need to get a build up for testing,

kostamarino: is the error you get for tmnt a game error or a dolphin panic alert?
The screenshot from Linktothepast is exactly what would happen if there are 127 gci files in the folder (max for memcard)

I imagine I'll need to pick up a konami tmnt game in order to find the issue unless I can get more info

Actions #3

Updated by kostamarino almost 10 years ago

It is an ingame error and there are about 128 gci files in the folder. Btw kostamarino = Linktothepast.

Actions #4

Updated by JMC4789 almost 10 years ago

The sysmenu is crashing when I use GCI Folder now. Don't remember if it was doing it yesterday.

Actions #5

Updated by lpfaint99 almost 10 years ago

sys menu on start? opening memcard view? I need steps to repro
it could be unrelated?

kostamarino: can you try tmnt with an empty memcard folder?

Actions #7

Updated by JMC4789 almost 10 years ago

fifologs are still causing problems, sysmenu seems fixed.

Actions #8

Updated by kostamarino almost 10 years ago

Ok after some testing the two towers issue is gone but tmnt games still have their issue. When i tried with an empty folder after formating the card tmnt games worked fine, so it is probably related to the number of files in the folder.

Actions #9

Updated by lpfaint99 almost 10 years ago

JMC4789: did you ever remove the us gci files from the eur folder?
is running a fifolog expected to save/load with a memcard?

kostamarino: having 128 should've triggered a panic alert, and we should leave a few slots open for the game, any idea a good number of open spaces to leave as potential new saves that a game might add
ex: animal crossings uses 3 files iirc
timesplitters 2 can use an arbitrary number of course limited by the 127 files/card

Actions #10

Updated by kostamarino almost 10 years ago

I think 3 saves per game is the most common, double that (6) should be ok for most cases.

Actions #11

Updated by JMC4789 almost 10 years ago

Resident Evil can use up to 20 or something. Games like that which expect you to save a lot may need more.

There is no reason for a fifolog to be interacting with memory cards at all. It's seeing the fifolog as euro region and rejecting my NTSC saves. Just have fifologs ignore memory cards.

Actions #12

Updated by lpfaint99 almost 10 years ago

you should still clean up the eur folder of US gci files, if/when you ever play a pal game this alert would appear also
fifologs weren't ignoring memorycards before, I'm not sure I agree that it should be a special case,.

the open spots will be a balance,
I don't want to hard code which games look for specific other games saves
so just the first 127/121/107 saves (alphabetical by filename) would be loaded
but you also need to leave some room if you are playing a new game with no existing save, or a game (like TS2) that can create an arbitrary number of new profiles (each taking one of the save spots

The number shown in the game's UI isn't always the number of file entries
SMS for example has three save spots but only 1 gci file

need to identify a good balance between both demands

Actions #13

Updated by JMC4789 almost 10 years ago

lpfaint99 - Every time I delete the PAL folder and load a fifolog, it refills it with my NTSC saves.

Actions #14

Updated by lpfaint99 almost 10 years ago

Oh, that's definitely something to fix. Sorry about misunderstanding

Actions #15

Updated by JMC4789 almost 10 years ago

Wrestlemania X8 won't load saves with the current implementation in master.

Actions #16

Updated by lpfaint99 almost 10 years ago

grabbed a save from gamefaqs, looks like it has a / as part of the filename

Actions #17

Updated by JMC4789 almost 10 years ago

Sorry about all this belated testing. It's just, I'm testing the PR for "accurate memcard saves/loads" at the same time, which means I get to go through every single game again, and I figure why not with the GCI folder.

Actions #18

Updated by lpfaint99 almost 10 years ago

please test wrestlemania x8 with latest pr changes
https://dl.dolphin-emu.org/prs/pr-544-dolphin-latest-x64.7z

Actions #20

Updated by JMC4789 almost 10 years ago

Both issues fixed in the respective builds.

Actions #21

Updated by lpfaint99 almost 10 years ago

so the only remaining issue is leaving x amount of free entries on the fake memcard
Any objections to considering that a different issue and closing this one?

Actions #22

Updated by JMC4789 almost 10 years ago

This issue should get closed after the PRs are merged.

We can make a new issue for the other issues.

Actions #23

Updated by JMC4789 almost 10 years ago

Somehow I ended up with duplicate saves in F-Zero GX

I have a panic alert saying that an "longfilename"0.gci and "longfilename".gci have the same internal file name. I don't know how it happened.

Actions #24

Updated by kostamarino almost 10 years ago

JMC4789 it is the same as the issue i reported above, should be fixed by https://github.com/dolphin-emu/dolphin/pull/544

Actions #25

Updated by JMC4789 almost 10 years ago

oh ok. Need to learn to read.

Actions #26

Updated by JMC4789 almost 10 years ago

Even though I tested Tony Hawk Pro Skater 4 before, I managed to get an error when manually saving "Wrote to unallocated block" and I think it was 63, but I can't remember. And then Dolphin crashed.

Actions #27

Updated by lpfaint99 almost 10 years ago

Even though I tested Tony Hawk Pro Skater 4 before, I managed to get an error when manually saving "Wrote to unallocated block" and I think it was 63, but I can't remember. And then Dolphin crashed.

Is this with master or PR 544?

Actions #28

Updated by JMC4789 almost 10 years ago

Master, sorry. If you've already handled that, then you can ignore it. Metroid Prime does the same thing; it appears to be the saving over a save bug, which you've said you've fixed.

Actions #29

Updated by JMC4789 almost 10 years ago

LPFaint99: If I use GCI-Folder, System Menu is crashing at startup.

Actions #30

Updated by lpfaint99 almost 10 years ago

need more info, can't repro on master r 5646ffdacdc0221720369df464f0e7addbacbd6f
(4.0-2215)

Actions #31

Updated by JMC4789 almost 10 years ago

I don't know what else to say. It hangs, and when I try to click close the program from the windows error dialogue, it just doesn't close and I have to close it via task manager. Turning it on to memory cards fixes it.

Actions #32

Updated by lpfaint99 almost 10 years ago

do you have vs installed?
does it happen if you remove all gci files from the Card A folder?
if so can you zip a copy of all those files so that I can attempt to reproduce here?

Actions #33

Updated by JMC4789 almost 10 years ago

Here's my memcard folder. Deleting it didn't help when I tried it, but it started copying the files from my actual memcard file again, which maybe was the problem. Super Smash Bros. Melee is where it crashes at, I guess. That's the last file created when starting with an empty GCI folder when attempting to start system menu when I have a memory card for it to export from.

https://dl.dropboxusercontent.com/u/484730/Card%20A.7z

Actions #34

Updated by JMC4789 almost 10 years ago

I have VS installed, and all of that.

Actions #35

Updated by lpfaint99 almost 10 years ago

I can reproduce with your saves, looking into it

Actions #36

Updated by lpfaint99 almost 10 years ago

fixed in pr 651. The cause was a copy/paste of the line to get the sysmenu loader,
which happened require a force reload of the nand loader (installing a new version of the sysmenu updates the tools menu entry)

Actions #37

Updated by JMC4789 almost 10 years ago

New issue: What happened was I saved in Kirby Air Ride, and it said the size in header didn't match the actual size in and error. If you cannot reproduce, I'll upload the save file.

Actions #38

Updated by lpfaint99 almost 10 years ago

I can't reproduce with Kirby Air Ride NTSC.
The main reason for this happening would be if dolphin crashed after writing only part of the save.

I'm only saving from the main screen, do I need to go ingame?

Actions #39

Updated by JMC4789 almost 10 years ago

I went in game and closed Dolphin midrace.

Actions #40

Updated by lpfaint99 almost 10 years ago

Still unable to reproduce.
Does it happen consistently for you?
Maybe a dtm would allow me to duplicate?

Actions #41

Updated by JMC4789 almost 10 years ago

It seemed to be a random issue, I tried again and didn't have the problem.

Actions #42

Updated by lpfaint99 almost 10 years ago

maybe another developer can take a look at the Flush() function and its uses, but afaict this shouldn't happen unless there is a crash

Actions #43

Updated by parlane over 9 years ago

  • Status changed from New to Fix pending
Actions #44

Updated by JMC4789 over 9 years ago

F-Zero GX ghost data refuses to save to GCI folder, saying there's not enough space (there were 1039 blocks left.)

Actions #45

Updated by lpfaint99 over 9 years ago

worked here, both ghost and replay data
http://i.imgur.com/sw0BGuK.png

Actions #46

Updated by JMC4789 over 9 years ago

It appears to be once the memcard gets down to half space (even on regular memory cards) that it will no longer write. Tons of games are doing this. It's not GCI folder's fault.

Actions #47

Updated by lpfaint99 over 9 years ago

try with a smaller card, in gameini set MemoryCard251 = true and fill more than halfway

example
https://github.com/dolphin-emu/dolphin/blob/c68be42c556e34b6221c079c95d9c639dbbeb989/Data/Sys/GameSettings/GDXEA4.ini

Actions #48

Updated by lpfaint99 over 9 years ago

actually, you may have hit the 127 max file limit?

Actions #49

Updated by JMC4789 over 9 years ago

I have 127 files on my memcard. Oops?

Actions #50

Updated by lpfaint99 over 9 years ago

that's the problem then, I'll try to prioritize fixing that

Actions #51

Updated by JMC4789 over 9 years ago

Oh, I thought that was a hardware limitation lol. I didn't know that was an actual issue with Dolphin.

I test a lot of games, so I tend to play a lot and make a lot of saves throughout hundreds of games. I guess this time it bit me.

Actions #52

Updated by lpfaint99 over 9 years ago

oh, it is a hardware limitation. gci folder can work around this though

Actions #53

Updated by JMC4789 over 9 years ago

That'd be awesome if possible.

Actions #54

Updated by MayImilae over 9 years ago

  • Status changed from Fix pending to Accepted

JMC47 says there are still issues with this even after the merger. I'll let JMC47 and lpfaint99 sort this out.

Actions #55

Updated by JMC4789 over 9 years ago

  • Status changed from Accepted to Fixed

I haven't run into any issues with it in a long time. Counting as fixed. It's the most amazing feature ever.

Actions

Also available in: Atom PDF