Emulator

I can't reproduce.

Make sure that you have a memory card inserted.

Do not use 'GCI Folder'. You must specifically use a traditional 'Memory Card' to reproduce this.

Unable to reproduce. Can you give more exact instructions. Memory card A is set to a memory card. I start up Super Smash Bros. Melee. I start a versus mode match with an AI. I hit escape. The window closes properly.

JMC4789, you must be 'continuing without saving'? You must create a Super Smash Bros. Melee save on the memory card, then proceed with said instructions. I can reproduce it consistently.

Adding for the report. I ran Dairantou Smash Brothers DX (yes, the Japanese version) with Dolphin 4.0-2229 just now. The game runs and exits perfectly fine (given the emulator's current limitations) unless the memory card is used. After any data is saved, any attempt of exit will crash Dolphin.

So it's the memory card timings that have been causing all these crashes, wow

It's not the memory card timings; this is separate from those changes.

That's right. The memory card timings were reportedly fixed in build 4.0-2227, and this issue occurs since build 4.0-2169.

hmm, odd, but it only happens after you save, so I still think it has to with saving timings..

I can reproduce this issue in any game that writes to the memory card. If I pop up a game but it doesn't ever write to the memory card, it exits fine; however, as soon as I save, there's a very high chance that Dolphin will crash upon stopping emulation.

I thought this was an issue with timings or a problem with my build, so the first thing I did was reverted the changes from the memory card timing changes. Sure enough, the problem wasn't fixed, so I can confirm that that is not the root of the issue. Could have saved myself a few minutes if I'd have checked here first. :P

I'm running on build 4.0-2356 currently.

I think it's natural that the memory card timing changes were not the root of this problem, since it already existed a few builds earlier.

In my SoulCalibur2 tests,
After finishing the save of memory card then Pressing Esc go to crash.
But, No save and just press ESC no make crash in game.
So, I just guess that problem involved by memory save and exclusive full screen mode.
It was just few tests, I will do more tests next and find which option caused.

Try using GCI Folders instead of memory cards.

Oh, GCI folders try doesn't make crash.

Indeed. I tested just now using GCI Folders with Melee and it worked just fine. This will be the best workaround until the memory card function is fixed.

If I save a savestate before exiting dolphin doesn't crash, it only seems to crash when the last save before exiting was an ingame save.

Has rachelbryk been able to reproduce this?

No, not once.

To reproduce this, create a new memory card (NOT a GCI folder) and when prompted, create a new SSBM save on it. Start a match, then while in said match press the 'ESC' key. Also, check your SSBM MD5 hash?

Perhaps we should remove the changes which 4.0-2169 made until you can remedy this? This bug is extremely annoying, and it adds to the instability of Dolphin. If not removed, perhaps add this to 'current' milestone, because this bug has been reproduced by many others and causes Dolphin to crash; which should be avoided.

Yes, I know how to reproduce it. It does not happen to me.

https://github.com/dolphin-emu/dolphin/commit/79e90a1521f338be9ac6d638cbaf70e0ed7002bd#commitcomment-7069905

Please test https://github.com/dolphin-emu/dolphin/pull/778
https://dl.dolphin-emu.org/prs/pr-778-dolphin-latest-x64.7z

Thank you! That indeed resolved the issue. I will continue testing for adverse effects.

Good to see this issue was fixed in a PR. Was it added to a new build already?

Rev 4.0-2632 fixes this problem, but saving to the memory card causes a MAJOR slowdown from 60FPS to around 10FPS. I tried to ignore this, but just as I was saving moments ago, it corrupted my memory card file! I am rolling back until this is fixed properly...

jfields687: I also noticed the slowdown while I was making the fix for this issue. I am pretty sure the slowdown is not caused by my fix, but some memorycard changes which were introduced shortly before this fix (I haven't tracked down the exact commit - if you can do that, that would be nice).

As for corrupted memorycard, please explain a bit about what conditions are needed for it to be corrupted. I haven't seen any corruption, and I'm not sure how that could be happening.

I got the revision right before this one (4.0.2628) and I have no problems saving except for the original problem of crashing when closing. I have saved many times before my card corrupted, I was playing Luigi's Mansion. During the save I got a message that it could not be saved and when I tried again it said my memory card needed formatted. Luckily I was able to use the memory card manager and export my saves, but I guess it corrupted because of the major slowdown? I noticed that there is a huge delay before the memory card is actually written to after you save in game, as much as 30 seconds. Thanks for the reply!

The slowdown for memory cards is caused by the read speeds thing. The way Dolphin handles memcard reads is so messed up that even though we told it the right speeds, it just gets stuck at around 1/3rd the speed of console.

jfields687: yes there is a huge delay before writing the memcard to file. This is intentional and is OK. The memcard will also be written again whenever you stop emulation, so you don't need to wait for dolphin to display the yellow text, if that's what you're thinking. Maybe we should just disable this text as it's not really important anyways.

"I got a message that it could not be saved" - did dolphin say this, or the game? I might try to fix the slowdown in the future, but as JMC says, I'm sure that isn't my fault :p However, if you can tell me how to reproduce some corruption issue, I will take a look at that.

Ok, good to hear that the delay is intentional. Also, that message was in game, not dolphin. I will do what I can to reproduce it again, but I think it will take many times for it to happen again. If it helps, when I used the memory card manager, all I saw was strange unicode or something in place of where my Luigi's Mansion save was supposed to be. I should have gotten a screenshot. I appreciate the responses and will do what I can to help out! Thanks

Are GCI folders still working as intended? They were a good workaround in previous builds.

Yea, I have had no problems at all with GCI folders.