Project

General

Profile

Emulator Issues #7505

Avi dumping should dump 50/60 frames per second.

Added by phire over 5 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Feature request
Milestone:
Current
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Currently Avi dumping dumps a frame every time the game copies a frame to XFB, which is highly variable as games may switch dynamically between 30 and 60 fps or stop rendering frames while loading.

When the video is played back in a video player, the frames are played at a constant rate. This causes the video track to desync from the (currently separately dumped) audio track, which is fixed at a full 60 frames per second.

The TAS people have a hacky patch set (misnamed avsync) which implements Variable Framerate video dumping in dolphin, so that it can converted to a constant framerate later by a custom avisynth plugin.

Instead of merging this patch set, dolphin should instead be modified so that a frame is dumped for every VI interrupt, even if it's a duplicate of the previous frame. This allows dolphin to output the correctly syncing video directly.


Related issues

Has duplicate Emulator - Emulator Issues #7579: The AVI capture of a dolphin is with a problemDuplicate

Has duplicate Emulator - Emulator Issues #7715: Frame dumper skips duplicate frames (Crash Tag Team Racing)Duplicate

History

#1 Updated by tueidj over 5 years ago

For AVI files you can easily signal that the last frame should be repeated by writing a 0 byte frame. It's obviously much more efficient than dumping each duplicate frame individually.

#2 Updated by JMC4789 over 5 years ago

issue 7579 has been merged into this issue.

#3 Updated by rachelbryk over 5 years ago

issue 7715 has been merged into this issue.

#4 Updated by JMC4789 over 5 years ago

  • Milestone set to Current

Fog TAS has taken up this challenge, and should be able to complete it before a release. I think this would make a really good fix.

#6 Updated by rachelbryk over 5 years ago

  • Status changed from New to Fixed

#7 Updated by jayork42 over 5 years ago

Not fixed evidently. Now there is lag in the recorded video and the frame
rate is very fast and choppy. Looks like someone just implemented
simultaneous real time screen recording instead of actually dumping frames??

#8 Updated by JMC4789 over 5 years ago

It's glitched right now, there's a PR to refix it again.

#9 Updated by Fog over 5 years ago

#8 try 4.0-3595, it shouldn't have that issue

#10 Updated by jayork42 over 5 years ago

Ah. I tried 3599. Will do.

Also available in: Atom PDF