Emulator Issues #7505
closed
Avi dumping should dump 50/60 frames per second.
0%
Description
Currently Avi dumping dumps a frame every time the game copies a frame to XFB, which is highly variable as games may switch dynamically between 30 and 60 fps or stop rendering frames while loading.
When the video is played back in a video player, the frames are played at a constant rate. This causes the video track to desync from the (currently separately dumped) audio track, which is fixed at a full 60 frames per second.
The TAS people have a hacky patch set (misnamed avsync) which implements Variable Framerate video dumping in dolphin, so that it can converted to a constant framerate later by a custom avisynth plugin.
Instead of merging this patch set, dolphin should instead be modified so that a frame is dumped for every VI interrupt, even if it's a duplicate of the previous frame. This allows dolphin to output the correctly syncing video directly.
Updated by tueidj over 9 years ago
For AVI files you can easily signal that the last frame should be repeated by writing a 0 byte frame. It's obviously much more efficient than dumping each duplicate frame individually.
Updated by rachelbryk over 9 years ago
Issue 7715 has been merged into this issue.
Updated by JMC4789 over 9 years ago
- Milestone set to Current
Fog TAS has taken up this challenge, and should be able to complete it before a release. I think this would make a really good fix.
Updated by Fog over 9 years ago
Updated by jayork42 over 9 years ago
Not fixed evidently. Now there is lag in the recorded video and the frame
rate is very fast and choppy. Looks like someone just implemented
simultaneous real time screen recording instead of actually dumping frames??
Updated by JMC4789 over 9 years ago
It's glitched right now, there's a PR to refix it again.