Project

General

Profile

Actions

Emulator Issues #7577

closed

Crash when looking for ISOs if ISOs are corrupted.

Added by BillFleming11 about 10 years ago. Updated almost 7 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Recently I re-installed Windows 7 on one of my gaming machines, and had done some RAID testing with Intel RST (long story but it involved 4TB hard drives and Intel RST crashing).
After this was over with apparently my collection of Wii/GC games become corrupted, but had the correct file size listed still in the NTFS directory.
After re-installing everything and Dolphin, it would run, but as soon as I set a game directory (and clicked ok in the settings menu) Dolphin would crash.
If I then tried to load Dolphin again, it would hang. No error message would pop up. If I moved the game ISO away to a folder Dolphin couldn't see, then Dolphin would load again.
While Dolphin was crashing, I was observing 10-20% CPU usage on my 4.8GHz i5-2500k. Also the RAM usage would slowly go up continuously because of a RAM leak. I saw it go from about 100MB to at least 2 GB while watching.

This problem was observed from Dolphin 3.5 to 4.0-2599-x64 (latest version available today).

Dolphin needs some error handling in it's game checking routine so that it doesn't crash and can tell the user something is wrong
with the ISO. As of right now it looks like a single bad ISO will cause the whole app to crash if it is in a Dolphin game folder.

After replacing the bad isos with backup copies Dolphin started working again.

What steps will reproduce the problem?

  1. Get a game ISO, any .iso file that you use with Dolphin.
  2. Open it in a hex editor and have fun then save it.
  3. Open Dolphin with that ISO in one of your game directors in Windows.
  4. Repeat Steps 2-3 until Dolphin crashes when opening the file.

What are your PC specifications?
AsRock Z68-Extreme 4
i5-2500k @4.8GHz
16GB DDR 3 1333 7-7-7-21
(currently) AMD HD7870.
Windows 7 pro x86_x64
ALC892

Is there any other relevant information? (e.g. logs, screenshots,
configuration files)
Dolphin didn't create any logs of this issue or generate any error message.
The games were loaded from NTSC discs. One was a single disc MFT initialized, the other was an Intel RST RAID5 GPT disk with NTSF partition. Both crash the same way so it doesn't appear related to the file system.

Actions #1

Updated by mariosegafreak about 10 years ago

I'm not sure this is true. I have plenty of corrupted GCN isos that read just fine in Dolphin.

Actions #2

Updated by Lioncash about 10 years ago

Can you provide a binary patch for a game ISO that causes this to occur?

Actions #3

Updated by BillFleming11 about 10 years ago

If I see this issue again I will provide a patch.
For reference how do yall want this type of patch created or what format/patch tool should be used?

Actions #4

Updated by BillFleming11 about 10 years ago

Alright it looks like I still have all of these corrupt ISOs. I assume we all have brawl so I want to upload a patch for that one first.
However I am having issues with the binary patching software I have tried so far so I would like some recommendations. (maybe these ISOs are too large for most software)

Actions #5

Updated by Lioncash about 10 years ago

bsdiff should do the trick: http://www.daemonology.net/bsdiff/

Actions #6

Updated by JMC4789 about 10 years ago

Waiting on a response.

Actions #7

Updated by JosJuice almost 7 years ago

  • Status changed from New to Fixed

There have been many robustness improvements for this during the last year or two, so I'm closing this issue. Please comment if it isn't fixed and you have a particular disc image that makes Dolphin crash.

Actions

Also available in: Atom PDF