Project

General

Profile

Actions

Emulator Issues #7726

closed

Vertical lines in TMNT (2007)

Added by ZephyrSurfer over 9 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
GFX
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Game Name?

-- TMNT (2007 Gamecube)

Game ID?

-- GYRP41

What's the problem? Describe what went wrong in few words.

-- There is graphics issues in the opening of this title.
I am calling them Issue 1 and 2.
The two issues look alike; vertical lines in the opening.

What did you expect to happen instead?

-- Not to have such issues.

What steps will reproduce the problem?

-- 1. Start game (issue 1 is present on the language selection screen)
2. Select a language and the next two videos have the 2nd bug.

Which versions of Dolphin did you test on?

-- Lots.

Does using an older version of Dolphin solve your issue? If yes, which
versions of Dolphin used to work?

-- Yes. 4.0-1474 introduces Issue 1.
4.0-1192 introduces Issue 2.
Before 1192 there were no problems.

What are your PC specifications? (including, but not limited to: Operating
System, CPU and GPU)

-- Windows 8.1, Intel Pentium G3258, AMD R9 290

Is there any other relevant information? (e.g. logs, screenshots,
configuration files)

-- Specifically this commit introduces issue 2: https://github.com/dolphin-emu/dolphin/commit/16109fb453589a06b7aef0306c66e1d0ee02a874

Screenies:

Issue 1:
Without: http://imgur.com/OFPBYyK
With : http://imgur.com/sfFIvk9

Issue 2:
Without: http://imgur.com/Oz1NqUN
With : http://imgur.com/x4Nm2FM

Actions #1

Updated by ZephyrSurfer over 9 years ago

Damn, I linked to old issue reports by accident and there is a typo on the title.
I can't edit that sorry :(

Actions #2

Updated by kostamarino over 9 years ago

This issue is probably related to Issue 7393, lines in videos after the merge of tev_fixes_new.

Actions #3

Updated by ZephyrSurfer over 9 years ago

I thought as much but the commit before the one that introduced TMNT's 2nd bug has that issue

Actions #4

Updated by ZephyrSurfer over 9 years ago

As an FYI my screenshots here are the commits immediately before and when one these problems got introduced. So it is unrelated to Issue 7393

Actions #5

Updated by kostamarino over 9 years ago

Could you explain a bit better what you mean with the above? I fail to see how they are unrelated.

Actions #6

Updated by ZephyrSurfer over 9 years ago

https://github.com/dolphin-emu/dolphin/commit/50526ae50aff4caa6453ba05f6ce1e2da967400d

Sorry for lacking clarity.
This commit is before any bugs are introduced in TMNT(2007) but the issue with 7397 is present, thusly unrelated.

Actions #7

Updated by JMC4789 over 9 years ago

Figure I'll CC neobrain, he'll understand it better than anyone else.

Actions #8

Updated by JMC4789 over 9 years ago

You should probably get a fifolog if there isn't one and post it.

Actions #9

Updated by pauldacheez over 9 years ago

  • Status changed from New to Accepted
  • Regression set to Yes
  • Category set to gfx
Actions #10

Updated by ZephyrSurfer over 9 years ago

I'll post a fifolog tomorrow.

Actions #11

Updated by ZephyrSurfer over 9 years ago

Oh gawd! Something tells me this is related.

I know you guys don't accept any issues relating to enhancements(and I normally don't bother with anything but higher IR and some AA)
but with Anistropic Filtering and non-native IR the results are ridiculous.

Here is a screenshot of 4X IR and X16 Anisotropic Filtering:
http://imgur.com/7g7HnO2

That was the language selection screen if you can't tell :(

I'll bisect later.

Actions #12

Updated by ZephyrSurfer over 9 years ago

I've narrowed down the new bug I've discovered.

It goes back a very long way. However, I can't easily compile such old code.
Dolphin-win-x64-r5750 and previous does not exhibit this bug.
The next compiled version I could find, Dolphin-win-x64-r5765 does have the bug.

Would someone provide builds between 5750-5765 so I can the specific cause. Thanks.

Ps. I used builds linked to from: https://forums.dolphin-emu.org/Thread-dolphin-build-archive

Actions #13

Updated by JMC4789 over 9 years ago

If you really care about that issue, make your own issue report. It's off topic for this one, and likely will confuse people reading it. I got confused while I did my research on the vertical lines issue and it wasted like 2 mins until I found out I was dumb.

Anyway, I did some extensive research on this bug, and I found out two things.

1: NVIDIA was always broken. Before Tev_Fixes_New, NVIDIA displayed issue 2 already.

2: The original issue reporter did a badass job of bisecting for Radeon. Everything was spot on from what they said. Prior to tev_fixes_new, everything looked fine on AMD. Then the Horizontal Lines showed up. These Horizontal Lines were in NVIDIA always.

On NVIDIA though, Tev_Fixes_New introduced the vertical lines!

3: Shifted Pixel Centers caused the vertical lines in AMD cards. NVIDIA stays the same. Their behavior is now almost identical.

API-Traces of before and after on my NVIDIA GTX 560m. Buffer Storage disabled, of course: https://dl.dropboxusercontent.com/u/484730/Traces.zip

Actions #14

Updated by JMC4789 over 9 years ago

This build will fix the issue entirely on Radeon Cards, and on NVIDIA's it will return behavior to before Tev-fixes-new.

https://dl.dolphin-emu.org/prs/pr-1653-dolphin-latest-x64.7z

Actions #15

Updated by ZephyrSurfer over 9 years ago

I'm gonna borrow my housemates computer later and track down what causes the NVidia issue it's bugging me now even though I don't have it.

Actions #16

Updated by ZephyrSurfer over 9 years ago

@JMC Could you perhaps share two fifologs.
I know this is my issue report but I won't be able to make one for quite a while.

Actions #17

Updated by degasus about 9 years ago

Is this fixed by 4.0-5569 ?

Actions #18

Updated by JMC4789 about 9 years ago

  • Status changed from Accepted to Fixed
Actions

Also available in: Atom PDF