Project

General

Profile

Emulator Issues #7755

Silent Hill Shattered Memories D3D flashlight issue [Viewport Issue]

Added by Autoran1 about 6 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Game Name:
Silent Hill Shattered Memories

Game ID
R5WEA4

What's the problem? Describe what went wrong in few words.

Everyone knows about flashlight issue on D3D, and galop1n branch fixes it, but his last commit was very huge, so it's really hard to find exact changes. But i found that in files: VertexShaderGen.cpp, VertexShaderGen.h, VertexShaderManager.cpp, VertexShaderManager.h, D3D/Render.cpp
all changes in these files connected with ViewportNonStandard() value fixes this
and since i'm not a coder it much likely will break some other stuff, so please some one look at this code
I also think it will fix some other D3D specified issues

Tested on latest git modiffied with this

What are your PC specifications? (including, but not limited to: Operating
System, CPU and GPU)
Core i7 4770k @4,6Ghz
GF 780 GTX Driver 340.52
Windows 7 x64

and proof screen
http://i.minus.com/iiWVTigwhotkr.jpg

History

#1 Updated by JMC4789 about 6 years ago

  • Status changed from New to Accepted

Can you narrow it down a bit. This seems useful. Make as small of a patch as possible to fix it.

#2 Updated by Autoran1 about 6 years ago

Well, here's the part of galop1n's code i've used to take it down

#3 Updated by JMC4789 about 6 years ago

Thanks :)

#4 Updated by NeoBrainX about 6 years ago

@autoran: please don't assume "everyone knows about the flashlight issue on d3d"... that sort of destroys the whole purpose of this issue report, and what's more it basically blocks anyone who hasn't worked on the original SH issues to do anything useful with this.

#5 Updated by JMC4789 about 6 years ago

I asked Kayru and neobrain to check out the patch, hopefully one of them will be able to do something with it.

#7 Updated by JMC4789 about 6 years ago

  • Status changed from Accepted to Fixed

Fixed by 4.0-3748 -> https://dolphin-emu.org/download/dev/78deebd73281a3c4e451736d6e43bb49b7e7eaed/

I don't have this game to check, but I'm pretty damn sure this will work.

#8 Updated by Autoran1 about 6 years ago

Amazing like the other viewport marked issues this one is fixed as well

#9 Updated by JMC4789 about 6 years ago

Yeah... we screwed up a setting in D3D. Whoops! It was a one word change.

Also available in: Atom PDF