Project

General

Profile

Actions

Emulator Issues #7926

closed

Save states forgetting previous frame input

Added by blunderstabtas over 9 years ago. Updated over 7 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Game Name?
Donkey Kong Jungle Beat

Game ID?
GYBE01

What's the problem? Describe what went wrong in few words.
Trying out Dolphin 4.0-4547, I noticed some odd behavior with Save States. When I save a state, the input of the previous frame is usually ignored. So say on Frame 2567, I input "Start" to begin a level, and then I save state at 2568. The "Start" works fine at that point. But when I reload the state, the game has not received the "Start" I input on 2567 and does not begin the level. SOMETIMES it properly saves the last frame's input, but this inconsistency causes a lot of trouble for TAS.

What did you expect to happen instead?
In previous versions, it would remember the input of the previous frame every time.

What steps will reproduce the problem?
[Don't assume we have ever played the game and know any level names. Be as
specific as possible.]

  1. "Pause" the game so that you can Frame Advance one at a time.
  2. Input a button press that has an obvious effect, advancing one frame.
  3. Save state.
  4. Let the game play and make sure the input went through.
  5. Load state; the same input will most likely not happen.

Dolphin 3.5 and 3.5-367 are old versions of Dolphin that have
known issues and bugs, so don't report issues about them and test the
latest Dolphin version first.
Which versions of Dolphin did you test on?
I tested multiple versions. 4.0-4523 functions correctly. 4.0-4536 introduces this inconsistency. This is in terms of versions that are available to download, so if 4524 through 4535 also exist it could be any one of these.

Does using an older version of Dolphin solve your issue? If yes, which
versions of Dolphin used to work?
4.0-4523

What are your PC specifications? (including, but not limited to: Operating
System, CPU and GPU)
Windows 7

Is there any other relevant information? (e.g. logs, screenshots,
configuration files)
[Upload big files to a hosting service and post links here!]

[Do not attach files to this issue. Upload them to another site and
link here. Use imgur.com for images and pastie.org for logs. Monitor the
email address that was used to create this issue.]

Actions #3

Updated by blunderstabtas over 9 years ago

I'm not sure how to go about reverting a thing, but if you can point me to some instructions, I could give it a try! Assuming that wasn't directed at Rachel.

Actions #4

Updated by JMC4789 over 9 years ago

If you have the repository and know how to build, it's as simple as "git revert 854f6b86" and then rebuilding the emulator.

Actions #5

Updated by JosJuice over 9 years ago

  • Status changed from New to Accepted
  • Regression set to Yes
  • Milestone set to Current
Actions #6

Updated by JosJuice about 9 years ago

I've made a PR that reverts 854f6b8. Does it fix this issue?

PR: https://github.com/dolphin-emu/dolphin/pull/2398
Windows build: http://dl.dolphin-emu.org/prs/pr-2398-dolphin-latest-x64.7z

Actions #7

Updated by JMC4789 almost 9 years ago

  • Milestone deleted (Current)

I'm removing current from this as we probably won't get around to fixing this issue in particular. There may be some bigger rewrites to TAS input that fix it though in the future.

Actions #8

Updated by JosJuice over 8 years ago

Is this issue still present in either the development builds or the 5.0 release candidate? The PR I linked to earlier has been merged for a while now.

Actions #9

Updated by JosJuice over 7 years ago

Please test whether this issue still exists, otherwise I'll close this as fixed.

Actions #10

Updated by JosJuice over 7 years ago

  • Status changed from Accepted to Fixed

No response.

Actions

Also available in: Atom PDF