Project

General

Profile

Actions

Emulator Issues #8005

closed

Metroid Prime Trilogy render issues(possibly OpenGL exclusive)

Added by shreduhsoreus over 9 years ago.

Status:
Fixed
Priority:
High
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Game Name?

Metroid Prime Trilogy

Game ID?

R3ME01

What's the problem? Describe what went wrong in few words.

Certain objects render weird. They appear as if they are rendering too large. Looking at what they are supposed to look like compared to what they do look like, it almost seems as though each pixel is being rendered enlarged or "blown up". It occurs with raindrops, sparks that fly from certain explosions(one specific example being shooting a door to open it), electrical discharges by an enemy called "Bombu"(along with the enemy itself) and probably other things that have a similar appearance.

What did you expect to happen instead?

Not this lol

What steps will reproduce the problem?

  1. Play Metroid Prime 1 from Metriod Prime Trilogy on 4.0-4699 or newer with OpenGL backend
  2. Shoot a door to open it, or find an enemy known as "Bombu"(can provide a save one room away from some, they don't appear early in the game), or find a place with heavy rain(landing zone on Talon IV is a good example and is right after the intro that takes roughly 10-15 minutes to get through).
  3. Witness the render issues.

Dolphin 3.5 and 3.5-367 are old versions of Dolphin that have
known issues and bugs, so don't report issues about them and test the
latest Dolphin version first.
Which versions of Dolphin did you test on?

The issue is introduced in 4.0-4699 and continues up until the build where ES_Launch no longer works. The description for -4699 is "VideoCommon: Merge LineGeometryShader into GeometryShaderGen". I don't know EXACTLY what those mean, but judging by the nature of the bug and what(I think) those 2 things are, it sounds like that may be what caused it, though I'm just making a partially educated guess in an attempt to help locate what's causing the problem.

Does using an older version of Dolphin solve your issue? If yes, which
versions of Dolphin used to work?

4.0-4674 and older.

What are your PC specifications? (including, but not limited to: Operating
System, CPU and GPU)

W7 Pro x64 | i7 4700MQ @ ~3.4GHz | GT 740M 2GB | 12GB DDR3 @ 1600Mhz

Is there any other relevant information? (e.g. logs, screenshots,
configuration files)

I am unable to test to see if this issue occurs on the D3D backend as D3D doesn't work for me with Dolphin anymore. It is possible that this issue is OpenGL exclusive, somebody else will have to confirm that.

Not every area with rain has the issue, in some areas it depends on where I'm standing, but when it happens(more often than not) it affects all rain on screen. Staring up at the sky as incorrectly rendered raindrops fall causes a serious slowdown.

There are two types of "Bombu". One is more free moving and frequently drops an electrical discharge "bomb", the other is found in some circular hallways and has constant electricity flowing out of it. The former renders fine if they are in a big open space, but messed up in more contained areas. The latter renders fine in first person mode, but renders weird in Morph Ball mode.

Correctly rendered rain:
http://postimg.org/image/k1xo7qo4h/
http://postimg.org/image/53f9db929/

Incorrectly rendered rain:
http://postimg.org/image/h06vxsazl/
http://postimg.org/image/qw7yxfgrl/
http://postimg.org/image/6nklbphgh/

Correctly rendered "Scatter Bombu":
http://postimg.org/image/e73qcoqf9/
http://postimg.org/image/c3tb50qmd/

Incorrectly rendered "Scatter Bombu":
http://postimg.org/image/9qs865g1h/
http://postimg.org/image/shu5gbalx/

Incorrectly rendered "Pulse Bombu"(I don't have correct screenshots, but by now you get the idea anyway):
http://postimg.org/image/kvsb5kf1p/
http://postimg.org/image/mdicuv965/
http://postimg.org/image/gldn9z9yl/

If I can provide any other information or anything at all to be of further help, please let me know.

Actions #1

Updated by JMC4789 over 9 years ago

Looks like line-width/Pointsize problems. Thanks for the excellent documentation of it.

Try this build: https://dl.dolphin-emu.org/prs/pr-1747-dolphin-latest-x64.7z

Actions #2

Updated by shreduhsoreus over 9 years ago

ES_Launch error message

Actions #3

Updated by JMC4789 over 9 years ago

umm, right. My bad. we have to wait until that's merged.

Actions #4

Updated by shreduhsoreus over 9 years ago

No problem. I'll keep an eye out.

Actions #5

Updated by JosJuice over 9 years ago

Here's a special build of PR 1747 with the ES_Launch fix merged: https://dl.dropboxusercontent.com/u/26683170/Dolphin-pr-1747-1756.7z

Actions #6

Updated by shreduhsoreus over 9 years ago

No change.

Actions #7

Updated by shreduhsoreus over 9 years ago

This is just me throwing out ideas, but is the merge that took place in -4699 necessary for a performance boost or was it just to make the code cleaner/more organized? If the latter, is it possible to undo that change in a new temp build just for the sake of testing to see if that is exactly what caused the issue, or is that a huge hassle?

Actions #8

Updated by Armada over 9 years ago

@shreduhsoreus This can very well be caused by the LineGeometryShader merge. Could you record a FIFO log of a frame that shows the error?

Actions #9

Updated by shreduhsoreus over 9 years ago

Absolutely. Give me a few minutes(reading on the wiki how to do that lol) and I'll have one for you.

Actions #11

Updated by Armada over 9 years ago

  • Status changed from New to Fix pending
  • Priority set to High
  • Regression set to Yes

Please try this build: http://dl.dolphin-emu.org/prs/pr-1771-dolphin-latest-x64.7z.

Great report, this issue was easy to fix because of it.

Actions #12

Updated by Armada over 9 years ago

Oops just saw that you may not be able to use that build because of the ES_Launch bug. You'll have to wait until both PRs are merged.

Actions #13

Updated by shreduhsoreus over 9 years ago

Perfect. Excellent work.

Let me know if you guys ever need something tested extensively, I'll be happy to help in any way I can...provided that I don't need to know how to actually read logs or do coding lol.

Actions #14

Updated by JMC4789 over 9 years ago

The ES_Launch thing was merged; it should work.

Actions #15

Updated by shreduhsoreus over 9 years ago

It did :)

Actions #16

Updated by Armada over 9 years ago

  • Status changed from Fix pending to Fixed
Actions

Also available in: Atom PDF