https://bugs.dolphin-emu.org/https://bugs.dolphin-emu.org/favicon.ico?12015-01-06T04:44:38ZDolphin bug trackerEmulator - Emulator Issues #8068: Invalidate JIT blocks that are modified by cheatshttps://bugs.dolphin-emu.org/issues/8068?journal_id=7168572015-01-06T04:44:38Zmagumagu9magumagu9@gmail.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Accepted</i></li><li><strong>Easy</strong> set to <i>Yes</i></li></ul><p>It would be nice if you could provide an example cheat which demonstrates this issue.</p>
<p>This is probably a good first patch for someone looking to help improve Dolphin. The relevant code is in PatchEngine.cpp and ActionReplay.cpp; the code needs to call JitInterface::InvalidateICache whenever it writes to memory.</p>
Emulator - Emulator Issues #8068: Invalidate JIT blocks that are modified by cheatshttps://bugs.dolphin-emu.org/issues/8068?journal_id=7168582015-01-06T04:59:01Zbenrainbenrain@gmail.com
<ul></ul><p>Hi, I've been looking to get helping out Dolphin for awhile now.</p>
<p>I'll go ahead and give this a look. I have a local dump of the game I can use.</p>
<p>Reproducible steps would be appreciated but I can go ahead and get started.</p>
Emulator - Emulator Issues #8068: Invalidate JIT blocks that are modified by cheatshttps://bugs.dolphin-emu.org/issues/8068?journal_id=7168592015-01-06T21:16:22Zdantariondantarion@gmail.com
<ul></ul><p>I believe this may fix Project M as well.</p>
Emulator - Emulator Issues #8068: Invalidate JIT blocks that are modified by cheatshttps://bugs.dolphin-emu.org/issues/8068?journal_id=7168602015-01-07T02:23:54Zbenrainbenrain@gmail.com
<ul></ul><p>I wrote the expected code yesterday for both scenarios; but I am still awaiting some reproducible steps. Not sure how to write or where to obtain cheats to test with.</p>
Emulator - Emulator Issues #8068: Invalidate JIT blocks that are modified by cheatshttps://bugs.dolphin-emu.org/issues/8068?journal_id=7168612015-01-07T02:27:03ZCryZe92CryZe92@gmail.com
<ul></ul><p>This one is one of them for Wind Waker NTSC-U (GZLE01)</p>
<p>hold A to walk through walls/sail through islands [wiiztec]<br>
040A38D0 4BFFF86D<br>
040A38E8 4BFFD9BD<br>
283ED84A FEFF0100<br>
040A38D0 60000000<br>
040A38E8 60000000<br>
E0000000 80008000</p>
<p>the 04 codes write into code area, so the cheat restores the original code in the first two lines and then conditionally overwrites it with NOPs in the fourth and fifth line.</p>
Emulator - Emulator Issues #8068: Invalidate JIT blocks that are modified by cheatshttps://bugs.dolphin-emu.org/issues/8068?journal_id=7168622015-01-07T02:29:32Zbenrainbenrain@gmail.com
<ul></ul><p>Thanks, I'll test it out now!</p>
Emulator - Emulator Issues #8068: Invalidate JIT blocks that are modified by cheatshttps://bugs.dolphin-emu.org/issues/8068?journal_id=7168632015-01-07T02:30:38ZJMC4789JMC4789@gmail.com
<ul></ul><p>I have Project M to test if you do come up with a patch. Thanks.</p>
Emulator - Emulator Issues #8068: Invalidate JIT blocks that are modified by cheatshttps://bugs.dolphin-emu.org/issues/8068?journal_id=7168642015-01-08T20:15:21Zmagumagu9magumagu9@gmail.com
<ul></ul><p>To clarify, this issue is about ActionReplay etc. codes... patched ISOs with invalidation issues are issue 7288.</p>
Emulator - Emulator Issues #8068: Invalidate JIT blocks that are modified by cheatshttps://bugs.dolphin-emu.org/issues/8068?journal_id=7168652015-01-13T05:47:22Zbenrainbenrain@gmail.com
<ul></ul><p>Sorry for the lack of update; I was able to put forth the proposed solution invalidating the ICache; did not have any luck with it.</p>
Emulator - Emulator Issues #8068: Invalidate JIT blocks that are modified by cheatshttps://bugs.dolphin-emu.org/issues/8068?journal_id=7168662015-01-14T18:10:50Zdantariondantarion@gmail.com
<ul></ul><p>The hilarious thing is that this code is made by the same person that made the codes in Project M that don't work in Dolphin! Ill take a stab at this this weekend</p>
Emulator - Emulator Issues #8068: Invalidate JIT blocks that are modified by cheatshttps://bugs.dolphin-emu.org/issues/8068?journal_id=7168672015-06-11T16:38:58ZJMC4789JMC4789@gmail.com
<ul></ul><p>Anythign come of this? It sucks that Project M's codes don't work either, but at least we could fix our loader for people using Action Replay/Gecko Codes through dolphin.</p>
Emulator - Emulator Issues #8068: Invalidate JIT blocks that are modified by cheatshttps://bugs.dolphin-emu.org/issues/8068?journal_id=7168682015-06-11T17:16:57ZCryZe92CryZe92@gmail.com
<ul></ul><p>Not yet, I'll work on this now I guess.</p>
Emulator - Emulator Issues #8068: Invalidate JIT blocks that are modified by cheatshttps://bugs.dolphin-emu.org/issues/8068?journal_id=7168692015-06-11T18:16:02ZCryZe92CryZe92@gmail.com
<ul></ul><p>I got it to somewhat work, but there's still a slight delay :(<br>
It looks like Invalidating the ICache only actually forces it to recompile every ~5 seconds. Any ideas?</p>