Project

General

Profile

Emulator Issues #8195

Creation of a hybrid xfb mode for games that need real xfb only at certain times ingame (videos for example).

Added by kostamarino almost 5 years ago. Updated almost 2 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
GFX
% Done:

0%

Operating system:
N/A
Issue type:
Feature request
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
5.0-5874

Description

There are plenty of games currently that need real xfb only at certain times ingame, usually during video playback. The current way we deal with it is the enforcement of real xfb for the whole game through the gameini files, the downside of it is that all of them have to be played at low res for a proper experience, for something that sporadically happens ingame canceling one of dolphins greatest features which is upscaling. According to phiren's request i am opening this issue with his proposal on how to deal with it:

"Theoretically a "Hybrid XFB" mode could exist. Acts like virtual xfb unless it (somehow) detect something has been written to the xfb. Then it could switch to real xfb mode. Every frame it would have to check if anything has been written to xfb (such a check could be implemented through hashing, filling the xfb with zeros, cache flushes or locking)

Then the xfb would be transferred to the video card and either keyed into the virtual xfb or replacing the complete contents of virtual xfb."


Related issues

Has duplicate Emulator - Emulator Issues #8194: NASCAR Thunder 2003-Videos don't output graphicsDuplicate

History

#1 Updated by phire almost 5 years ago

  • Status changed from New to Accepted
  • Priority set to Normal
  • Category set to gfx

#2 Updated by Sonicadvance1 almost 5 years ago

Phantasy star Online in particular uses the XFB directly for its prerendered videos, but the rest of the game doesn't need it.

#3 Updated by JMC4789 almost 5 years ago

Lots of older EA Sports games as well; hell, tons of games period use this.

Can this be detected though?

#4 Updated by degasus almost 5 years ago

Yeah, this can very likely be detected. While you're on xfb emulation, could you also move the code to calculate the coordinates into VideoCommon?

#5 Updated by AmbientMalice almost 5 years ago

Agent Under Fire would benefit from this. I heartily approve.

#6 Updated by phire almost 5 years ago

  • Status changed from Accepted to Work started

#7 Updated by kostamarino almost 5 years ago

Oh this is great, i will test this pronto.

#8 Updated by theincrediblemastere almost 5 years ago

I am ready for the future.

The only thing better than this would probably be 100% accurate Texture EFB copies. But oh well. Baby steps?

#9 Updated by MayImilae over 4 years ago

issue 8194 has been merged into this issue.

#10 Updated by theincrediblemastere over 3 years ago

Phire mentioned working on a new version of the PR he posted last year.

Care to share this new version with us, just to know where it is and how it's going?

#11 Updated by theincrediblemastere over 3 years ago

theincrediblemastere wrote:

Phire mentioned working on a new version of the PR he posted last year.

Care to share this new version with us, just to know where it is and how it's going?

phire Oh yeah I needed to add that to get his attention.

#12 Updated by phire over 3 years ago

phire Oh yeah I needed to add that to get his attention.

No, I got the email anyway, just been busy.

The new version is waiting on a rewrite of texture cache/virtual xfb code and it doesn't actually exist as code.

#13 Updated by phire over 3 years ago

BTW, the new version now exists and can be found in PR3880

https://github.com/dolphin-emu/dolphin/pull/3880

#14 Updated by kolano almost 2 years ago

Should this have closed out with Hybrid XFB?

#15 Updated by JosJuice almost 2 years ago

  • Fixed in set to 5.0-5874
  • Assignee deleted (phire)
  • Status changed from Work started to Fixed

Also available in: Atom PDF