Emulator Issues #8195: Creation of a hybrid xfb mode for games that need real xfb only at certain times ingame (videos for example). - Emulator - Dolphin bug tracker

Actions

Copy link

Emulator Issues #8195

closed

Creation of a hybrid xfb mode for games that need real xfb only at certain times ingame (videos for example).

Added by kostamarino almost 10 years ago. Updated almost 7 years ago.

Status:

Fixed

Priority:

Normal

Assignee:

Category:

GFX

% Done:

Operating system:

N/A

Issue type:

Feature request

Milestone:

Regression:

Relates to usability:

Relates to performance:

Easy:

Relates to maintainability:

Regression start:

Fixed in:

5.0-5874

Description

There are plenty of games currently that need real xfb only at certain times ingame, usually during video playback. The current way we deal with it is the enforcement of real xfb for the whole game through the gameini files, the downside of it is that all of them have to be played at low res for a proper experience, for something that sporadically happens ingame canceling one of dolphins greatest features which is upscaling. According to phiren's request i am opening this issue with his proposal on how to deal with it:

"Theoretically a "Hybrid XFB" mode could exist. Acts like virtual xfb unless it (somehow) detect something has been written to the xfb. Then it could switch to real xfb mode. Every frame it would have to check if anything has been written to xfb (such a check could be implemented through hashing, filling the xfb with zeros, cache flushes or locking)

Then the xfb would be transferred to the video card and either keyed into the virtual xfb or replacing the complete contents of virtual xfb."

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by phire almost 10 years ago

Status changed from New to Accepted
Priority set to Normal
Category set to gfx

Actions

Copy link

Updated by Sonicadvance1 almost 10 years ago

Phantasy star Online in particular uses the XFB directly for its prerendered videos, but the rest of the game doesn't need it.

Actions

Copy link

Updated by JMC4789 almost 10 years ago

Lots of older EA Sports games as well; hell, tons of games period use this.

Can this be detected though?

Actions

Copy link

Updated by degasus almost 10 years ago

Yeah, this can very likely be detected. While you're on xfb emulation, could you also move the code to calculate the coordinates into VideoCommon?

Actions

Copy link

Updated by AmbientMalice almost 10 years ago

Agent Under Fire would benefit from this. I heartily approve.

Actions

Copy link

Updated by phire almost 10 years ago

Status changed from Accepted to Work started

I've started on this. See PR #2051

https://github.com/dolphin-emu/dolphin/pull/2051

Actions

Copy link

Updated by kostamarino almost 10 years ago

Oh this is great, i will test this pronto.

Actions

Copy link

Updated by theincrediblemastere almost 10 years ago

I am ready for the future.

The only thing better than this would probably be 100% accurate Texture EFB copies. But oh well. Baby steps?

Actions

Copy link

Updated by MayImilae almost 10 years ago

Issue 8194 has been merged into this issue.

Actions

Copy link

#10

Updated by theincrediblemastere over 8 years ago

Phire mentioned working on a new version of the PR he posted last year.

Care to share this new version with us, just to know where it is and how it's going?

Actions

Copy link

#11

Updated by theincrediblemastere over 8 years ago

theincrediblemastere wrote:

Phire mentioned working on a new version of the PR he posted last year.

Care to share this new version with us, just to know where it is and how it's going?

@phire Oh yeah I needed to add that to get his attention.

Actions

Copy link

#12