Project

General

Profile

Actions

Emulator Issues #8197

closed

Set a key/button in hotkey configuration will also trigger the action immediately. (Toggle Fullscreen = crash)

Added by rukariosake about 9 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

With PR #1949, the Dolphin will trigger hotkey action anywhere and immediately with a button or key.

Actions #1

Updated by skidau about 9 years ago

  • Status changed from New to Work started

Have created PR 2010 to fix this. Please test it out and let me know if the problem is fixed:

https://github.com/dolphin-emu/dolphin/pull/2010

Download a test build here:
http://dl.dolphin-emu.org/prs/pr-2010-dolphin-latest-x64.7z

Actions #2

Updated by rukariosake about 9 years ago

Fixed, but should we worry that it is only when game is running? It's actually better than triggering hotkeys immediately anywhere at least.

Actions #3

Updated by rukariosake about 9 years ago

Well, it appears that it will trigger anywhere as long as the game is running.

Toggel Fullscreen =/= crash this time.

Actions #4

Updated by skidau about 9 years ago

  • Status changed from Work started to Fixed

Yes, this is so that it fixes issue 7652.

Fixed by 4.0-5406
https://dolphin-emu.org/download/dev/012a4c18ff9b8beeaafcf3e24846761e5c194a42/

Actions #5

Updated by rukariosake about 9 years ago

I wouldn't say that it's fully fixed. It's just odd to have hotkeys triggered while setting up with keys/buttons within the hotkey window. I don't think that issue 7652 should also apply to there.

It's happening while the game is running.

Actions #6

Updated by skidau about 9 years ago

Turning off "background input" should fix the keys being triggered while the game is running.

Actions #7

Updated by rukariosake about 9 years ago

It seem to be in effect only when Dolphin is out of focus. Not for hotkey setting window itself as it's still part of Dolphin...

Let's say for example: When you run a game in windowed mode and go to hotkey setting window, you set a button for "Open" in there.

What will happen in your end?

I'm on Windows 7 if that means anything to you.

But hey, it's not big deal. It apparently doing the same thing while configuring the game pad.

Actions #8

Updated by rukariosake about 9 years ago

I meant when gamepad's background input is on.

Actions #9

Updated by rukariosake about 9 years ago

I take that back.

BACKGROUND ON in Controller Setting - Anywhere
BACKGROUND OFF in Controller Setting - Only when game emulation window is focused

BACKGROUND ON in Hotkey Setting - Anywhere
BACKGROUND OFF in Hotkey Setting - Anywhere within Dolphin's focus

Actions #10

Updated by rukariosake about 9 years ago

*BACKGROUND INPUT

Actions #11

Updated by rukariosake about 9 years ago

Just discovered that this only happen when rendering in separate window.

Graphics -> Render to Main Window -> OFF

Actions #12

Updated by rukariosake about 9 years ago

Anyone please confirm?

Actions

Also available in: Atom PDF