Project

General

Profile

Emulator Issues #8258

Buildbot doesn't clean directory when files are removed.

Added by kostamarino over 5 years ago. Updated over 2 years ago.

Status:
Accepted
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

The buildbot seems to build even deleted gameinis, whereas there are 1571 gameinis in the repository there are 2787 in every build the buildbot makes. While this will cause no immediate problems now, it will cause if any additional gameini pr is made. The general gameinis will be updated but if the deprecated region specific gameinis still exist they will override the general ones. Meaning no actual update will be possible until the buildbot issue is fixed.


Related issues

Has duplicate Emulator - Emulator Issues #8281: Old INI files still in 4.0-5695Duplicate

History

#1 Updated by kostamarino over 5 years ago

The reason this wasn't found before is probably because there were either additions or changes in the database, deletions were rare.

#2 Updated by magumagu9 over 5 years ago

This isn't the first time we've run into issues with buildbots not correctly cleaning the build folder; we should just configure the buildbots to rm -rf dolphin/Binary before every build.

#3 Updated by JMC4789 over 5 years ago

  • Status changed from New to Accepted
  • Priority set to Low

#4 Updated by kostamarino over 5 years ago

  • Priority changed from Low to Normal

I am changing the priority, this now causing issues by using depracated gameinis that shouldn't exist.

#5 Updated by BhaaL over 5 years ago

issue 8281 has been merged into this issue.

#6 Updated by Buddybenj over 5 years ago

  • Milestone set to Current

#7 Updated by JosJuice over 5 years ago

issue 8318 has been merged into this issue.

#8 Updated by JosJuice over 5 years ago

  • Priority changed from Normal to High

Along with causing performance problems by using EFB2RAM for titles that don't need to be using it anymore, this is also making three Hyrule Field Speed Hacks show up for RZDE01 even though there only should be one.

#9 Updated by kostamarino over 5 years ago

Even a one time manual cleanup would help a lot since the gameini database has been converted. This issue piles up issues with every gameini database update for those using the buildbot builds.

#10 Updated by parlane about 5 years ago

FWIW I have cleaned the windows builders.

#11 Updated by kostamarino about 5 years ago

Yes, finally 3000 less gameinis!

#12 Updated by JMC4789 about 5 years ago

  • Priority changed from High to Normal
  • Milestone deleted (Current)

I think for now we can remove current as the huge problem is fixed.

#13 Updated by JosJuice over 4 years ago

  • Priority changed from Normal to High

Recent PR builds (for Windows, I haven't looked at other OSes) contain the executables DSPTool.exe, Dolphin.exe, DolphinQt.exe and DolphinWX.exe. The last two of those are not supposed to exist. My guess is that spxtr's DolphinQt rewrite PRs (3221 and 3261) created these executables, making them show up in all other PRs too because the buildbot doesn't remove files properly. They are confusing for users and waste space.

#14 Updated by parlane over 4 years ago

  • Priority changed from High to Normal

Deleted windows build directories.

#15 Updated by JosJuice over 4 years ago

That's not a sustainable solution. PR 3261 keeps recreating DolphinQt.exe every time it's rebuilt. This has already happened once, as you can see with DolphinQt.exe being present in the pr-win-x64 build 4341 of PR 3265.

#16 Updated by JosJuice over 2 years ago

Addressed for Windows by https://github.com/dolphin-emu/sadm/commit/15b06d7ac58dce0f8a611c156fffecf47538774a. I don't know what the status is for the other OSes.

Also available in: Atom PDF